Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed
github-actions bot opened this issue Feb 26, 2024 · 28 comments
Closed

Deploy Checklist: New Expensify 2024-02-26 #37224

github-actions bot opened this issue Feb 26, 2024 · 28 comments
Assignees
@puneetlath @applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited by puneetlath
Loading

Release Version: 1.4.44-13
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads
@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Feb 26, 2024
@puneetlath puneetlath self-assigned this Feb 26, 2024
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.44-0 🚀

@luacmartins
Copy link
Contributor

Checking off #37235. Dupe of #37109

@roryabraham
Copy link
Contributor

Demoted #37239

@youssef-lr
Copy link
Contributor

Checking off #37248, I can reproduce in production.

@techievivek
Copy link
Contributor

#37253 is resolved.

@Julesssss
Copy link
Contributor

I checked off #36807 from the internal QA list 🎉

@ikevin127 ikevin127 mentioned this issue Feb 27, 2024
Closed
6 tasks
@melvin-bot Melvin Bot

This comment has been minimized.

Sign in to view
@Julesssss
Copy link
Contributor

I'm not sure who checked off #37291, but it is definately not a blocker

@ikevin127 ikevin127 mentioned this issue Feb 27, 2024
Closed
6 tasks
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 27, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@kavimuru
Copy link

Regression is 7% left. We are still working on the PRs.

#34409 is failing in mweb with #37276 and repro in PROD, checking if off
#35065 failing with #37252 in android
#35451 is failing with known bug #32699.checking it off. Please see comment #35451 (comment)

@rlinoz
Copy link
Contributor

rlinoz commented Feb 27, 2024

Demoted #37279

@lakchote lakchote mentioned this issue Feb 27, 2024
Closed
6 tasks
@grgia
Copy link
Contributor

grgia commented Feb 27, 2024

demoted #37294

@blimpich
Copy link
Contributor

Demoted #37326

@roryabraham
Copy link
Contributor

Going to take a pass at all the deploy blockers, try to list out all the ones associated with the BaseOptionsSelector refactor, and see which are unresolved and try to fix them with a single holistic PR.

I don't think we should HOLD other contributors from addressing individual issues, because I don't know how difficult a holistic refactor will be

@chiragsalian
Copy link
Contributor

QA team, we CP-d this PR #37305. Since its a revert there is nothing to to test directly with that PR.
Instead can you retest its linked issues, they are all deploy blockers and if the issue is resolved please clear the deploy blocker labels,
#37257
#37252
#37273
#37156
#37325

@kavimuru
Copy link

@chiragsalian Sure we will retest and remove the blocker labels.

@chiragsalian chiragsalian mentioned this issue Feb 27, 2024
Closed
6 tasks
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 27, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@kavimuru
Copy link

kavimuru commented Feb 27, 2024 •
edited
Loading

Regression is left with 5 steps. We are still validating the PRs.

Unchecked PRs:
#35065 failing with #37252 in android
#36773 failing with #37229
#37009 failing with #37247
@puneetlath
QA team does not have physical card to validate this PR #34716 (comment) - It would be great if you could verify this internally.

I think the following PRs does not require QA. Could you confirm?
#36321 (comment)
#36323 (comment)
#36466 (comment)

@puneetlath
Copy link
Contributor

I think the following PRs does not require QA. Could you confirm?

Confirmed.

@kavimuru
Copy link

@chiragsalian

QA team, we CP-d this PR #37305. Since its a revert there is nothing to to test directly with that PR.
Instead can you retest its linked issues, they are all deploy blockers and if the issue is resolved please clear the deploy blocker labels,
#37257
#37252
#37273
#37156
#37325

All the bugs are not repro anymore. Removing deployblocker label.

@kavimuru
Copy link

kavimuru commented Feb 28, 2024 •
edited
Loading

Regression TR completed. We have few PR and CPs are yet to be validated.

#35065 failing with #37252 in android
#35451 is failing with known bug #32699.checking it off. Please see comment #35451 (comment)
#36773 failing with #37229
#36759 and #37009 failing with # 37247
#35319 failing with known bug #27866 in mweb. checking it off. see comment #35319 (comment)
#36345 failing with #37363

@Julesssss
Copy link
Contributor

Checking off #37403 as it isn't a blocker.

@kavimuru
Copy link

kavimuru commented Feb 28, 2024 •
edited
Loading

#35065 failing with #37252 in android
#36773 failing with #37229
#36759 and #37009 failing with # 37247
#36345 failing with #37363
#36993 failing with #37338
#35449 failing with #37405 repro in PROD checking it off
#36784 failing with #37414
#36848 failing with #37434 repro in PROD checking it off

@puneetlath
Copy link
Contributor

Checking off #36345. It'll be fixed as a follow-up not blocking the deploy.

@puneetlath
Copy link
Contributor

Checking off #37408 since it's likely a back-end thing.

@puneetlath
Copy link
Contributor

Marking #37417 as not a blocker.

@puneetlath
Copy link
Contributor

Decided #37271 is not a blocker here.

@puneetlath
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@puneetlath puneetlath

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests