[HOLD for payment 2024-03-07] [$500] Room - User is navigated to Concierge report when creating room

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.44-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Create a workspace if you don't have any
2. Click on 'FAB' > Start chat > Room tab
3. Enter room name and click on 'Create room' button

Expected Result:

User should be navigated to the newly created room

Actual Result:

User is navigated to Concierge report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393358_1708984329114.Screen_Recording_2024-02-27_at_12.26.11_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0146027f79fc978115
• Upwork Job ID: 1762246166149222400
• Last Price Increase: 2024-02-26

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0146027f79fc978115

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb
|CC @quinthar

[melvin-bot]

Triggered auto assignment to @blimpich (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[blimpich]

Looking into this

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Room - User is navigated to Concierge report when creating room

What is the root cause of that problem?

• We navigate user to concierge in this line because of the condition is true.
• It is because after creating room, we navigate to report and we call the openReport API which is redundant (this does not appear in prod). When calling openReport, we set the optimistic report to something like {reportName: ChatReport}
• But why openReport is called again? It is because we render the report screen when the report data is not fetched successfully

What changes do you think we should make in order to solve the problem?

• In here, we can remove allowStaleData. So it can make sure the report data is fetched before rendering the report screen

Alternative solution

• Also, we just need to remove !report.statusNum && !prevReport.parentReportID && prevReport.chatType === CONST.REPORT.CHAT_TYPE.POLICY_ROOM

[blimpich]

@dukenv0307 This is a regression though, right? What PR caused this?

[blimpich]

My guess is something happened such that the props getting passed down into ReportScreen are wonky now, though I'm having a hard time finding which PR caused this.

[blimpich]

posted in #expensify-open-source about this issue

[dukenv0307]

@blimpich based on my proposal, we render the report screen when the report data is not fetched successfully, that leads to the bug. What do you think about it? Also, it is very difficult to find the PR that caused the regression on my side

[blimpich]

@dukenv0307 This is a regression though, right? What PR caused this?

This again. Something broke the app, and in order to accept your proposal I would want to know why this started happening in the first place. This isn't happening in production so this is a recent bug.

[s77rt]

Timeline after we press the create room button

1. Policy.addPolicyReport is called and it sets the optimistic report
2. Report.openReport is called and it overrides the optimistic report <- This should not happen

The because chain:

• Report.openReport is called in ReportScreen fetchReportIfNeeded because isLoadingInitialReportActions is true.
• isLoadingInitialReportActions is true because reportActions are empty.
• reportActions are empty because withOnyx subscription returns undefined
• withOnyx subscription returns undefined due to a recent change Use initialValue when cached value is undefined react-native-onyx#470 I'm not sure why exactly but it seems to contradicts with the selector

Offending PRs:

• Fix blank screen is shown when opening a report screen after relaunching app #36996
• Use initialValue when cached value is undefined react-native-onyx#470

[bernhardoj]

@s77rt is on point. This has the same root cause as this issue

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[bernhardoj]

The PR is here #37269

[blimpich]

Reverted the react Onyx change by first reverting the react-onyx package and then upgrading the App's package to the latest version. Thank you @s77rt for the explanation!

And I'm sorry @bernhardoj the timing didn't work out with your fix. Its morning over here and by the time I started work we really wanted to get the deploy out, so it makes sense to do this revert given the time / risk involved. It always sucks when making seemingly straightforward changes has these unforeseeable cascading effects.

Closing as #37323 fixes this.

[luacmartins]

Seems like this was also the root cause for #37300

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix blocker where we incorrectly navigate to concierge chat when creating a new room #37323

If no regressions arise, payment will be issued on 2024-03-07. 🎊

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment (Needs manual offer from BZ)