Web - IOU - There is a delay in sending money

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.44.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #29991

Action Performed:

1. Log in with a Gmail account
2. Click on the FAB - Send money
3. Enter any amount
4. Select a gmail address that never logged in

Expected Result:

There shouldn't be any delays

Actual Result:

There is a delay in sending money

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393963_1709036640715.bandicam_2024-02-27_08-21-50-704.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @lakchote (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-split-p2p-chat-groups
CC @arielgreen

[lakchote]

Not a blocker or related to NewDot performance.

Instead it's an API slowdown, see the SendMoneyElseWhere api response in the video below.

api.mov

Closing the issue for these reasons.

Will ask in #fast-apis if something has been noticed for it recently.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[luacmartins]

Sorry @lakchote I spoke too soon. In prod, the API also takes 6s but the page loads immediately because of the optimistic data, so this seems like a regression in App.

[lakchote]

Sorry @lakchote I spoke too soon. In prod, the API also takes 6s but the page loads immediately because of the optimistic data, so this seems like a regression in App.

Oh, my bad. Well let's take a deeper look at this!

[lakchote]

I've looked at all the PRs that got merged, and I don't see any that could have had an effect on Onyx optimistic data for send money.

Last changes on IOU.ts's sendMoneyElsewhere() and sendMoneyWithWallet() function were 4 weeks ago

It seems like optimistic data is correctly set judging by my screen below (on dev):

It's very hard to reproduce on dev since I don't have the latency problems I would have on staging.

As such, I can't see the optimistic data (or lack thereof) problem come into play.

[luacmartins]

Just noting that this happens for other flows too, e.g. Start chat and Request money

[lakchote]

The issue was elsewhere.

Now it's fast on staging, since the revert PR was deployed.

[aimane-chnaif]

@bernhardoj please consider this case as well when re-work on Onyx

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[bernhardoj]

@aimane-chnaif the Onyx PR doesn't introduce the delay, maybe it was a site issue (or other things in the App). The report screen shows a skeleton loader instead of a blank screen after the Onyx PR. Same case like this one

EDIT: okay, the delay has the same root cause as #37247 because the optimistic report is overwritten. This is an App problem, not with the onyx.

[aimane-chnaif]

@aimane-chnaif the Onyx PR doesn't introduce the delay, maybe it was a site issue (or other things in the App). The report screen shows a skeleton loader instead of a blank screen after the Onyx PR. Same case like this one

EDIT: okay, the delay has the same root cause as #37247 because the optimistic report is overwritten. This is an App problem, not with the onyx.

yes, I meant to test app thoroughly and fix app issues along with Onyx version bump.

[luacmartins]

I think we can close this issue, since we CPed a fix and it was tested in staging.