fix: broken search screen on Android #37155

kirillzyusko · 2024-02-23T17:43:15Z

Details

Fixed infinite loading screen on Android.

The main problem is in the fact that transitionEnd event is not fired (but we receive it on iOS). I quickly checked Android code and found that dispatchViewAnimationEvent is not getting called (and as a result dispatchLifecycleEvent is also not called).

I don't know exactly why this navigation doesn't trigger transitionEnd on Android, but as a workaround we use JS stack for this screen.

Fixed Issues

$ #37156
PROPOSAL:

Tests

Click on the Search input
Be sure the loading is not infinite
Try to search for a contact
Contact list should be updated and reflect a real list that satisfies to criteria search

Verify that no errors appear in the JS console

Offline tests

QA Steps

Click on the Search input
Be sure the loading is not infinite
Try to search for a contact
Contact list should be updated and reflect a real list that satisfies to criteria search

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

telegram-cloud-document-2-5388686859729649290.mp4

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-23.at.18.28.55.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-02-23.at.18.36.57.mov

MacOS: Desktop

Screen.Recording.2024-02-23.at.18.40.54.mov

melvin-bot · 2024-02-23T17:43:46Z

@rlinoz Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-02-26T18:00:47Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/37155/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/37155/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/37155/NewExpensify.dmg	https://37155.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

situchan · 2024-02-26T18:08:27Z

Tests well except blank list showing for a brief moment

Screen.Recording.2024-02-27.at.12.05.05.AM.mov

rlinoz · 2024-02-26T18:26:18Z

I am little confused, this PR is working, but the staging app is also working for me.

Is there any other steps to reproduce the problem in staging? Or maybe it depends on the device?

situchan · 2024-02-26T18:27:40Z

This is reproducible on main. Seems like offending PR didn't hit staging yet

kirillzyusko · 2024-02-26T18:29:04Z

Is there any other steps to reproduce the problem in staging? Or maybe it depends on the device?

From my observation it happens only on Android and only if you do a clean installation - can you try to make a clean installation?

This is reproducible on main. Seems like offending PR didn't hit staging yet

@situchan staging == latest github release? Or how we can detect if a particular PR was deployed to staging?

rlinoz · 2024-02-26T18:30:12Z

Got it, let me try main and a clean install

situchan · 2024-02-26T18:30:31Z

#29991 is the offending PR

situchan · 2024-02-26T18:32:10Z

@situchan staging == latest github release? Or how we can detect if a particular PR was deployed to staging?

Normally #30829 (comment)
If it doesn't happen, deploy checklist mentions that PR like #30829 (reference)

rlinoz · 2024-02-26T19:14:31Z

src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

+const createModalStackNavigator = createModalStackNavigatorFactory(createPlatformStackNavigator);
+const createJSModalStackNavigator = createModalStackNavigatorFactory(createStackNavigator);


Can we just add a comment saying which one is preferred to use and why we have the JS one?

@rlinoz actually the PR with native-stack produces many problems, so the best solution would be to revert this PR and I'll re-open a new one later where I'll fix all the issues

rlinoz · 2024-02-26T19:14:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-26.at.16.23.23.mov

Android: mWeb Chrome

WhatsApp.Video.2024-02-26.at.16.36.28.mp4

iOS: Native

Screen.Recording.2024-02-26.at.16.24.53.mov

iOS: mWeb Safari

Screen.Recording.2024-02-26.at.16.34.52.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-26.at.16.25.39.mov

MacOS: Desktop

Uploading Screen Recording 2024-02-26 at 16.28.39.mov…

rlinoz · 2024-02-26T19:40:15Z

Im gonna merge this as this is important, but it would be nice to have the comments here

OSBotify · 2024-02-26T19:45:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-26T21:11:59Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-29T00:00:35Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: broken search screen on Android

cee09d2

kirillzyusko requested a review from a team as a code owner February 23, 2024 17:43

melvin-bot bot requested review from rlinoz and removed request for a team February 23, 2024 17:43

fix: prettier

b6f71a1

rlinoz added the Ready To Build label Feb 26, 2024

rlinoz reviewed Feb 26, 2024

View reviewed changes

rlinoz approved these changes Feb 26, 2024

View reviewed changes

rlinoz merged commit 407679d into Expensify:main Feb 26, 2024
16 checks passed

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

hannojg mentioned this pull request Feb 27, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #37070

Closed

situchan mentioned this pull request Feb 27, 2024

revert: native stack #37305

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: broken search screen on Android #37155

fix: broken search screen on Android #37155

kirillzyusko commented Feb 23, 2024 •

edited

Loading

melvin-bot bot commented Feb 23, 2024

github-actions bot commented Feb 26, 2024

situchan commented Feb 26, 2024

rlinoz commented Feb 26, 2024 •

edited

Loading

situchan commented Feb 26, 2024

kirillzyusko commented Feb 26, 2024 •

edited

Loading

rlinoz commented Feb 26, 2024

situchan commented Feb 26, 2024

situchan commented Feb 26, 2024

rlinoz Feb 26, 2024

kirillzyusko Feb 27, 2024

rlinoz commented Feb 26, 2024 •

edited

Loading

rlinoz commented Feb 26, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 29, 2024

		const createModalStackNavigator = createModalStackNavigatorFactory(createPlatformStackNavigator);
		const createJSModalStackNavigator = createModalStackNavigatorFactory(createStackNavigator);

fix: broken search screen on Android #37155

fix: broken search screen on Android #37155

Conversation

kirillzyusko commented Feb 23, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 23, 2024

github-actions bot commented Feb 26, 2024

situchan commented Feb 26, 2024

rlinoz commented Feb 26, 2024 • edited Loading

situchan commented Feb 26, 2024

kirillzyusko commented Feb 26, 2024 • edited Loading

rlinoz commented Feb 26, 2024

situchan commented Feb 26, 2024

situchan commented Feb 26, 2024

rlinoz Feb 26, 2024

Choose a reason for hiding this comment

kirillzyusko Feb 27, 2024

Choose a reason for hiding this comment

rlinoz commented Feb 26, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

rlinoz commented Feb 26, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 29, 2024

kirillzyusko commented Feb 23, 2024 •

edited

Loading

rlinoz commented Feb 26, 2024 •

edited

Loading

kirillzyusko commented Feb 26, 2024 •

edited

Loading

rlinoz commented Feb 26, 2024 •

edited

Loading