Fix/35368: Composer is not shrinked #35865

dukenv0307 · 2024-02-06T02:04:47Z

Details

Compose box does not shrinks when content is deleted if it was previously expanded

Fixed Issues

$ #35368
PROPOSAL: #35368 (comment)

Tests

Go to any chat.
Enter a lot of lines in the compose box until a scroll bar is displayed on the right side.
Click on "Expand" button.
Delete all the content in compose box.
Vefiry that the compose box should automatically shrink if it has no content.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to any chat.
Enter a lot of lines in the compose box until a scroll bar is displayed on the right side.
Click on "Expand" button.
Delete all the content in compose box.
Vefiry that the compose box should automatically shrink if it has no content.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screencast.from.07-02-2024.18.28.21.webm

Android: mWeb Chrome

Screencast.from.06-02-2024.09.03.46.webm

iOS: Native

Screencast.from.06-02-2024.10.53.49.webm

iOS: mWeb Safari

Screencast.from.06-02-2024.09.02.34.webm

MacOS: Chrome / Safari

Screencast.from.06-02-2024.08.59.55.webm

MacOS: Desktop

Screencast.from.06-02-2024.09.21.04.webm

melvin-bot · 2024-02-06T02:04:52Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2024-02-06T04:06:52Z

I encountered an error in my Android native device so cannot test on it. Please help test @thesahindia and I will update the screenshot when my device is fixed

thesahindia · 2024-02-07T18:09:08Z

src/libs/ComposerUtils/updateNumberOfLines/index.native.ts

@@ -14,6 +15,9 @@ const updateNumberOfLines: UpdateNumberOfLines = (props, event, styles) => {
        return;
    }
    const numberOfLines = getNumberOfLines(lineHeight, paddingTopAndBottom, inputHeight);
+    if (numberOfLines === 1) {


Why did we remove ReportUtils.getCommentLength(value ?? '') === 0?

thesahindia · 2024-02-07T18:09:45Z

src/libs/ComposerUtils/updateNumberOfLines/index.native.ts

@@ -1,5 +1,6 @@
 import getNumberOfLines from '@libs/ComposerUtils/getNumberOfLines';
 import updateIsFullComposerAvailable from '@libs/ComposerUtils/updateIsFullComposerAvailable';
+import * as ReportUtils from '@libs/ReportUtils';


You forgot to remove this.

thesahindia · 2024-02-09T20:20:21Z

Bump @dukenv0307

dukenv0307 · 2024-02-12T02:17:32Z

@thesahindia I`ll work on it today

dukenv0307 · 2024-02-15T02:42:34Z

@MariaHCD @thesahindia I need to confirm that we only shrink the composer if the content is empty or the line height is equal to 1?

MariaHCD · 2024-02-16T09:35:43Z

we only shrink the composer if the content is empty or the line height is equal to 1?

How would the UX differ for these two approaches?

dukenv0307 · 2024-02-16T09:42:01Z

How would the UX differ for these two approaches?

We only shrink the composer if the content is empty

Screencast.from.16-02-2024.16.38.24.webm

We only shrink the composer if the line height is equal to 1

Screencast.from.16-02-2024.16.41.28.webm

thesahindia · 2024-02-16T17:41:34Z

We only shrink the composer if the content is empty

I prefer this option.

dukenv0307 · 2024-02-19T07:53:06Z

@MariaHCD Do you agree with this comment?

MariaHCD · 2024-02-19T08:59:40Z

I agree with option 1 as well 👍🏼

dukenv0307 · 2024-02-19T17:39:43Z

@thesahindia I just updated PR to match the option 1

src/pages/home/report/ReportActionCompose/ReportActionCompose.js

dukenv0307 · 2024-02-21T14:13:12Z

@thesahindia I resolved all your comments

thesahindia · 2024-02-21T19:58:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-22.at.12.50.15.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-02-22.at.12.49.02.AM.mov

iOS: Native

Screen.Recording.2024-02-22.at.12.55.08.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-02-22.at.12.56.48.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-22.at.12.46.41.AM.mov

MacOS: Desktop

Screen.Recording.2024-02-22.at.12.58.28.AM.mov

thesahindia

LGTM!

OSBotify · 2024-02-22T06:50:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-26T21:05:59Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:54:35Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix composer is not shrinked

dc6ce8a

dukenv0307 requested a review from a team as a code owner February 6, 2024 02:04

melvin-bot bot requested review from thesahindia and removed request for a team February 6, 2024 02:04

dukenv0307 added 2 commits February 6, 2024 10:44

fix native device

3d76e1c

fix lint issue

dd02378

dukenv0307 mentioned this pull request Feb 6, 2024

[$500] Compose box does not shrinks when content is deleted if it was previously expanded #35368

Closed

6 tasks

fix native

43733bf

thesahindia reviewed Feb 7, 2024

View reviewed changes

fix merge main

f7fcfc7

dukenv0307 added 2 commits February 19, 2024 16:57

fix shrink composer once value is cleared

59302b6

fix remove redundant code

8f6d597

fix merge main

dcfa6d9

thesahindia reviewed Feb 20, 2024

View reviewed changes

src/pages/home/report/ReportActionCompose/ReportActionCompose.js Outdated Show resolved Hide resolved

thesahindia suggested changes Feb 20, 2024

View reviewed changes

src/pages/home/report/ReportActionCompose/ReportActionCompose.js Outdated Show resolved Hide resolved

fix only shrink if the composer is expanding

cbc6cf6

thesahindia approved these changes Feb 21, 2024

View reviewed changes

melvin-bot bot requested a review from MariaHCD February 21, 2024 19:59

MariaHCD approved these changes Feb 22, 2024

View reviewed changes

MariaHCD merged commit d33bf6e into Expensify:main Feb 22, 2024
16 checks passed

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/35368: Composer is not shrinked #35865

Fix/35368: Composer is not shrinked #35865

dukenv0307 commented Feb 6, 2024 •

edited

Loading

melvin-bot bot commented Feb 6, 2024

dukenv0307 commented Feb 6, 2024

thesahindia Feb 7, 2024

thesahindia Feb 7, 2024

thesahindia commented Feb 9, 2024

dukenv0307 commented Feb 12, 2024

dukenv0307 commented Feb 15, 2024

MariaHCD commented Feb 16, 2024

dukenv0307 commented Feb 16, 2024

thesahindia commented Feb 16, 2024

dukenv0307 commented Feb 19, 2024

MariaHCD commented Feb 19, 2024

dukenv0307 commented Feb 19, 2024 •

edited

Loading

dukenv0307 commented Feb 21, 2024

thesahindia commented Feb 21, 2024

thesahindia left a comment

OSBotify commented Feb 22, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

Fix/35368: Composer is not shrinked #35865

Fix/35368: Composer is not shrinked #35865

Conversation

dukenv0307 commented Feb 6, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 6, 2024

dukenv0307 commented Feb 6, 2024

thesahindia Feb 7, 2024

Choose a reason for hiding this comment

thesahindia Feb 7, 2024

Choose a reason for hiding this comment

thesahindia commented Feb 9, 2024

dukenv0307 commented Feb 12, 2024

dukenv0307 commented Feb 15, 2024

MariaHCD commented Feb 16, 2024

dukenv0307 commented Feb 16, 2024

thesahindia commented Feb 16, 2024

dukenv0307 commented Feb 19, 2024

MariaHCD commented Feb 19, 2024

dukenv0307 commented Feb 19, 2024 • edited Loading

dukenv0307 commented Feb 21, 2024

thesahindia commented Feb 21, 2024

Reviewer Checklist

Screenshots/Videos

thesahindia left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 22, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

dukenv0307 commented Feb 6, 2024 •

edited

Loading

dukenv0307 commented Feb 19, 2024 •

edited

Loading