-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/35368: Composer is not shrinked #35865
Merged
MariaHCD
merged 9 commits into
Expensify:main
from
dukenv0307:fix/35368-compose-box-does-not-shrink-when-content-is-deleted
Feb 22, 2024
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
dc6ce8a
fix composer is not shrinked
dukenv0307 3d76e1c
fix native device
dukenv0307 dd02378
fix lint issue
dukenv0307 43733bf
fix native
dukenv0307 f7fcfc7
fix merge main
dukenv0307 59302b6
fix shrink composer once value is cleared
dukenv0307 8f6d597
fix remove redundant code
dukenv0307 dcfa6d9
fix merge main
dukenv0307 cbc6cf6
fix only shrink if the composer is expanding
dukenv0307 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
import getNumberOfLines from '@libs/ComposerUtils/getNumberOfLines'; | ||
import updateIsFullComposerAvailable from '@libs/ComposerUtils/updateIsFullComposerAvailable'; | ||
import * as ReportUtils from '@libs/ReportUtils'; | ||
import type UpdateNumberOfLines from './types'; | ||
|
||
/** | ||
|
@@ -14,6 +15,9 @@ | |
return; | ||
} | ||
const numberOfLines = getNumberOfLines(lineHeight, paddingTopAndBottom, inputHeight); | ||
if (numberOfLines === 1) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did we remove |
||
props.resetFullComposerSize?.(); | ||
} | ||
updateIsFullComposerAvailable(props, numberOfLines); | ||
}; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to remove this.