Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] IOU - Total paid amount instead of individual amount is copied from each paid IOU preview #36924

Closed
6 tasks done
lanitochka17 opened this issue Feb 20, 2024 · 18 comments
Closed
6 tasks done
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.43-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. User A creates a few money requests with different amount with User B
  3. User B pays the requests
  4. User A goes to IOU report
  5. Right click on any preview > Copy to clipboard
  6. Paste the content
  7. Repeat Step 5 and 6 with other preview

Expected Result:

When copying each paid request to clipboard, the amount for each individual request will be copied

Actual Result:

When copying each individual paid request to clipboard, the total paid amount is copied instead of each individual amount

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385852_1708444720671.20240220_214620.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01563f6a9a33c0c231
  • Upwork Job ID: 1759985620065345536
  • Last Price Increase: 2024-02-27
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor labels Feb 20, 2024
@melvin-bot melvin-bot bot changed the title IOU - Total paid amount instead of individual amount is copied from each paid IOU preview [$500] IOU - Total paid amount instead of individual amount is copied from each paid IOU preview Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01563f6a9a33c0c231

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 20, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 20, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@flodnv
Copy link
Contributor

flodnv commented Feb 20, 2024

Maybe related: #36917 (comment)

Copy link

melvin-bot bot commented Feb 20, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@shahinyan11
Copy link

My proposal here will fix this issue too

@deetergp
Copy link
Contributor

deetergp commented Feb 21, 2024

I checked out main (after the revert for #36917 (comment) was merged) and went through the testing steps listed in this issue and things seem to be working as expected now.

@lanitochka17 could we get a re-test on this one once #36932 has been deployed to staging?

2024-02-21_12-23-54.mp4

@kavimuru
Copy link

@deetergp Our QA team will check on this one.

@deetergp
Copy link
Contributor

Thank you @kavimuru 👍

@melvin-bot melvin-bot bot added the Overdue label Feb 26, 2024
@deetergp
Copy link
Contributor

Any word on the retests @kavimuru?

@melvin-bot melvin-bot bot removed the Overdue label Feb 26, 2024
@kavimuru
Copy link

@deetergp Sorry this got missed. I am following up on this one.

@kavimuru
Copy link

@deetergp Not reproducible in web and android. Waiting for other platform results.

screen-20240226-154654.mp4
Recording.235.mp4

Copy link

melvin-bot bot commented Feb 27, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@deetergp
Copy link
Contributor

@kavimuru Any word back on the other platforms?

@kavimuru
Copy link

@deetergp Not reproducible in other platforms too.

@deetergp
Copy link
Contributor

Thanks @kavimuru 👍 Closing this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants