[HOLD for payment 2024-04-05] [$500] Workflows-If the first 2 options are enabled,cannot scroll to see the 3th option

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

**Found when validating PR :**#36345

Version Number: v1.4.44-7
Reproducible in staging?: Y
Reproducible in production?: No, new feature
Email or phone of affected tester (no customers): applausetester+ihchat4_2902_e@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal team

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Log in to account with the Collect policy (Admin or employee)
3. Navigate to Settings > Workspaces. You should see your Collect workspace, click on it
4. Click on Workflows
5. Toggle the first 2 options ( Delay submissions and Add approvals)
6. Try to scroll to the bottom

Expected Result:

The page can be scrolled to see all options

Actual Result:

Cannot scroll to see the 3th option (Make or track payments)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6394796_1709073504428.Record_2024-02-27-23-32-52.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0111411a72b5209608
• Upwork Job ID: 1762791634831163392
• Last Price Increase: 2024-03-06

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0111411a72b5209608

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #wave7-collect-approvers
CC @RachCHopkins

[ishpaul777]

@lakchote Can you raise a PR with fix this comes from #36345

[mkhutornyi]

@ishpaul777 you mean that is the offending PR? #37213 is not merged yet

[mkhutornyi]

this one - #36345

[ishpaul777]

ah, i meant this one #36345,

[ishpaul777]

actully the page is incomplete and not fully functional for now anyways so i'll try to include a fix for this in a upcoming PR for #37197 not need to block deploy wdyt @lakchote @Julesssss ?

[mkhutornyi]

Page is incomplete but will be visible to users after deploy to production, right?

[ishpaul777]

feature is not fully usable but page will be visible

[ishpaul777]

Though the fix is simple, we need to pass shouldUseScrollView

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Lines 132 to 139 in bee752a

	<WorkspacePageWithSections
	headerText={translate('workspace.common.workflows')}
	icon={Illustrations.Workflows}
	route={route}
	guidesCallTaskID={CONST.GUIDES_CALL_TASK_IDS.WORKSPACE_WORKFLOWS}
	shouldShowOfflineIndicatorInWideScreen
	shouldShowNotFoundPage={!isPaidGroupPolicy || !isPolicyAdmin}
	>

and we dont need to use a flatlist here becuse we dont use it any page with similar layout for example: WorkspaceReimburseView

                       {
                            // map the items to the renderItem function
                            items.map((item, index) => (
                                renderItem(item, index)
                            ))
                        }

[Julesssss]

I'm struggling to reproduce as I can't see my collection policy. I'm reasonably sure this feature is locked behind a beta flag (QA and contributors have all betas enabled by default).

This also is a minor issue for a new feature, so it doesn't need to block the release 👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fixes-37403 Workflows-If the first 2 options are enabled,cannot scroll to see the 3th option #38248

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @mkhutornyi requires payment (Needs manual offer from BZ)
• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @mkhutornyi paid $(AMOUNT) via Upwork (LINK)
• ROLE: @ishpaul777 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@JmillsExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1762791634831163392/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[ishpaul777]

[@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: #36345
[@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/36345/files#r1555100609
[@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: not required
[@ishpaul777] Determine if we should create a regression test for this bug. - yes
[@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test proposal

1. Log in to account with the Collect policy.
2. Navigate to Collect settings and enable workflows in "More features".
3. Click on Workflows
4. Toggle all of the 3 options.
5. Try to scroll to the bottom, verify it works as expected.

Do we agree 👍 or 👎

[Julesssss]

I'm not sure that such a specific page scrolling test is valuable here

[Julesssss]

Ready for payment, I'll be OOO so can't respond

[JmillsExpensify]

Payment summary:

• Contributor: @ishpaul777 $500
• Contributor+: @mkhutornyi $500

[ishpaul777]

@JmillsExpensify Not sure if this matter but the roles were C+ @mkhutornyi, and i was the contributor 😄

[JmillsExpensify]

Ah thank you! I'll update for clarity and send over the manual Upwork offers within the hour.

[JmillsExpensify]

Contributor contract paid out, waiting on C+ to accept and then we can close this out.

[luacmartins]

pending payment

[luacmartins]

Just pending payment

[JmillsExpensify]

Let's close the issue. Still waiting for the offer to be accepted in Upwork.

[mkhutornyi]

@JmillsExpensify sorry for late. I am back from OOO. Can you please send new offer? Old one was expired.

[mallenexpensify]

@mkhutornyi , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01f9e66b4545a1cb70

[mkhutornyi]

Accepted thanks

[JmillsExpensify]

All paid out! Closing again.