[HOLD for payment 2024-03-20] [Wave8] [Simplified Collect] [Workflows] Create Payment page

[lakchote]

We've recently merged the main workflows page.

The task here is to create the Payment page present under the main worfklows page.

It will appear when we click on the > icon under the Connect bank account menu item:

Expected mockups below

No VBBA flow

VBBA flow

Technical details can be found here.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[lakchote]

Assigning to Tom since he's leading the wave's progress for simplified collect workflows.

[ishpaul777]

I can volunteer as C+ as i have previously reviewed the related PR and already has access to design doc :D

[luacmartins]

@ishpaul777 would you be able to work on the implementation for this issue since you have access to the design doc?

[ishpaul777]

would you be able to work on the implementation for this issue since you have access to the design doc

Sure 😃 i'd love to work on it

[lakchote]

would you be able to work on the implementation for this issue since you have access to the design doc

Sure 😃 i'd love to work on it

Perfect! Thank you. Assigning it to you

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[ishpaul777]

false alarm ⬆️

[ishpaul777]

hii @luacmartins @lakchote, started working on this now, quick question do we have any onyx key to get the added bank account information, ONYXKEYS.REIMBURSEMENT_ACCOUNT only has the information achData.state

[luacmartins]

@ishpaul777 the reimbursementAccount key should have these details, I think we can use that to build the bank account name as shown in the image

[ishpaul777]

it has only state

[luacmartins]

This is the object I see when I have a bank account added. Maybe your account doesn't have a bank account properly set up:

[ishpaul777]

I use these steps, i have added a secondary email in olddot also but i still see these detail in as reimbursementAccountDraft

[ishpaul777]

@luacmartins i get this details #37197 (comment), when sign out and re sign in is this known/expected 🤔

[ishpaul777]

from docs https://docs.google.com/document/d/1T--VcAaCm-8aq5oEO78_vVXxBpXY1gq7NiJrboGZNcs/edit#bookmark=id.bv81jb9oqisz

Using withOnyx(), we’ll check for plaidData Onyx key details. When it’s not empty and it has a bankAccount, meaning the VBBA connection went on successfully, we’ll call the SetWorkspaceReimbursement command.

but actually we check this using achData.state in other places in codebase

@luacmartins i am little confused if reimbursementAccount is already setup then where do we redirect when clicking here?

also do we have the api for SetWorkspaceReimbursement and SetWorkspacePayer ready ?

[luacmartins]

we’ll check for plaidData Onyx key details
this seems wrong since that key is temporary only when we're in the process of connecting with Plaid.

That should navigate to ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN, which would show the EnableBankAccount page

[luacmartins]

@ishpaul777 how's it going with this issue? Do you have a branch or draft PR up yet?

[ishpaul777]

@ishpaul777 how's it going with this issue? Do you have a branch or draft PR up yet?

priortizing working on it will raise a pr today

[luacmartins]

Update:

• Alias PR is merged. You can keep using Policy_setReimbursementFromChoice for testing for now until the new command SetReimbursementFromChoice is deployed.
• For the reimburser email from VBBA, we should be using the new reimbursementAccount<policyID> key, with the policyID appended to it. It seems like we don't load this information when opening the Workflows page, so we need a command to do that @lakchote.

[luacmartins]

@ishpaul777 we'll have to create an OpenPolicyWorkflowsPage API command that should be called when the user opens the Workflows page to load this data. I wouldn't block your PR on it though

[jjcoffee]

@trjExpensify Could you assign me here as I'll be reviewing the PR as C+? Thanks! 🙏

[luacmartins]

Done

[lakchote]

@ishpaul777 we'll have to create an OpenPolicyWorkflowsPage API command that should be called when the user opens the Workflows page to load this data. I wouldn't block your PR on it though

PR should be merged today

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: Workflow payer page #37629

If no regressions arise, payment will be issued on 2024-03-20. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment (Needs manual offer from BZ)
• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee / @ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @jjcoffee paid $(AMOUNT) via Upwork (LINK)
• ROLE: @ishpaul777 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@trjExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[trjExpensify]

Alright, alright...

• $500 to @jjcoffee for the C+ review
• $500 to @ishpaul777 for the fix

We'll take care of the regression tests for the simplified collect project. :)

Let me know if that's correct and I'll get these paid out.

[jjcoffee]

@trjExpensify LGTM!

[trjExpensify]

Perfect. Offers sent!

[jjcoffee]

@trjExpensify Accepted, thanks!

[trjExpensify]

@jjcoffee paid you.

[trjExpensify]

@ishpaul777 we're still waiting on you to accept the offer.

[ishpaul777]

Oh sorry i missed this @trjExpensify! I'll accept the offer in my morning, Thank you for ping

[trjExpensify]

Paid! :)