[HOLD for payment 2024-03-07] [$500] Category - Selected category does not appear as selected in split request Category list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.44-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Click + > Split bill > Scan
4. Upload a receipt
5. Proceed to confirmation page
6. Click Category and select a category
7. Click Split button
8. Click on the split preview
9. Click Category

Expected Result:

The selected category will appear as selected in split request Category list

Actual Result:

The selected category does not appear as selected in split request Category list
This issue is only reproducible with Split Scan request and not with manual request

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6394567_1709063388553.20240228_002058.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0189e694798cc802db
• Upwork Job ID: 1762570237814657024
• Last Price Increase: 2024-02-27

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0189e694798cc802db

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be relpated to #vip-split-p2p-chat-groups
CC @arielgreen

[nexarvo]

Proposal


### Please re-state the problem that we are trying to solve in this issue.



Selected category does not appear as selected in split request Category list

What is the root cause of that problem?

We are passing transaction to getTransactionDetails based on editing condition and category is showing as "". but if we we first check that whether splitDraftTransaction is not empty. If it is empty then we will pass original transaction not splitDraftTransaction:

App/src/pages/iou/request/step/IOURequestStepCategory.js

Line 75 in edf7e32

const {category: transactionCategory} = ReportUtils.getTransactionDetails(isEditingSplitBill ? splitDraftTransaction : transaction);

Actually for the first time we open the category selector the splitDraftTransaction is empty and that's why it is not showing the selected category.

What changes do you think we should make in order to solve the problem?

We will check if splitDraftTransaction is not empty. The solution will look like this:
const {category: transactionCategory} = ReportUtils.getTransactionDetails(isEditingSplitBill && Object.keys(splitDraftTransaction).length > 0 ? splitDraftTransaction : transaction);

What alternative solutions did you explore? (Optional)

Result

[brandonhenry]

this one is a regression from i think #35458 @dukenv0307 @DylanDylann

changing this line back to what it was before transaction.category makes this work. The issue is that selected category is not being updated properly for scan request.

[dukenv0307]

@DylanDylann The PR to fix regression is ready for review.

[puneetlath]

CP'ing the fix.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Get correct default category for split scan request #37392

If no regressions arise, payment will be issued on 2024-03-07. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment (Needs manual offer from BZ)

[abdulrahuman5196]

@puneetlath We don't need payment here since its a regression fix. We can close this issue.

[puneetlath]

Great, thanks y'all!