[TS migration] Migrate 'WorkspaceMembers' page to TypeScript #35065

JKobrynski · 2024-01-24T15:46:17Z

Details

Fixed Issues

$ #25201
PROPOSAL: N/A

Tests

Log into the app
Make sure you are an admin of a workspace (if not, create one and add some members)
Go to Settings -> Workspaces -> (The workspace mentioned above) -> Members
Test that screen, make sure you can invite/remove members

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests section above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome

chrome.webm

iOS: Native

ios.mp4

iOS: mWeb Safari

safari.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

src/pages/workspace/WorkspaceMembersPage.tsx

src/libs/PolicyUtils.ts

src/pages/workspace/WorkspaceMembersPage.tsx

src/pages/workspace/withPolicy.tsx

src/pages/workspace/WorkspaceMembersPage.tsx

JKobrynski · 2024-01-29T07:55:07Z

@VickyStash @fabioh8010 can you take another look? 🙏

src/pages/workspace/withPolicy.tsx

melvin-bot · 2024-02-06T12:07:21Z

@hoangzinh @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2024-02-10T15:50:13Z

src/pages/workspace/WorkspaceMembersPage.tsx

-    useEffect(() => () => (SearchInputManager.searchInput = ''), []);
+    useEffect(() => {
+        SearchInputManager.searchInput = '';
+    }, []);


Previous logic wants clear searchInput on the unmount effect, we want to clear on the mount effect. Is it intentional?

Right, updated!

hoangzinh · 2024-02-10T15:54:24Z

src/pages/workspace/WorkspaceMembersPage.tsx

            });
        });

-        result = _.sortBy(result, (value) => value.text.toLowerCase());
+        result = result.sort((a, b) => a.text.localeCompare(b.text.toLowerCase()));


it looks like we forgot to convert a.text to lower case

hoangzinh · 2024-02-10T15:55:11Z

src/pages/workspace/WorkspaceMembersPage.tsx

-            return _.intersection(prevSelectedElements, _.values(PolicyUtils.getMemberAccountIDsForWorkspace(props.policyMembers, props.personalDetails)));
+            return [prevSelectedElements, Object.values(PolicyUtils.getMemberAccountIDsForWorkspace(policyMembers, personalDetails))].reduce((prev, members) =>
+                prev.filter((item) => members.includes(item)),
+            );


Previously, with _.intersection we could quickly understand what does this code mean, but now it's harder to understand. I think we can either:

Move to a util class (ArrayUtils?)

Or leave a comment to explain what we're going to do here.

What do you think?

Great idea! I added a comment

fabioh8010 · 2024-02-13T09:20:26Z

FYI @JKobrynski is OOO from Feb 12th to Feb 16th.

JKobrynski · 2024-02-20T12:34:34Z

@hoangzinh PR updated!

hoangzinh · 2024-02-21T12:34:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-21.at.22.03.14.android.mov

Android: mWeb Chrome

Screen.Recording.2024-02-21.at.22.08.56.android.chrome.mov

iOS: Native

Screen.Recording.2024-02-21.at.21.57.17.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-02-21.at.21.59.12.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-21.at.19.59.52.web.mov

MacOS: Desktop

Screen.Recording.2024-02-21.at.21.30.09.desktop.mov

hoangzinh · 2024-02-21T12:58:01Z

I found a bug that deletes a member when offline is disappearing instead of crossed out. It also happens in main so I reported here https://expensify.slack.com/archives/C049HHMV9SM/p1708519808525439

melvin-bot · 2024-02-21T15:16:52Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25201 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

hoangzinh · 2024-02-21T15:23:53Z

@tgolen I see that Melvin assigned you to issue #25201 but he didn't assign you to review this PR. Please help to review this PR when you have time. Thanks

tgolen · 2024-02-21T17:59:03Z

Can you fix the conflict please?

JKobrynski · 2024-02-22T13:23:54Z

@tgolen done!

OSBotify · 2024-02-22T14:11:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-26T21:05:05Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:53:41Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

JKobrynski added 5 commits January 24, 2024 08:32

start migrating WorkspaceMembersPage to TypeScript

c1ae7b2

remove compose from default export

ea748a8

add comment to onyx props

1a36412

Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript

a303aaa

migrate to typed SelectionList

fa28666

VickyStash reviewed Jan 25, 2024

View reviewed changes

apply suggested changes

b3253d3

JKobrynski requested review from VickyStash and rezkiy37 January 26, 2024 08:22

VickyStash reviewed Jan 26, 2024

View reviewed changes

src/pages/workspace/WorkspaceMembersPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/WorkspaceMembersPage.tsx Outdated Show resolved Hide resolved

src/libs/PolicyUtils.ts Outdated Show resolved Hide resolved

fabioh8010 reviewed Jan 26, 2024

View reviewed changes

JKobrynski added 4 commits January 26, 2024 11:11

improve route typing

f97df6e

Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript

b208e54

remove unnecessary @ts-expect-error

48ba430

improve return types, fix route type errors

9053a2d

JKobrynski requested review from fabioh8010 and VickyStash January 26, 2024 11:54

VickyStash reviewed Jan 26, 2024

View reviewed changes

src/pages/workspace/withPolicy.tsx Outdated Show resolved Hide resolved

src/pages/workspace/WorkspaceMembersPage.tsx Outdated Show resolved Hide resolved

apply suggested changes

4d49283

JKobrynski requested a review from VickyStash January 29, 2024 07:55

fabioh8010 reviewed Jan 29, 2024

View reviewed changes

src/pages/workspace/withPolicy.tsx Outdated Show resolved Hide resolved

improve PolicyRoute typing

3d03021

JKobrynski requested a review from fabioh8010 January 29, 2024 08:41

JKobrynski added 2 commits February 1, 2024 09:29

Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript

ae0cf58

Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript

4921a0d

blazejkustra approved these changes Feb 6, 2024

View reviewed changes

JKobrynski marked this pull request as ready for review February 6, 2024 12:07

JKobrynski requested a review from a team as a code owner February 6, 2024 12:07

melvin-bot bot removed the request for review from a team February 6, 2024 12:07

JKobrynski added 3 commits February 7, 2024 08:58

Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript

0c19686

Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript

3894ca8

Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript

bcdb574

hoangzinh reviewed Feb 11, 2024

View reviewed changes

JKobrynski added 2 commits February 20, 2024 13:09

Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript

8148064

add comment explaining intersection equivalent

8f2db96

JKobrynski requested a review from hoangzinh February 20, 2024 12:34

hoangzinh approved these changes Feb 21, 2024

View reviewed changes

melvin-bot bot requested a review from tgolen February 21, 2024 15:27

tgolen previously approved these changes Feb 21, 2024

View reviewed changes

JKobrynski added 2 commits February 22, 2024 12:42

Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript

d6bf0f7

fix onDismissError issue

b0eb670

JKobrynski dismissed tgolen’s stale review via b0eb670 February 22, 2024 13:23

JKobrynski requested a review from tgolen February 22, 2024 13:23

tgolen approved these changes Feb 22, 2024

View reviewed changes

tgolen merged commit fa55c40 into Expensify:main Feb 22, 2024
16 checks passed

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'WorkspaceMembers' page to TypeScript #35065

[TS migration] Migrate 'WorkspaceMembers' page to TypeScript #35065

JKobrynski commented Jan 24, 2024 •

edited

Loading

JKobrynski commented Jan 29, 2024

melvin-bot bot commented Feb 6, 2024

hoangzinh Feb 10, 2024

JKobrynski Feb 20, 2024

hoangzinh Feb 10, 2024

hoangzinh Feb 10, 2024

JKobrynski Feb 20, 2024

fabioh8010 commented Feb 13, 2024

JKobrynski commented Feb 20, 2024

hoangzinh commented Feb 21, 2024 •

edited

Loading

hoangzinh commented Feb 21, 2024

melvin-bot bot commented Feb 21, 2024

hoangzinh commented Feb 21, 2024

tgolen commented Feb 21, 2024

JKobrynski commented Feb 22, 2024

OSBotify commented Feb 22, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

[TS migration] Migrate 'WorkspaceMembers' page to TypeScript #35065

[TS migration] Migrate 'WorkspaceMembers' page to TypeScript #35065

Conversation

JKobrynski commented Jan 24, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

JKobrynski commented Jan 29, 2024

melvin-bot bot commented Feb 6, 2024

hoangzinh Feb 10, 2024

Choose a reason for hiding this comment

JKobrynski Feb 20, 2024

Choose a reason for hiding this comment

hoangzinh Feb 10, 2024

Choose a reason for hiding this comment

hoangzinh Feb 10, 2024

Choose a reason for hiding this comment

JKobrynski Feb 20, 2024

Choose a reason for hiding this comment

fabioh8010 commented Feb 13, 2024

JKobrynski commented Feb 20, 2024

hoangzinh commented Feb 21, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hoangzinh commented Feb 21, 2024

melvin-bot bot commented Feb 21, 2024

hoangzinh commented Feb 21, 2024

tgolen commented Feb 21, 2024

JKobrynski commented Feb 22, 2024

OSBotify commented Feb 22, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

JKobrynski commented Jan 24, 2024 •

edited

Loading

hoangzinh commented Feb 21, 2024 •

edited

Loading