Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'WorkspaceMembers' page to TypeScript #35065

Merged
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
c1ae7b2
start migrating WorkspaceMembersPage to TypeScript
JKobrynski Jan 24, 2024
ea748a8
remove compose from default export
JKobrynski Jan 24, 2024
1a36412
add comment to onyx props
JKobrynski Jan 25, 2024
a303aaa
Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript
JKobrynski Jan 25, 2024
fa28666
migrate to typed SelectionList
JKobrynski Jan 25, 2024
b3253d3
apply suggested changes
JKobrynski Jan 26, 2024
f97df6e
improve route typing
JKobrynski Jan 26, 2024
b208e54
Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript
JKobrynski Jan 26, 2024
48ba430
remove unnecessary @ts-expect-error
JKobrynski Jan 26, 2024
9053a2d
improve return types, fix route type errors
JKobrynski Jan 26, 2024
4d49283
apply suggested changes
JKobrynski Jan 29, 2024
3d03021
improve PolicyRoute typing
JKobrynski Jan 29, 2024
ae0cf58
Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript
JKobrynski Feb 1, 2024
4921a0d
Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript
JKobrynski Feb 2, 2024
0c19686
Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript
JKobrynski Feb 7, 2024
3894ca8
Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript
JKobrynski Feb 8, 2024
bcdb574
Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript
JKobrynski Feb 9, 2024
8148064
Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript
JKobrynski Feb 20, 2024
8f2db96
add comment explaining intersection equivalent
JKobrynski Feb 20, 2024
d6bf0f7
Merge branch 'main' into migrateWorkspaceMembersPageToTypeScript
JKobrynski Feb 22, 2024
b0eb670
fix onDismissError issue
JKobrynski Feb 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/SelectionList/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ type BaseSelectionListProps<TItem extends User | RadioItem> = Partial<ChildrenPr
onSelectAll?: () => void;

/** Callback to fire when an error is dismissed */
onDismissError?: () => void;
onDismissError?: (item: TItem) => void;

/** Label for the text input */
textInputLabel?: string;
Expand Down
2 changes: 1 addition & 1 deletion src/libs/PolicyUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function shouldShowPolicy(policy: OnyxEntry<Policy>, isOffline: boolean): boolea
);
}

function isExpensifyTeam(email: string): boolean {
function isExpensifyTeam(email: string | undefined): boolean {
const emailDomain = Str.extractEmailDomain(email ?? '');
return emailDomain === CONST.EXPENSIFY_PARTNER_NAME || emailDomain === CONST.EMAIL.GUIDES_DOMAIN;
}
Expand Down
Loading
Loading