[HOLD for payment 2024-03-11] [$500] Workspace - The selection is smaller than member name row when navigating via keyboard

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.44-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Workspace settings
3. Select a workspace
4. Go to Members
5. Navigate through Members list with up and down key

Expected Result:

The selection that appears on the member is of the same size as the member name row

Actual Result:

The selection that appears on the member is smaller in size than the member name row

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393859_1709032413225.bandicam_2024-02-27_10-17-14-050.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010ded8f191a9831bf
• Upwork Job ID: 1762479227522260992
• Last Price Increase: 2024-02-27
• Automatic offers:
• hoangzinh | Reviewer | 0
• dukenv0307 | Contributor | 0

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010ded8f191a9831bf

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The selection that appears on the member is smaller in size than the member name row

What is the root cause of that problem?

We have a redundant condition in wrapperStyle here. This style was copied from here, but we forgot to remove the isFocused condition in wrapperStyle, because we already have the focused style in pressableStyle here

What changes do you think we should make in order to solve the problem?

In here, remove isFocused && styles.sidebarLinkActive

If it's desirable to isolate this logic only to the workspace members list, we can introduce a new prop to control whether to apply this behavior

We can also consider applying the below C+ suggestion, if that style is more suitable

Btw, I think we not only remove isFocused && styles.sidebarLinkActive, but we also need to update the focused style in pressableStyle here to isFocused && styles.sidebarLinkActive

What alternative solutions did you explore? (Optional)

NA

[hoangzinh]

@dukenv0307 proposal #37293 (comment) looks good to me. It's regression from PR #37074.
Btw, I think we not only remove isFocused && styles.sidebarLinkActive, but we also need to update the focused style in pressableStyle here to isFocused && styles.sidebarLinkActive

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @pecanoro is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[pecanoro]

Ideally, this should be fixed by the author of the PR that broke it but since you guys identified the problem and have a solution, let's do that. This doesn't need to be a blocker since it's super minor.

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[trjExpensify]

Ah, I think @burczu might be fixing this already here: #37199

CC: @shawnborton

[dukenv0307]

Ah, I think @burczu might be fixing this already here: #37199

@trjExpensify I don't see the fix included in the PR code changes, I think it's not being handled there

since you guys identified the problem and have a solution, let's do that. This doesn't need to be a blocker since it's super minor.

@pecanoro Thank you! I'm raising a PR now

[dukenv0307]

@hoangzinh this PR is ready for preview.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: The selection is smaller than member name row when navigating #37319

If no regressions arise, payment will be issued on 2024-03-11. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment automatic offer (Reviewer)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @JmillsExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

@JmillsExpensify, @pecanoro, @hoangzinh, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[hoangzinh]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: Feature/35712 redesign of members list #37074
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/37074/files#r1525990896
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: ❌ It's just a UI issue, and only reproducible when user navigate via keyboard

[pecanoro]

@JmillsExpensify All yours!

[melvin-bot]

@JmillsExpensify, @pecanoro, @hoangzinh, @dukenv0307 Still overdue 6 days?! Let's take care of this!

[JmillsExpensify]

Great thanks! Payment summary as follows:

• Contributor: @dukenv0307 $500
• Contributor+: @hoangzinh $500

I'll process both of these now via Upwork.

[JmillsExpensify]

No regression test needed and contributors paid out, so closing.