[TS migration] Migrate SettingsWallet page to TypeScript

[tienifr]

Details

TS migration SettingsWallet.

Fixed Issues

$ #32003
PROPOSAL:

Tests

ExpensifyCardPage

1. Mock data set in console:

Onyx.merge(`cardList`, {
    234523452345: {
        cardID: 234523452345,
        state: 3,
        bank: 'Expensify Card',
        availableSpend: 10000,
        domainName: 'Expensify',
        lastFourPAN: '2345',
        isVirtual: true,
        cardholderFirstName: 'Test',
        cardholderLastName: 'Test',
    },
    234523452346: {
        cardID: 234523452346,
        state: 4,
        bank: '1000',
        availableSpend: 10000,
        domainName: 'Expensify',
        lastFourPAN: '2346',
        isVirtual: false,
    },
});

2. Go to /settings/wallet/card/Expensify
3. Verify card preview match the above mock and card number is hidden
4. Hard code card details
5. Verify card details match; card number is NOT bold; and expiration date is in the format MM/YYYY

ReportVirtualCardFraudPage

6. Press Report virtual card fraud >> Deactivate card
7. Verify API is called with correct params

ReportCardLostPage

8. Press Report physical card loss / damage >> Next
9. Verify an error shows require you to choose reason
10. Choose a reason and complete the flow
11. Verify API is called with correct params

AddDebitCardPage

12. Go to /settings/wallet/add-debit-card
13. Fill in invalid values in some fields
14. Verify errors show
15. Leave some fields unfilled >> Next
16. Verify errors show

ActivatePhysicalCardPage

Precondition: Have an unactivated card.

17. Go to /settings/wallet/card/Expensify/activate
18. Fill in last four digits of card number
19. Press Activate physical card
20. Verify API is called with correct params
21. Verify error shows That didn't match the last four digits on the card. Please try again.

TransferBalancePage, ChooseTransferAccountPage

22. Mock Onyx data

Onyx.merge('bankAccountList', {
    1: {
        title: `Generic bank Checking`,
        description: 'Account ending in 5087',
        methodID: '1',
        key: `bankAccount-1`,
        accountType: 'bankAccount',
        accountData: {
            accountNumber: 'XXXXX5087',
            additionalData: {
                bankName: `Generic bank`,
            },
            state: 'OPEN',
            type: 'PERSONAL',
        },
        isDefault: false,
    },
    2: {
        title: `Generic bank Checking 2`,
        description: 'Account ending in 5123',
        methodID: '2',
        key: `bankAccount-2`,
        accountType: 'bankAccount',
        accountData: {
            accountNumber: 'XXXXX5088',
            additionalData: {
                bankName: `Generic bank`,
            },
            state: 'OPEN',
            type: 'BUSINESS',
        },
        isDefault: false,
    },
});

Onyx.merge('fundList', {
    4: {
        title: 'Test card',
        description: 'Card ending in 4242',
        methodID: 4,
        key: 'card-4',
        accountType: 'debitCard',
        accountData: {
            additionalData: {
                isBillingCard: false,
                isP2PDebitCard: true,
            },
            addressName: 'Test cardList card',
            addressState: 'US',
            addressStreet: 'Street',
            addressZip: 75092,
            cardMonth: 12,
            cardNumber: '424242XXXXXX4242',
            cardYear: 2026,
            created: '2023-01-13 22:27:23',
            currency: 'USD',
            fundID: 4,
        },
        isDefault: false,
    },
    5: {
        title: 'Test card 2',
        description: 'Card ending in 0000',
        methodID: 5,
        key: 'card-5',
        accountType: 'debitCard',
        accountData: {
            additionalData: {
                isBillingCard: false,
                isP2PDebitCard: true,
            },
            addressName: 'Nowhere',
            addressState: 'US',
            addressStreet: 'Street',
            addressZip: 75092,
            cardMonth: 12,
            cardNumber: '424242XXXXXX0000',
            cardYear: 2026,
            created: '2023-01-13 22:27:23',
            currency: 'USD',
            fundID: 5,
        },
        isDefault: false,
    },
});

23. Go to settings/wallet/transfer-balance
24. Mock Onyx

Onyx.merge('userWallet', {
    currentBalance: 1000,
    tierName: 'GOLD',
})

25. Verify Transfer button is disabled (because there's no selected account)
26. Press Instant (Debit card)
27. Verify two cards appear with correct information
28. Select a card
29. Verify the selected card shows under Which account? and Fee shows $0.25
30. Press 1-3 Business days (Bank account)
31. Verify two bank accounts appear with correct information
32. Select an account
33. Verify the selected account shows under Which account? and Fee shows $0.00
34. Press Transfer
35. Verify API is called with correct params
36. Verify error shows Auth TransferWalletBalance returned an error

• Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

ExpensifyCardPage

1. On an account with a VIRTUAL and PHYSICAL Expensify card:
2. Go to /settings/wallet/card/Expensify
3. Verify that the card number is hidden with dots
4. Press Reveal details
5. Verify card details is correct; card number is NOT bold; and expiration date is in the format MM/YYYY

ReportVirtualCardFraudPage

6. Press Report virtual card fraud >> Deactivate card
7. Verify card is deactivated

ReportCardLostPage

8. Press Report physical card loss / damage >> Next
9. Verify an error shows require you to choose reason
10. Choose a reason and complete the flow
11. Verify card is reported and closed

AddDebitCardPage

12. Go to /settings/wallet/add-debit-card
13. Fill in invalid values in some fields
14. Verify errors show
15. Leave some fields unfilled >> Next
16. Verify errors show

ActivatePhysicalCardPage

Precondition: Have an unactivated physical card.

17. Go to /settings/wallet/card/Expensify/activate
18. Fill in last four digits of card number
19. Press Activate physical card
20. Verify card is activated

TransferBalancePage, ChooseTransferAccountPage

23. Go to settings/wallet/transfer-balance
24. Verify balance shows correctly
25. Press Instant (Debit card)
26. Verify two cards appear with correct information
27. Select a card
28. Verify the selected card shows under Which account? and Fee shows 1.5% of current balance
29. Press 1-3 Business days (Bank account)
30. Verify two bank accounts appear with correct information
31. Select an account
32. Verify the selected account shows under Which account? and Fee shows $0.00
33. Press Transfer
34. Verify balance is transfered to the selected account/card

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-25.at.19.42.19-compressed.mov

Screen.Recording.2024-02-25.at.19.41.42-compressed.mov

Screen.Recording.2024-02-25.at.19.41.05-compressed.mov

Android: mWeb Chrome

Screen.Recording.2024-02-25.at.19.46.20-compressed.mov

Screen.Recording.2024-02-25.at.19.45.23-compressed.mov

Screen.Recording.2024-02-25.at.19.44.30-compressed.mov

iOS: Native

Screen.Recording.2024-02-25.at.19.25.42-compressed.mov

Screen.Recording.2024-02-25.at.19.32.22-compressed.mov

Screen.Recording.2024-02-25.at.19.33.17-compressed.mov

Screen.Recording.2024-02-25.at.19.34.24-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-02-25.at.19.38.37-compressed.mov

Screen.Recording.2024-02-25.at.19.37.31-compressed.mov

Screen.Recording.2024-02-25.at.19.36.51-compressed.mov

MacOS: Chrome / Safari

ExpensifyCardPage, ReportVirtualCardFraudPage, ReportCardLostPage

Screen.Recording.2024-01-19.at.15.17.20-compressed.mov

Screen.Recording.2024-01-19.at.15.23.20-compressed.mov

AddDebitCardPage

Screen.Recording.2024-01-19.at.16.19.45-compressed.mov

TransferBalancePage, ChooseTransferAccountPage

Screen.Recording.2024-02-25.at.19.17.20-compressed.mov

MacOS: Desktop

ExpensifyCardPage, ReportVirtualCardFraudPage, ReportCardLostPage

Screen.Recording.2024-01-19.at.15.17.20-compressed.mov

Screen.Recording.2024-01-19.at.15.23.20-compressed.mov

AddDebitCardPage

Screen.Recording.2024-01-19.at.16.19.45-compressed.mov

TransferBalancePage, ChooseTransferAccountPage

Screen.Recording.2024-02-25.at.19.17.20-compressed.mov

[blazejkustra]

Lint check is failing, please change the title to [TS migration] Migrate 'SettingsWallet' page to TypeScript

[melvin-bot]

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[tienifr]

@situchan Do you want me to fix it here?

[situchan]

@situchan Do you want me to fix it here?

No, can you create follow-up PR if possible?

[tienifr]

Sure, I'll raise follow-up PR in that issue and get it merged today.

[Julesssss]

#34716 (comment)

@tienifr please let me know when that PR is ready and I'll review it

[situchan]

@tienifr please merge main. Crash is fixed now

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[tienifr]

@situchan I added screenshots for all platforms. We're good to go.

[situchan]

Note: we tested using mock data.
Not sure if QA team is able to test this PR properly since they might not have physical card.

[tienifr]

QA team is able to test this PR properly since they might not have physical card

They have. They already tested all other card/wallet PRs.

[Julesssss]

Hey @tienifr, would you mind merging main again please, to help prevent non-conflicting issues once merged. Thanks

[Julesssss]

Hey @tienifr, would you mind merging main again please, to help prevent non-conflicting issues once merged. Thanks

Actually nevermind, merging main on Friday was probably good enough.

[Julesssss]

I'm struggling to test some of this on dev. Let's get this to staging for QA verification

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[kavimuru]

@Julesssss @situchan QA team does not have physical card or not activated cards. Is this PR internal?

[OSBotify]

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[jayeshmangwani]

Changing the parameter of getLatestErrorMessage from virtualCard to virtualCard?.errors ?? {} causes an issue where the server error does not display. This happens because the updated parameter always returns an empty string more context on this Issue #49010 (comment).