Fix wrong back navigation transition animation in transfer balance page #37998

bernhardoj · 2024-03-08T17:54:40Z

Details

The back navigation in transfer balance page slides the page from right to left.

Fixed Issues

$ #37982
PROPOSAL: #37982 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Go to account settings > wallet > transfer balance
Click the header back button
Verify the transfer balance page close animation is slides to the right

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-09.at.01.48.38.mov

Android: mWeb Chrome

Screen.Recording.2024-03-09.at.01.49.26.mov

iOS: Native

Screen.Recording.2024-03-09.at.01.44.02.mov

iOS: mWeb Safari

Screen.Recording.2024-03-09.at.01.49.09.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-09.at.01.45.19.mov

MacOS: Desktop

Screen.Recording.2024-03-09.at.01.44.22.mov

melvin-bot · 2024-03-08T17:54:45Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-03-08T17:55:02Z

src/pages/settings/Wallet/TransferBalancePage.tsx

            >
                <HeaderWithBackButton
                    title={translate('common.transferBalance')}
                    shouldShowBackButton
-                    onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET)}


The default props is Navigation.goBack

bernhardoj · 2024-03-08T17:55:50Z

src/pages/settings/Wallet/TransferBalancePage.tsx

@@ -156,12 +156,10 @@ function TransferBalancePage({bankAccountList, fundList, userWallet, walletTrans
                titleKey="notFound.pageNotFound"
                subtitleKey="transferAmountPage.notHereSubTitle"
                linkKey="transferAmountPage.goToWallet"
-                onLinkPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET)}


To cover the text button of the not found page case. The default props is Navigation.dismissModal

Screen.Recording.2024-03-09.at.01.43.41.mov

mountiny · 2024-03-08T20:14:47Z

@bernhardoj @jayeshmangwani can you test deeplinking to the transfer balance page and then going back?

bernhardoj · 2024-03-09T05:31:55Z

Sure.

Works fine on web

Screen.Recording.2024-03-09.at.13.16.58.mov

Screen.Recording.2024-03-09.at.13.18.49.mov

But it looks weird on the native

Screen.Recording.2024-03-09.at.13.21.38.mov

When I deep link to the transfer balance page, the LHN slides to the right.
The page is pushed twice to the stack, so pressing back will show the same page. It's caused by this code

It's unrelated to this PR though as this happens on other pages too that are 2 levels deep in the settings page.

Screen.Recording.2024-03-09.at.13.25.36.mov

jayeshmangwani · 2024-03-09T09:18:28Z

@bernhardoj Can you please include the steps, how can you able to access transfer balance page ?
I have tried to set userWallet to GOLD in dev, but still I am not able to access the page and navigating to to debit card page.

jayeshmangwani · 2024-03-09T11:20:11Z

tranfer-succesfull.mov

@bernhardoj Need to fix transfer successful animation too

jayeshmangwani · 2024-03-09T11:41:38Z

can you test deeplinking to the transfer balance page and then going back?

@mountiny I am now able to test Transfer balance by setting the the wallet to GOLD in dev environment

mWeb and web is working fine

mWeb , web

mweb-safari.mov

web-deeplink.mov

But getting an issue in the iOS native device when using the deeplink, when pressing the back icon it goes to the not found page and need to press back again to navigate back to the wallet page

iOS

iOS-deeplink.mov

And i think that issue is not related to this PR, if we revert this PR then also issue is happening in the main branch, and also I found similar issue with other pages, e.g. Status page

Status Page

status-deeplink.mov

bernhardoj · 2024-03-09T14:28:04Z

Can you please include the steps, how can you able to access transfer balance page ?

I change the code to access the page 😅

Need to fix transfer successful animation too

Fixed.

Screen.Recording.2024-03-09.at.22.26.12.mov

jayeshmangwani · 2024-03-09T17:30:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mWeb-chrome.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

mWeb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani · 2024-03-09T17:30:19Z

LGTM

mountiny

Thanks

OSBotify · 2024-03-11T13:53:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-12T18:51:00Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2024-03-12T19:17:22Z

@bernhardoj "Transfer balance" button should be only visible when user has some balance in wallet, but Applause don't have it.
Could you validate internally?

bernhardoj · 2024-03-13T02:50:32Z

@kavimuru I think you need a wallet with a Gold/Platinum tier.

@jayeshmangwani can you share how do you change the wallet to Gold?

jayeshmangwani · 2024-03-13T06:38:49Z

@kavimuru @bernhardoj I was able to test by calling the Onyx mock data on wallet page locally, let me give you mock data and attaching a video how I had activated locally transfer balance, took reference from this PR Tests

BankAccountList Mock data

Onyx.merge('bankAccountList', {
 1: {
     title: `Generic bank Checking`,
     description: 'Account ending in 5087',
     methodID: '1',
     key: `bankAccount-1`,
     accountType: 'bankAccount',
     accountData: {
         accountNumber: 'XXXXX5087',
         additionalData: {
             bankName: `Generic bank`,
         },
         state: 'OPEN',
         type: 'PERSONAL',
     },
     isDefault: false,
 },
 2: {
     title: `Generic bank Checking 2`,
     description: 'Account ending in 5123',
     methodID: '2',
     key: `bankAccount-2`,
     accountType: 'bankAccount',
     accountData: {
         accountNumber: 'XXXXX5088',
         additionalData: {
             bankName: `Generic bank`,
         },
         state: 'OPEN',
         type: 'BUSINESS',
     },
     isDefault: false,
 },
});

Onyx.merge('fundList', {
 4: {
     title: 'Test card',
     description: 'Card ending in 4242',
     methodID: 4,
     key: 'card-4',
     accountType: 'debitCard',
     accountData: {
         additionalData: {
             isBillingCard: false,
             isP2PDebitCard: true,
         },
         addressName: 'Test cardList card',
         addressState: 'US',
         addressStreet: 'Street',
         addressZip: 75092,
         cardMonth: 12,
         cardNumber: '424242XXXXXX4242',
         cardYear: 2026,
         created: '2023-01-13 22:27:23',
         currency: 'USD',
         fundID: 4,
     },
     isDefault: false,
 },
 5: {
     title: 'Test card 2',
     description: 'Card ending in 0000',
     methodID: 5,
     key: 'card-5',
     accountType: 'debitCard',
     accountData: {
         additionalData: {
             isBillingCard: false,
             isP2PDebitCard: true,
         },
         addressName: 'Nowhere',
         addressState: 'US',
         addressStreet: 'Street',
         addressZip: 75092,
         cardMonth: 12,
         cardNumber: '424242XXXXXX0000',
         cardYear: 2026,
         created: '2023-01-13 22:27:23',
         currency: 'USD',
         fundID: 5,
     },
     isDefault: false,
 },
});

Wallet mock data

Onyx.merge('userWallet', {
    currentBalance: 1000,
    tierName: 'GOLD',
})

Result

transfer-balance-mock.mov

bernhardoj · 2024-03-13T06:41:31Z

@jayeshmangwani thanks. @kavimuru can you please try the steps above?

mountiny · 2024-03-13T14:05:12Z

@shawnborton has kindly QAed this and works well! 🎉

OSBotify · 2024-03-13T19:46:15Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.51-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

don't use fallback route

50aaeca

bernhardoj requested a review from a team as a code owner March 8, 2024 17:54

melvin-bot bot requested review from jayeshmangwani and removed request for a team March 8, 2024 17:54

bernhardoj commented Mar 8, 2024

View reviewed changes

mountiny assigned bernhardoj Mar 8, 2024

bernhardoj added 2 commits March 9, 2024 22:23

Merge branch 'main' into fix/37982-transfer-balance-page-navigation

ddd23ba

don't use fallback route

87f0056

jayeshmangwani approved these changes Mar 9, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny March 9, 2024 17:33

mountiny approved these changes Mar 11, 2024

View reviewed changes

mountiny merged commit ab1997d into Expensify:main Mar 11, 2024
16 checks passed

github-actions bot mentioned this pull request Mar 12, 2024

Deploy Checklist: New Expensify 2024-03-12 #38162

Closed

84 tasks

luacmartins mentioned this pull request Mar 12, 2024

[HOLD for payment 2024-03-29] [$500] [Wave Collect] [Ideal Nav] Incorrect animation direction on Wallet and Troubleshooting page #37359

Closed

6 tasks

melvin-bot bot mentioned this pull request Mar 13, 2024

[HOLD for payment 2024-03-20] [$250] navigation transition from "transfer balance" screen slides from right instead of left #37982

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix wrong back navigation transition animation in transfer balance page #37998

Fix wrong back navigation transition animation in transfer balance page #37998

bernhardoj commented Mar 8, 2024

melvin-bot bot commented Mar 8, 2024

bernhardoj Mar 8, 2024

bernhardoj Mar 8, 2024

mountiny commented Mar 8, 2024

bernhardoj commented Mar 9, 2024

jayeshmangwani commented Mar 9, 2024

jayeshmangwani commented Mar 9, 2024

jayeshmangwani commented Mar 9, 2024

bernhardoj commented Mar 9, 2024

jayeshmangwani commented Mar 9, 2024

jayeshmangwani commented Mar 9, 2024

mountiny left a comment

OSBotify commented Mar 11, 2024

OSBotify commented Mar 12, 2024

kavimuru commented Mar 12, 2024

bernhardoj commented Mar 13, 2024

jayeshmangwani commented Mar 13, 2024

bernhardoj commented Mar 13, 2024

mountiny commented Mar 13, 2024

OSBotify commented Mar 13, 2024

Fix wrong back navigation transition animation in transfer balance page #37998

Fix wrong back navigation transition animation in transfer balance page #37998

Conversation

bernhardoj commented Mar 8, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 8, 2024

bernhardoj Mar 8, 2024

Choose a reason for hiding this comment

bernhardoj Mar 8, 2024

Choose a reason for hiding this comment

mountiny commented Mar 8, 2024

bernhardoj commented Mar 9, 2024

jayeshmangwani commented Mar 9, 2024

jayeshmangwani commented Mar 9, 2024

jayeshmangwani commented Mar 9, 2024

bernhardoj commented Mar 9, 2024

jayeshmangwani commented Mar 9, 2024

Reviewer Checklist

Screenshots/Videos

jayeshmangwani commented Mar 9, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 11, 2024

OSBotify commented Mar 12, 2024

kavimuru commented Mar 12, 2024

bernhardoj commented Mar 13, 2024

jayeshmangwani commented Mar 13, 2024

bernhardoj commented Mar 13, 2024

mountiny commented Mar 13, 2024

OSBotify commented Mar 13, 2024