Deploy Checklist: New Expensify 2024-03-12

[github-actions]

Release Version: 1.4.51-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

• perf: improve chat switch performance #32336
• New Chat page list refactor #34356
• [TS migration] Migrate SearchPage #34655
• [NO QA] Remove shouldAllowActionableMentionWhispers unused param #34770
• [TS migration] Migrate 'Report' page to TypeScript #35566
• Fix displaying edited amount in IOU preview for scan failed receipt #36407
• Update archive messages for threads #36432
• fix breadcumbs font auto scaling #36655
• Prevent threads from being counted as DMs #37030
• Add character limit on display name #37125
• Create Set-time-zone.md #37162
• fix: Set childReportID of the optimistic IOU report action #37232
• Implement WorkspaceMoreFeaturesPage #37441
• Fix - Remove @expensify.sms from SMS mentions #37559
• [No QA] [TS Migration] Migrate testRunner.js, UnreadIndicatorsTest.js, getIsUsingFakeTimers.js, setupAfterEnv.js, config.dev.js tests to TypeScript #37587
• Show only one update available notification at a time #37595
• Adding pagination to SelectionList component #37627
• feat: Workflow payer page #37629
• fix public room is not opened #37664
• [Snyk] Security upgrade onfido-sdk-ui from 13.6.1 to 14.15.0 #37713
• [TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript #37716
• Create WorkspaceTagsSettingsPage #37755
• fix selected parent category is not displayed as selected #37805
• Define type definition for the connections property #37806
• [TS migration] Migrate 'Checkbox.stories.js', 'FormAlertWithSubmitButton.stories.js', 'Header.stories.js' and 'HeaderWithBackButton.stories.js' stories to TypeScript #37818
• fix(36381): blur composer on edit menu action #37861
• Update REVIEWER_CHECKLIST.md to include better Design guidance #37863
• Scroll to bottom of report after create task #37868
• Fix bank account confirmation page confirm button is too close to the bottom #37871
• Delete docs/articles/expensify-classic/settings/Preferences.md #37915
• Delete docs/articles/expensify-classic/billing-and-subscriptions/Annu… #37916
• Delete docs/articles/expensify-classic/billing-and-subscriptions/Pay-… #37918
• Delete docs/articles/expensify-classic/billing-and-subscriptions/Indi… #37919
• [No QA] [TS Migration] Migrate 'ReportActionItemImages.stories.js', 'EReceiptThumbail.stories.js', 'EReceipt.stories.js' and 'SelectionList.stories.js' stories to TypeScript #37956
• handle support redirect #37971
• Fix wrong back navigation transition animation in transfer balance page #37998
• HelpDot - Rename hubs and add domains hub #38004
• fallback using last visible action message for lhn #38019
• Fix: PDF thumbnail reload when hovering on it #38031
• Fix: about:blank page opens in download app link on Safari #38032
• [Audit][Implementation] Refactor ReportActionItem subscriptions #38040
• [NoQA] feat: remove all occurrences of Flipper from the repo #38053
• Update Request-the-Card.md #38057
• [NoQA] [Dashboard] add graphite name and port #38061
• [NoQA] Revert lhn order #38081
• [NoQA] Fix type error when keyListItem is not string #38082
• [NoQA] Add Jason to Provisioning profile #38094
• Fix crash on Tags page error #38096
• [No QA] fix patch warning #38109
• [NO QA] Update iOS AdHoc profiles to enable cplus device testing #38122
• [NoQA] Fix type errors in SelectionList.stories.tsx #38139
• fix: hubs publishing incorrectly #38140
• [No QA] Adding log to identify what is triggering ReconnectApp #38143
• Adding idempotency param for ReconnectApp #38149
• Follow-up: fix crash on the report screen #38151
• [CP Staging] Revert expensify-common #649 from version used on App #38175
• Revert "New Chat page list refactor" #38182
• fix/38171 - [CP Staging] #38189

Deploy Blockers:

• Expense - Transaction thread with violation does not appear in LHN #37405
• [Situ is out until May] [HOLD for payment 2024-03-22] [HOLD for payment 2024-03-20] Chat - Emoji is not showing in chat #38169
• [HOLD for payment 2024-03-22] [HOLD for payment 2024-03-20] [$500] Thread - Thread header shows "Unavailable workspace" #38171
• [$500] Account Settings – Banners in About/ Preferences/ Security are without animation in Offline #38172
• [HOLD for payment 2024-03-22] [HOLD for payment 2024-03-20] Start chat - Contact list does not scroll back up after clicking Add to group #38173
• [HOLD for payment 2024-04-03] [$500] Web - Thread - Console error ERR_FAILED 404 shows up when opening thread #38174
• [HOLD for payment 2024-03-22] [HOLD for payment 2024-03-20] Start chat - Focus is not applied on the first user #38176
• [HOLD for payment 2024-04-15] [$500] Start chat - Chat RHP switches to Room tab when dragging input from right to left #38177
• Categories - Toggling on Categories/Tag does not actually enable Categories/Tag #38178
• [HOLD for payment 2024-03-22] [HOLD for payment 2024-03-20] Start chat - Contact list shows up after some delay with skeleton loading #38179
• [HOLD for payment 2024-03-22] [HOLD for payment 2024-03-20] Start chat - Selected members appear when the search query does not match the selected members #38181
• [$250] [HOLD for payment 2024-04-05] Workspace - Not here page shows up when opening message in thread in deleted workspace #38183
• [HOLD for payment 2024-03-26] [$250] [Wave Collect] [More Features] WS features - App returns to the same WS settings page after toggling on a feature #38185
• [Simplified Collect][Tags] - "Members must tag all spend" switch is toggled back on after refreshing page #38188
• [HOLD for payment 2024-03-25] [Wave Collect] [Workflows] "Delayed Submissions" toggle does not toggle off unless backed out for Collect Policy #38198
• [HOLD for payment 2024-04-15] [$250] Chat - Nested quote markdown is not displayed on compose box when editing message #38199
• [HOLD for payment 2024-04-09] [Simplified Collect][Workflows] Bank account info still displayed in Make or track payments after disconnecting #38200
• [HOLD for payment 2024-05-21] [$125] BA - Unable to confirm on double check Personal info page, error appears #38201
• [Wave Collect] [More Features] Enabled features disappear from side bar and are toggled off when relogin #38202
• [HOLD for payment 2024-03-22] [$500] Authorized payer - Enter key does not select another member as authorized payer #38203
• [HOLD for payment 2024-04-03] [Wave Collect] [Workflows] Unable to toggle Make or track payments #38206
• [HOLD for payment 2024-06-03] [$500] IOU - Creating IOU Distance offline with incomplete addresses results in incorrect error message #38213
• Payment - Missing Pay elsewhere button when Make or track payments is enabled w/o bank account #38214

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[luacmartins]

Checking off #32336. This PR was reverted.

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.51-0 🚀

[kavimuru]

#38057 is a PROD PR can we check it off?

[luacmartins]

Yes, checked it off, thanks!

[luacmartins]

Checking off #38172. Also happens in prod.

[luacmartins]

Checking off #38185. Demoted to NAB

[luacmartins]

Checking off #38182. Tested the CP on staging and it fixed all blockers it was supposed to.

[luacmartins]

Checking off #38183. Demoted to NAB

[luacmartins]

Checking off #38174. Demoted to NAB

[Tony-MK]

Issue #38171 is handled and a fix has been deployed.

We should presumably check it off. 🤔

[luacmartins]

Checking off #38171. Tested in staging and it's fixed.

[mountiny]

#37998 QAed internally

[kavimuru]

@luacmartins Regression is down to 8%
unchecked PRs:
#37629 failing with #37629
#37664 failing with #38212 repro in PROD, checking it off
#37113 failing with #38201
#37755 failing with #38188 closed with this comment, checking it off
#38032 web and desktop pending validation and other platforms are pass
#37595 being validated

[luacmartins]

Checking off #37405. Demoted to NAB

[kavimuru]

Regression is 2% left in the TR

unchecked PRs:
#37629 failing with #37629
#37113 failing with #38201
#38032 failing with #38241 and reprod in PROD, cheecking it off

Open Blockers:
#38213 and #38214

[luacmartins]

Checking off #37629, since we'll tackle that in #38214.

@kavimuru is this link correct? #37113 that PR was closed and I don't see it in the checklist

[mkhutornyi]

is this link correct? #37113 that PR was closed and I don't see it in the checklist

#37713 is the correct PR

[kavimuru]

@luacmartins, @mkhutornyi was correct, Sorry it was my mistake

[tgolen]

Removed #38213 from being a blocker and checked it off.

[luacmartins]

Ah cool, so I'm checking off #37713 since we confirmed that's the expected behavior, we just need to update the error message.

[luacmartins]

@kavimuru is regression done?

[kavimuru]

@luacmartins Yes we are done.

[luacmartins]

Checklist is clear. Shipping it

[luacmartins]