Payment - Missing Pay elsewhere button when Make or track payments is enabled w/o bank account

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.51-3
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User is an admin of Collect workspace.
• "Make or track payments" is enabled in Workspace settings > Workflows.
• Bank account is not set up in the Collect workspace.

1. Go to staging.new.expensify.com.
2. [Employee] Request money in the workspace chat.
3. [Admin] Go to workspace chat with employee > Expense report.
4. Note that Pay elsewhere button is missing.
5. [Admin] Go to workspace settings > Collect workspace > Workflows.
6. [Admin] Toggle off "Make or track payments".
7. [Admin] Return to expense report in Step 3.

Expected Result:

Pay elsewhere button should show up because "Make or track payments" is only for payment via Expensify.

Actual Result:

Pay elsewhere button is missing when "Make or track payments" is enabled without bank account.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6412089_1710324029339.bandicam_2024-03-13_17-55-47-381.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@Gonals I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[Gonals]

I'm actually not sure either. @thienlnam, I think you are familiar with the new "track" flows. Is this intended?

[luacmartins]

Discussing if this is expected or not. cc @lakchote @ishpaul777

[thienlnam]

I'm unaware of this new selector - seems unrelated to to the 'Track Expense' features that we're building

[JmillsExpensify]

This is a simplified collect initiative. The confusion is understandable though given that it says "track" in the toggle description.

[ishpaul777]

It seems this condition fails 👇

App/src/libs/ReportUtils.ts

Lines 1272 to 1274 in f52bb02

	if (policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_YES) {
	const isReimburser = session?.email === policy?.reimburserEmail;
	return isReimburser && (isApproved || isManager);

[luacmartins]

Ok, discussed this internally and the solution for now is:

• Reimbursement enabled, indirect (no VBBA) -> show Pay elsewhere and Pay with Expensify
• Reimbursement enabled, direct (with VBBA) -> show Pay with Expensify
• Reimbursement disabled -> no pay button

[luacmartins]

I'm gonna demote this to NAB since it only affects Collect policies for now and those only show up in NewDot if isPolicyExpenseChatEnabled = true which means very few people have this enabled. I'm doing this so we can tackle this issue with a more wholistic approach here, since a lot of these buttons are incorrect after we introduced Workflows

[luacmartins]

I'm closing this issue in favor of #38254