Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categories - Toggling on Categories/Tag does not actually enable Categories/Tag #38178

Closed
6 tasks done
kbecciv opened this issue Mar 12, 2024 · 5 comments
Closed
6 tasks done
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Mar 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.51-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Issue found when executing PR: #37755

Action Performed:

Precondition:

  • User is an owner of Collect workspace.
  • The Collect workspace has enabled categories.
  1. Go to staging.new.expensify.com.
  2. Go to workspace settings > Collect workspace.
  3. Go to More features.
  4. Toggle off Categories.
  5. Toggle on Categories.
  6. Go to Old Dot and navigate to Categories page of the Collect workspace.

Expected Result:

The Categories will be enabled on Old Dot because it is reenabled on New Dot in Step 5.

Actual Result:

In Step 4, toggling off Categories updates the list on Old Dot.
In Step 5. toggling on Categories does not update the list on Old Dot.
The same issue goes for Tags.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6411491_1710273702551.20240313_035658.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Mar 12, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 12, 2024

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Mar 12, 2024

We think that this bug might be related to #wave-control
CC @trjExpensify

@AndrewGable
Copy link
Contributor

@luacmartins - I see you were the main reviewer of the linked PR #37755. Do you think this is related?

@luacmartins
Copy link
Contributor

Yes, but this is not an issue. The more features page turns on the feature (shows the page in the LHN in NewDot), not the requirement to categorize/tag expenses. I think we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants