[HOLD for payment 2024-03-20] App loads chats on the left with tag list on the right when refreshing tag list

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.48-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

• User is an admin of Collect workspace with tags.
• The tags include tag in Parent: Child format and some regular

1. Go to staging.new.expensify.com
2. Go to Workspace settings > Collect workspace.
3. Go to Tags.
4. Refresh the page.

Expected Result:

Workspace settings on the left are preserved.

Actual Result:

App loads chats on the left with tag list on the right.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6404680_1709765092472.bandicam_2024-03-07_06-33-01-755.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When refreshing on the workspace tags page, the left page shows LHN while the central page shows the workspace tags page.

What is the root cause of that problem?

When we refresh the page, it will call getAdaptedState and see what navigator is inside the nav stack. In our case, we have a central pane (workspace tags page).

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 253 to 254 in ffa731a

	const matchingBottomTabRoute = getMatchingBottomTabRouteForState(state);
	routes.push(createBottomTabNavigator(matchingBottomTabRoute, policyID));

It will try to find the matching bottom tab navigator with the current central pane.

App/src/libs/Navigation/linkingConfig/getMatchingBottomTabRouteForState.ts

Lines 16 to 20 in ffa731a

	const tabName = CENTRAL_PANE_TO_TAB_MAPPING[topmostCentralPaneRoute.name];
	if (tabName === SCREENS.WORKSPACE.INITIAL) {
	return {name: tabName, params: topmostCentralPaneRoute.params};
	}
	return {name: tabName, params: paramsWithPolicyID};

However, we don't have a mapping for the workspace tags page and the bottom tab navigator page.

App/src/libs/Navigation/linkingConfig/TAB_TO_CENTRAL_PANE_MAPPING.ts

Lines 4 to 18 in ffa731a

	const TAB_TO_CENTRAL_PANE_MAPPING: Record<BottomTabName, CentralPaneName[]> = {
	[SCREENS.HOME]: [SCREENS.REPORT],
	[SCREENS.ALL_SETTINGS]: [SCREENS.SETTINGS.WORKSPACES],
	[SCREENS.WORKSPACE.INITIAL]: [
	SCREENS.WORKSPACE.PROFILE,
	SCREENS.WORKSPACE.CARD,
	SCREENS.WORKSPACE.WORKFLOWS,
	SCREENS.WORKSPACE.REIMBURSE,
	SCREENS.WORKSPACE.BILLS,
	SCREENS.WORKSPACE.INVOICES,
	SCREENS.WORKSPACE.TRAVEL,
	SCREENS.WORKSPACE.MEMBERS,
	SCREENS.WORKSPACE.CATEGORIES,
	],
	};

So, it will default to HOME, that is the LHN.

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 52 to 63 in ffa731a

	function createBottomTabNavigator(route: NavigationPartialRoute<BottomTabName>, policyID?: string): NavigationPartialRoute<typeof NAVIGATORS.BOTTOM_TAB_NAVIGATOR> {
	const routesForBottomTabNavigator: Array<NavigationPartialRoute<BottomTabName>> = [{name: SCREENS.HOME, params: {policyID}}];
	if (route.name !== SCREENS.HOME) {
	// If the generated state requires tab other than HOME, we need to insert it.
	routesForBottomTabNavigator.push(addPolicyIDToRoute(route, policyID) as NavigationPartialRoute<BottomTabName>);
	}
	return {
	name: NAVIGATORS.BOTTOM_TAB_NAVIGATOR,
	state: getRoutesWithIndex(routesForBottomTabNavigator),
	};

What changes do you think we should make in order to solve the problem?

Add the mapping for workspace tags page.

[SCREENS.WORKSPACE.INITIAL]: [
    ...
    SCREENS.WORKSPACE.TAGS,
],

What alternative solutions did you explore? (Optional)

Or we can dynamically build the mapping.

const buildWorkspaceMapping = () => {
    return Object.keys(config['screens'][NAVIGATORS.CENTRAL_PANE_NAVIGATOR]['screens']).filter(screen => screen.startsWith('Workspace_'))
}

[luacmartins]

@waterim since this came from the Tags PR. Let's fix this as part of the next settings PR.

[waterim]

@luacmartins this one is already fixed in settings PR!

[luacmartins]

Nice one! I added this list to the list of fixed issues of that PR.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Create WorkspaceTagsSettingsPage #37755

If no regressions arise, payment will be issued on 2024-03-20. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@luacmartins] Determine if we should create a regression test for this bug.
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[luacmartins]

IMO there's no need for the BZ checklist since this is a new feature in development

[luacmartins]

No payments due since it was fixed in this PR. I think we can close this one!