Create WorkspaceTagsSettingsPage #37755

waterim · 2024-03-05T14:33:24Z

Details

Create Tags Settings Page

Fixed Issues

$ #37310
$ #37848
$ #37873

Tests

Go to settings in collect policy workspace
Go to tags
Click on Settings button
Try to update Tags name
Try the switcher

Go to tag page
try to reload the page
Look that sidebar is correct.

Navigate to staging.new.expensify.com
Go to Workspace settings > Collect workspace
Select the "Tags" tab
Add some tags via classic app
Refresh the page to see the newly added tags

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

None

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

IOS

Android

…ings

src/pages/workspace/tags/WorkspaceEditTagsPage.tsx

melvin-bot · 2024-03-06T17:45:06Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2024-03-06T18:04:20Z

Assigning @mkhutornyi for review!

src/pages/workspace/tags/WorkspaceEditTagsPage.tsx

mkhutornyi · 2024-03-06T18:14:03Z

Please resolve conflict

…ings

waterim · 2024-03-06T21:24:48Z

@mkhutornyi Updated and resolved

mkhutornyi · 2024-03-06T22:43:14Z

No Tests / QA Steps specified. Please also add platform screenshots

mkhutornyi · 2024-03-06T23:13:04Z

Not from this PR but font seems to be wrong

…ings

waterim · 2024-03-07T15:32:59Z

@mkhutornyi Updated everything, also fixed fonts and bugs

mkhutornyi · 2024-03-07T15:47:30Z

Looks like linked issues added by Carlos are overwritten.

@waterim please link again like this:

$ https://github.com/Expensify/App/issues/37310
$ https://github.com/Expensify/App/issues/37848
$ https://github.com/Expensify/App/issues/37873

Also, please add more test cases from those linked issues

waterim · 2024-03-07T15:50:56Z

@mkhutornyi updated

luacmartins

Left a few comments

src/libs/actions/Policy.ts

luacmartins · 2024-03-07T20:28:37Z

src/libs/actions/Policy.ts

+                key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
+                value: {
+                    requiresTag,
+                    errors: {


I think this should be errorFields. errors is just an object keyed by timestamp, so this wouldn't work as we have here. Same for the others below.

errors are working, it shows an error, we have the same in categories
Maybe Im missing something

I'm seeing the following issues when simulating an error from the API:

For enable/disable the error shows up in the LHN instead of the RHN under the toggle. Clearing the error also clears the entire policy

Screen.Recording.2024-03-08.at.3.14.18.PM.mov

App crashes when simulating an error on the rename API:

Screen.Recording.2024-03-08.at.3.15.17.PM.mov

Is this thread resolved?

I'm retesting this now

No, this is still happening. I think we can continue with this and I'll address it in a fast following PR.

luacmartins · 2024-03-07T20:32:36Z

src/libs/actions/Policy.ts

+                    [newName]: {...oldPolicyTags, name: newName},
+                    [oldName]: null,


Hmm I think the correct pattern here is to have the old tagList pending as delete and the new one pending as add

Suggested change

[newName]: {...oldPolicyTags, name: newName},

[oldName]: null,

[newName]: {...oldPolicyTags, name: newName, pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD},

[oldName]:

{pendingAction:CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE},

In addition, we'd have successData to remove the pendingActions and delete the old taglist

waterim · 2024-03-11T21:44:55Z

@mkhutornyi This one is already in development in moreFeatures PR
will be an additional Wrapper which will redirect to "More features" if its disabled

mkhutornyi · 2024-03-11T21:46:12Z

ok given reported issues are planned to be fixed in next PRs, will go ahead checklist

mkhutornyi · 2024-03-11T22:03:38Z

After enable tags, it takes super long to load tags list initially. Also, at the moment tags are loaded, Tags menu briefly disappears. Also disabled category is automatically enabled. This can be clearly reproduced after logout and re-login

desktop.mov

mkhutornyi · 2024-03-11T22:11:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

mkhutornyi · 2024-03-11T22:12:49Z

App crashes while updating tag name

luacmartins · 2024-03-11T22:13:12Z

@mkhutornyi I found that issue too and my PR will fix that - #38096. I based my PR on this branch so the commit history is a bit off now.

mkhutornyi · 2024-03-11T22:14:12Z

@mkhutornyi I found that issue too and my PR will fix that

ok let's get that PR merged asap

mkhutornyi

@waterim please note all the reported bugs in this PR and make sure to cover them in next PR

melvin-bot · 2024-03-11T22:22:46Z

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

luacmartins · 2024-03-11T22:23:00Z

Tests were passing. Removing label.

OSBotify · 2024-03-11T22:29:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-12T18:50:18Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

lanitochka17 · 2024-03-12T22:16:10Z

This PR is failing because of issue #38188

The issue is reproducible in: All platforms

Bug6411610_1710280159625.20240313_054753.1.mp4

OSBotify · 2024-03-13T19:45:33Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.51-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allroundexperts · 2024-06-23T20:51:12Z

src/pages/workspace/tags/WorkspaceTagsPage.tsx

+                            color={theme.spinner}
+                        />
+                    )}
+                    {tagList.length === 0 && !isLoading && (


This line caused a bug later on. The deleted tags in offline mode had there state set as pending.

Ollyws · 2024-07-23T10:21:36Z

src/libs/actions/Policy.ts

@@ -2639,6 +2653,109 @@ function setWorkspaceRequiresCategory(policyID: string, requiresCategory: boolea
    API.write('SetWorkspaceRequiresCategory', parameters, onyxData);
 }

+function setPolicyRequiresTag(policyID: string, requiresTag: boolean) {


We were only supporting single level tags here (#43754) so we updated this to suport multi-level tags in #44937

initial settings

5fe99d5

luacmartins self-requested a review March 5, 2024 14:33

waterim added 3 commits March 5, 2024 15:40

fix lint

5d218e1

Merge remote-tracking branch 'upstream/main' into feat-37310-tag-sett…

489b4df

…ings

settings page update, new edit form

9de8694

rezkiy37 reviewed Mar 6, 2024

View reviewed changes

src/pages/workspace/tags/WorkspaceEditTagsPage.tsx Outdated Show resolved Hide resolved

fixes

b7d6673

waterim marked this pull request as ready for review March 6, 2024 17:45

waterim requested a review from a team as a code owner March 6, 2024 17:45

melvin-bot bot requested review from Pujan92 and removed request for a team March 6, 2024 17:45

luacmartins requested review from mkhutornyi and removed request for Pujan92 March 6, 2024 18:03

mkhutornyi suggested changes Mar 6, 2024

View reviewed changes

src/pages/workspace/tags/WorkspaceEditTagsPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/tags/WorkspaceEditTagsPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/tags/WorkspaceEditTagsPage.tsx Outdated Show resolved Hide resolved

waterim added 2 commits March 6, 2024 22:21

udpated

cd25554

Merge remote-tracking branch 'upstream/main' into feat-37310-tag-sett…

5ab9f8e

…ings

fix linter

1164897

waterim mentioned this pull request Mar 7, 2024

[HOLD for payment 2024-03-20] Tag - Newly added tags aren't displayed under the "Tags" section in workspace settings #37873

Closed

6 tasks

waterim added 2 commits March 7, 2024 15:57

fixes

aa61446

Merge remote-tracking branch 'upstream/main' into feat-37310-tag-sett…

941d1de

…ings

luacmartins requested changes Mar 7, 2024

View reviewed changes

luacmartins mentioned this pull request Mar 11, 2024

Fix crash on Tags page error #38096

Merged

49 tasks

mkhutornyi approved these changes Mar 11, 2024

View reviewed changes

melvin-bot bot requested a review from MonilBhavsar March 11, 2024 22:15

luacmartins approved these changes Mar 11, 2024

View reviewed changes

luacmartins merged commit abaf874 into Expensify:main Mar 11, 2024
17 of 20 checks passed

melvin-bot bot added the Emergency label Mar 11, 2024

luacmartins removed the Emergency label Mar 11, 2024

github-actions bot mentioned this pull request Mar 12, 2024

Deploy Checklist: New Expensify 2024-03-12 #38162

Closed

84 tasks

kbecciv mentioned this pull request Mar 12, 2024

Categories - Toggling on Categories/Tag does not actually enable Categories/Tag #38178

Closed

6 tasks

lanitochka17 mentioned this pull request Mar 12, 2024

[Simplified Collect][Tags] - "Members must tag all spend" switch is toggled back on after refreshing page #38188

Closed

6 tasks

luacmartins mentioned this pull request Mar 12, 2024

[Simplified Collect][Tags] Fix issues with Tags pages #38192

Closed

4 tasks

This was referenced Mar 13, 2024

[HOLD for payment 2024-03-20] [$500][Simplified Collect][Tags] Create WorkspaceTagsSettingsPage #37310

Closed

[HOLD for payment 2024-03-20] App loads chats on the left with tag list on the right when refreshing tag list #37848

Closed

allroundexperts reviewed Jun 23, 2024

View reviewed changes

allroundexperts mentioned this pull request Jun 23, 2024

[HOLD for payment 2024-06-13] [$250] Tags - When deleting all tags, blank UI is shown #42220

Closed

6 tasks

Ollyws reviewed Jul 23, 2024

View reviewed changes

Ollyws mentioned this pull request Jul 23, 2024

[HOLD for payment 2024-07-24] [$250] QBO - Tag status does not change when "Members must tag all expenses" is updated offline #43754

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create WorkspaceTagsSettingsPage #37755

Create WorkspaceTagsSettingsPage #37755

waterim commented Mar 5, 2024 •

edited

Loading

melvin-bot bot commented Mar 6, 2024

luacmartins commented Mar 6, 2024

mkhutornyi commented Mar 6, 2024

waterim commented Mar 6, 2024

mkhutornyi commented Mar 6, 2024 •

edited

Loading

mkhutornyi commented Mar 6, 2024

waterim commented Mar 7, 2024

mkhutornyi commented Mar 7, 2024

waterim commented Mar 7, 2024

luacmartins left a comment

luacmartins Mar 7, 2024

waterim Mar 8, 2024

luacmartins Mar 8, 2024

mkhutornyi Mar 11, 2024

luacmartins Mar 11, 2024

luacmartins Mar 11, 2024

luacmartins Mar 7, 2024

luacmartins Mar 7, 2024

waterim commented Mar 11, 2024 •

edited

Loading

mkhutornyi commented Mar 11, 2024

mkhutornyi commented Mar 11, 2024 •

edited

Loading

mkhutornyi commented Mar 11, 2024

mkhutornyi commented Mar 11, 2024

luacmartins commented Mar 11, 2024 •

edited

Loading

mkhutornyi commented Mar 11, 2024

mkhutornyi left a comment •

edited

Loading

melvin-bot bot commented Mar 11, 2024

luacmartins commented Mar 11, 2024

OSBotify commented Mar 11, 2024

OSBotify commented Mar 12, 2024

lanitochka17 commented Mar 12, 2024

OSBotify commented Mar 13, 2024

allroundexperts Jun 23, 2024

Ollyws Jul 23, 2024

		[newName]: {...oldPolicyTags, name: newName},
		[oldName]: null,

Create WorkspaceTagsSettingsPage #37755

Create WorkspaceTagsSettingsPage #37755

Conversation

waterim commented Mar 5, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 6, 2024

luacmartins commented Mar 6, 2024

mkhutornyi commented Mar 6, 2024

waterim commented Mar 6, 2024

mkhutornyi commented Mar 6, 2024 • edited Loading

mkhutornyi commented Mar 6, 2024

waterim commented Mar 7, 2024

mkhutornyi commented Mar 7, 2024

waterim commented Mar 7, 2024

luacmartins left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

waterim commented Mar 11, 2024 • edited Loading

mkhutornyi commented Mar 11, 2024

mkhutornyi commented Mar 11, 2024 • edited Loading

mkhutornyi commented Mar 11, 2024

Reviewer Checklist

Screenshots/Videos

mkhutornyi commented Mar 11, 2024

luacmartins commented Mar 11, 2024 • edited Loading

mkhutornyi commented Mar 11, 2024

mkhutornyi left a comment • edited Loading

Choose a reason for hiding this comment

melvin-bot bot commented Mar 11, 2024

luacmartins commented Mar 11, 2024

OSBotify commented Mar 11, 2024

OSBotify commented Mar 12, 2024

lanitochka17 commented Mar 12, 2024

OSBotify commented Mar 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

waterim commented Mar 5, 2024 •

edited

Loading

mkhutornyi commented Mar 6, 2024 •

edited

Loading

waterim commented Mar 11, 2024 •

edited

Loading

mkhutornyi commented Mar 11, 2024 •

edited

Loading

luacmartins commented Mar 11, 2024 •

edited

Loading

mkhutornyi left a comment •

edited

Loading