[HOLD for payment 2024-07-24] [$250] QBO - Tag status does not change when "Members must tag all expenses" is updated offline

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.83-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

• Workspace is connected to QBO.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Tags.
3. Click Settings.
4. Toggle on "Members must tag all expenses".
5. Close the RHP.
6. Note that "Classes" and "Customers/Projects" are labelled with "Required" when "Members must tag all expenses" is enabled and vice versa.
7. Go offline.
8. Click Settings.
9. Toggle off/on "Members must tag all expenses".

Expected Result:

In offline mode, "Classes" and "Customers/Projects" status will change when "Members must tag all expenses" is changed.

Actual Result:

In offline mode, "Classes" and "Customers/Projects" status do not change when "Members must tag all expenses" is changed. It only works online.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6512995_1718358660306.bandicam_2024-06-14_17-42-33-071.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011dbf2d7b0bb7331f
• Upwork Job ID: 1801613859295852710
• Last Price Increase: 2024-07-03
• Automatic offers:
• Krishna2323 | Contributor | 102994557

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@laurenreidexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011dbf2d7b0bb7331f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[mountiny]

Marking this as external and not a blocker, this is a rare flow and only offline case. Looking for proposals

[melvin-bot]

Upwork job price has been updated to $125

[Ollyws]

After discussion @Krishna2323's proposal LGTM.
🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @mountiny is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@Ollyws, PR ready for review ^

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: QBO - Tag status does not change when 'Members must tag all expenses' is updated offline. #44937

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment through NewDot Manual Requests
• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Ollyws]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR:

#37755

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/37755/files#r1687813353

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

• Determine if we should create a regression test for this bug.

Yes

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition: Workspace is connected to QBO.

1. Go offline.
2. Go to workspace settings > Tags.
3. Click Settings.
4. Toggle on "Members must tag all expenses".
5. Close the RHP.
6. Verify that "Classes" and "Customers/Projects" are labelled with "Required" when "Members must tag all expenses" is enabled and vice versa.

Do we agree 👍 or 👎

[mountiny]

Yeah I think we can add this regression test to QA

[Ollyws]

Requested in ND.

[JmillsExpensify]

@stephanieelliott can I get a payment summary when you get a chance?

[stephanieelliott]

Yep, here it is @JmillsExpensify!

Summarizing payment on this issue:

• Contributor: @Krishna2323 $250 via Upwork - Paid via Upwork
• Contributor+: @Ollyws $250 via ND - Requested in ND

Upwork job is here: https://www.upwork.com/jobs/~011dbf2d7b0bb7331f

[stephanieelliott]

Issue for QA test is here: https://github.com/Expensify/Expensify/issues/new

[JmillsExpensify]

$250 approved for @Ollyws