Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-20] [$500][Simplified Collect][Tags] Create WorkspaceTagsSettingsPage #37310

Closed
luacmartins opened this issue Feb 27, 2024 · 24 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 27, 2024

Implement this section of the Simplified Collect: Tags design doc

cc @waterim

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cae16f53fdebf109
  • Upwork Job ID: 1762500313151942656
  • Last Price Increase: 2024-02-27
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 27, 2024
@luacmartins luacmartins self-assigned this Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@luacmartins luacmartins changed the title [Simplified Collect][Tags] Create tags settings page [HOLD #37309][Simplified Collect][Tags] Create tags settings page Feb 27, 2024
@waterim
Copy link
Contributor

waterim commented Feb 27, 2024

Hello, Im Artem from Callstack

@luacmartins luacmartins changed the title [HOLD #37309][Simplified Collect][Tags] Create tags settings page [HOLD #37309][Simplified Collect][Tags] Create WorkspaceTagsSettingsPage Feb 27, 2024
@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01cae16f53fdebf109

@melvin-bot melvin-bot bot changed the title [HOLD #37309][Simplified Collect][Tags] Create WorkspaceTagsSettingsPage [$500] [HOLD #37309][Simplified Collect][Tags] Create WorkspaceTagsSettingsPage Feb 27, 2024
@luacmartins luacmartins added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Feb 27, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Current assignee @lschurr is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 27, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Feb 27, 2024
@Louisk3
Copy link

Louisk3 commented Feb 27, 2024

Hi, @luacmartins

Can I fix this issue?

@luacmartins
Copy link
Contributor Author

@Louisk3 thanks for the interest but we already assigned someone to the issue

@melvin-bot melvin-bot bot added the Overdue label Mar 1, 2024
@lschurr
Copy link
Contributor

lschurr commented Mar 1, 2024

Is this one on hold or actively being worked on @luacmartins @waterim?

@melvin-bot melvin-bot bot removed the Overdue label Mar 1, 2024
@waterim
Copy link
Contributor

waterim commented Mar 1, 2024

@lschurr hello! This one is on hold for a main page, main page PR will be in a few minutes, lets see if we can merge it soon.
Also I will create a PR for this issue as soon as first PR is merged!

@lschurr lschurr changed the title [$500] [HOLD #37309][Simplified Collect][Tags] Create WorkspaceTagsSettingsPage [HOLD #37309][$500][Simplified Collect][Tags] Create WorkspaceTagsSettingsPage Mar 1, 2024
@waterim
Copy link
Contributor

waterim commented Mar 4, 2024

Main page was merged, tomorrow will create a PR

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 6, 2024
@waterim
Copy link
Contributor

waterim commented Mar 6, 2024

PR is open!

@luacmartins luacmartins assigned mkhutornyi and unassigned Pujan92 Mar 6, 2024
Copy link

melvin-bot bot commented Mar 6, 2024

❌ There was an error making the offer to @mkhutornyi for the Contributor role. The BZ member will need to manually hire the contributor.

@luacmartins luacmartins changed the title [HOLD #37309][$500][Simplified Collect][Tags] Create WorkspaceTagsSettingsPage [$500][Simplified Collect][Tags] Create WorkspaceTagsSettingsPage Mar 7, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Mar 11, 2024
@luacmartins
Copy link
Contributor Author

PR was merged today

Copy link

melvin-bot bot commented Mar 12, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 13, 2024
@melvin-bot melvin-bot bot changed the title [$500][Simplified Collect][Tags] Create WorkspaceTagsSettingsPage [HOLD for payment 2024-03-20] [$500][Simplified Collect][Tags] Create WorkspaceTagsSettingsPage Mar 13, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 13, 2024
Copy link

melvin-bot bot commented Mar 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-20. 🎊

For reference, here are some details about the assignees on this issue:

  • @waterim does not require payment (Contractor)
  • @mkhutornyi requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Mar 13, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mkhutornyi] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@lschurr
Copy link
Contributor

lschurr commented Mar 19, 2024

@mkhutornyi - do we need a regression test for this one?

@luacmartins
Copy link
Contributor Author

Np! We'll add them when the feature is fully implemented.

@lschurr
Copy link
Contributor

lschurr commented Mar 20, 2024

Payment summary:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 20, 2024
Copy link

melvin-bot bot commented Mar 20, 2024

Payment Summary

Upwork Job

BugZero Checklist (@lschurr)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1762500313151942656/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@lschurr
Copy link
Contributor

lschurr commented Mar 20, 2024

All set!

@lschurr lschurr closed this as completed Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
Archived in project
Status: Release 2: From Setup > Export
Development

No branches or pull requests

6 participants