[Simplified Collect][Tags] Fix issues with Tags pages

[luacmartins]

We have a few known issues with the Workspace Tags Page that need to be addressed:

• Padding issues - PR
• Pages are still accessible via deeplink - PR
• Toggle reverts to previous state - PR
• New tags should be enabled by default - PR

cc @waterim @mkhutornyi

Issue Owner

Current Issue Owner: @luacmartins

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[luacmartins]

We're still working on this

[melvin-bot]

@luacmartins, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

Retesting

[luacmartins]

Fixed:

• Create WorkspaceTagsSettingsPage #37755 (comment)

Still reproducible:

• Create WorkspaceTagsSettingsPage #37755 (comment)
• [Simplified Collect][Tags] - "Members must tag all spend" switch is toggled back on after refreshing page #38188

@waterim could you please take a look at the reproducible issues above?

[waterim]

@luacmartins #37755 (comment) - this one is will be fixed here

[waterim]

@luacmartins Regarding this #38188 - looks like this is an issue with backend, because response is empty and requiresTag is not updating in policy

Request for SetWorkspaceRequiresCategory:

Request for SetPolicyRequiresTag:

Response for SetWorkspaceRequiresCategory:

Response for SetPolicyRequiresTag:

[luacmartins]

@waterim are we not optimistically setting requiresCategory to true when calling SetPolicyRequiresTag? I don't think we need the response to have data if we do that.

[waterim]

@luacmartins we set it, but after refresh policy will be the same as before switch toggle

[waterim]

Optimistically it works

[luacmartins]

but after refresh policy will be the same as before switch toggle

Why is that? When we refresh the page we should fetch the details for the policy and if the data was saved in the DB it should be the same as the optimistic data we have locally, no?

[waterim]

Thats what Im saying, as I understand policy requiresTag is not setting to DB

[luacmartins]

Ok, I'll investigate!

[waterim]

Thank you!

[luacmartins]

We have PRs up for all the issues listed here

[luacmartins]

PRs have been merged. Just waiting on the deploy

[luacmartins]

We're all good here. Closing.