[HOLD for payment 2024-03-22] [HOLD for payment 2024-03-20] [$500] Thread - Thread header shows "Unavailable workspace"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.51-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Send a message
4. Right click on the message > Reply in thread

Expected Result:

The thread header will not show "Unavailable workspace"

Actual Result:

The thread header shows "Unavailable workspace"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6411451_1710272160875.20240313_030619.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014ff42a92e62198ae
• Upwork Job ID: 1767656572824260608
• Last Price Increase: 2024-03-12

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

Production:

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[lanitochka17]

@srikarparsi FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread - Thread header shows "Unavailable workspace"

What is the root cause of that problem?

Regression from #37030.

We are using the !isDM function in the isWorkspaceThread function but the !isDM function now uses the !isThread function to decide whether a report is a workspace thread.

App/src/libs/ReportUtils.ts

Lines 1183 to 1185 in bca0505

	function isWorkspaceThread(report: OnyxEntry<Report>): boolean {
	return isThread(report) && isChatReport(report) && !isDM(report);
	}

What changes do you think we should make in order to solve the problem?

Just like how the isDM function was written before, in the isWorkspaceThread function, we should substitute the !isDM(report) function with !getChatType(report) or check if the root parent is a policy.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014ff42a92e62198ae

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

❌ There was an error making the offer to @Tony-MK for the Contributor role. The BZ member will need to manually hire the contributor.

[allgandalf]

@Tony-MK , you cross referenced to your own repository 😆 , please point the branch to the main expensify repo 😅

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix/38171 - [CP Staging] #38189

If no regressions arise, payment will be issued on 2024-03-20. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @Tony-MK requires payment (Needs manual offer from BZ)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix/38171 - [CP Staging] #38189

If no regressions arise, payment will be issued on 2024-03-22. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @Tony-MK requires payment (Needs manual offer from BZ)

[mananjadhav]

@luacmartins @srikarparsi Can we assign a BZ member here. We need to payout @Tony-MK.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[luacmartins]

@trjExpensify could you please help with payouts?

[mananjadhav]

Thanks. There will be a payout for @Tony-MK only. I didn't review the fix.

[trjExpensify]

Sure thing! @Tony-MK sent you an offer. Payment summary as follows:

• $500 to @Tony-MK for the fix.

[trjExpensify]

Still awaiting @Tony-MK's acceptance of the offer. Once paid, we can close this out.

[Tony-MK]

Accepted the offer, Thanks.

[trjExpensify]

Paid!