[Snyk] Security upgrade onfido-sdk-ui from 13.6.1 to 14.15.0 #37713

DylanDylann · 2024-03-05T06:49:45Z

Details

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
- package.json
- package-lock.json

Vulnerabilities that will be fixed
With an upgrade:

Severity	Priority Score (*)	Issue	Breaking Change	Exploit Maturity
	631/1000Why? Proof of Concept exploit, Has a fix available, CVSS 6.2	Missing Release of Resource after Effective LifetimeSNYK-JS-INFLIGHT-6095116	Yes	Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Check the changes in this PR to ensure they won't cause issues with your project.

Fixed Issues

$ #37076
PROPOSAL: NA

Tests

Ensure Onfido is not broken for the flows where we add a bank account

Verify that no errors appear in the JS console

Offline tests

QA Steps

Ensure Onfido is not broken for the flows where we add a bank account

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-05.at.23.51.30.mov

Android: mWeb Chrome

Screen.Recording.2024-03-05.at.23.40.09.mov

iOS: Native

Screen.Recording.2024-03-05.at.23.42.52.mov

iOS: mWeb Safari

Screen.Recording.2024-03-05.at.23.35.06.mov

MacOS: Chrome / Safari

ConnectBankAccount.mp4

MacOS: Desktop

Screen.Recording.2024-03-05.at.23.33.44.mov

melvin-bot · 2024-03-05T06:49:50Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-03-05T07:34:08Z

@marcochavezf Do we need another C+ contributor here?

DylanDylann · 2024-03-05T16:54:09Z

@marcochavezf The PR is ready for review

DylanDylann · 2024-03-05T17:08:59Z

Validate Github Actions also fails in other PR that change package.json file

marcochavezf · 2024-03-05T17:24:00Z

@marcochavezf Do we need another C+ contributor here?

Yeah, @fedirjh could you review this PR? The more 👀 the better

fedirjh

@DylanDylann Can you please include the changelog in the PR description?

It seems that useMemoryHistory has been deprecated as well.

src/pages/ReimbursementAccount/RequestorOnfidoStep.js

fedirjh · 2024-03-05T22:28:02Z

src/components/Onfido/BaseOnfidoWeb.js

-        onUserExit: (userExitCode) => {
-            Log.hmmm('Onfido user exits the flow', {userExitCode});
-            onUserExit(userExitCode);
-        },


onUserExit has been deprecated and the user_consent_denied type is now returned in the onError callback

We can probably move onUserExit(userExitCode); to the onError callback and check for the error type, if it's a user_consent_denied type then we trigger the onUserExit callback.

Thanks. I updated but I can't find any way to trigger onUserExit (old) and onError with user_consent_denied type

I updated but I can't find any way to trigger onUserExit (old) and onError with user_consent_denied type

Not sure how we can test this, but it may be only available in the production environment.

DylanDylann · 2024-03-08T02:57:03Z

@fedirjh Bump on this one

fedirjh · 2024-03-08T18:47:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

CleanShot.2024-03-11.at.13.10.30.mp4

Android: mWeb Chrome

CleanShot.2024-03-11.at.13.15.29.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-11.at.14.18.33.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-11.at.13.54.46.mp4

MacOS: Chrome / Safari

CleanShot.2024-03-11.at.11.20.09.mp4

MacOS: Desktop

CleanShot.2024-03-11.at.14.25.07.mp4

fedirjh

Looks good and test well. @DylanDylann Could you please merge main ?

src/components/Onfido/BaseOnfidoWeb.js

DylanDylann · 2024-03-11T16:19:14Z

@fedirjh All done

fedirjh · 2024-03-11T16:31:12Z

Over to you @marcochavezf

marcochavezf

LGTM, just a minor change

src/components/Onfido/BaseOnfidoWeb.js

DylanDylann · 2024-03-11T17:41:28Z

@marcochavezf Updated. Passed all tests

marcochavezf

Cool, thanks guys!

mkhutornyi · 2024-03-11T20:53:28Z

Looks like package-lock.json diff came from this PR

DylanDylann · 2024-03-12T03:05:37Z

@mkhutornyi Any problem with my change?

mkhutornyi · 2024-03-12T03:20:02Z

@mkhutornyi Any problem with my change?

After running npm locally on latest main, that difference comes

DylanDylann · 2024-03-12T03:31:21Z

I am not sure why I missed that while executing npm install. I created a new PR to remove that. Thanks for your reminder

cc @fedirjh @marcochavezf

VickyStash · 2024-03-12T08:31:21Z

@DylanDylann @fedirjh I've noticed some UI updates in Onfido functionality on the latest main. I guess it's caused by this PR. Is it something expected? Could you check it, please?

Black border
Blue back button and links color (especially if you hover over them).

OSBotify · 2024-03-12T18:50:12Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-13T19:45:27Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.51-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

VickyStash · 2024-03-14T07:39:02Z

@DylanDylann Have you had a chance to take a look at my comment?

DylanDylann · 2024-03-14T08:25:28Z

@VickyStash I don't see any problem with the link color (even though when hovering). Could you help to check again?

Screen.Recording.2024-03-14.at.15.24.09.mov

DylanDylann · 2024-03-14T08:50:24Z

About the Back button: It seems the default UI is changed in the new version and we are using the default back button (ref) and I don't see any way to change the UI of the back button (this is UI customization docs).

VickyStash · 2024-03-14T09:51:39Z

@DylanDylann Links look okay for me as well now, but I still see the black border

VickyStash · 2024-03-14T09:52:28Z

@DylanDylann oh, nvm, I saw your comment in my PR 👌

upgrade onfido-sdk-ui version

ae0c9ca

DylanDylann requested a review from a team as a code owner March 5, 2024 06:49

melvin-bot bot requested review from fedirjh and removed request for a team March 5, 2024 06:49

DylanDylann mentioned this pull request Mar 5, 2024

[Snyk] Security upgrade onfido-sdk-ui from 13.6.1 to 14.15.0 #37075

Closed

50 tasks

filip-solecki mentioned this pull request Mar 5, 2024

Upgrade react-native-reanimated to 3.7.2 #37679

Merged

50 tasks

marcochavezf self-requested a review March 5, 2024 17:02

marcochavezf assigned DylanDylann Mar 5, 2024

fedirjh suggested changes Mar 5, 2024

View reviewed changes

DylanDylann force-pushed the upgrade-onfido-sdk-ui branch from 5e523b2 to ae0c9ca Compare March 6, 2024 04:29

DylanDylann added 4 commits March 6, 2024 12:23

update logic

f2d73f4

merge main

8f7106d

re-run package-lock

92047e2

re-run package-lock

1b37702

fedirjh reviewed Mar 11, 2024

View reviewed changes

src/components/Onfido/BaseOnfidoWeb.js Outdated Show resolved Hide resolved

DylanDylann added 2 commits March 11, 2024 23:00

merge main

c319960

move logic

58d5d8c

fedirjh approved these changes Mar 11, 2024

View reviewed changes

marcochavezf requested changes Mar 11, 2024

View reviewed changes

src/components/Onfido/BaseOnfidoWeb.js Outdated Show resolved Hide resolved

marcochavezf mentioned this pull request Mar 11, 2024

[Pending Checklist] [Snyk] Security upgrade onfido-sdk-ui from 13.6.1 to 14.15.0 #37076

Closed

move log to above

21f4885

marcochavezf approved these changes Mar 11, 2024

View reviewed changes

marcochavezf merged commit 0f1570b into Expensify:main Mar 11, 2024
17 checks passed

mkhutornyi mentioned this pull request Mar 12, 2024

[No QA] fix patch warning #38109

Merged

60 tasks

VickyStash mentioned this pull request Mar 12, 2024

[TS migration] Migrate 'Onfido' component to TypeScript #31378

Merged

50 tasks

github-actions bot mentioned this pull request Mar 12, 2024

Deploy Checklist: New Expensify 2024-03-12 #38162

Closed

84 tasks

suneox mentioned this pull request Mar 18, 2024

[HOLD for payment 2024-05-09] [$500] mWeb/Safari - Onfido - Button to take photo is hidden #37622

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Snyk] Security upgrade onfido-sdk-ui from 13.6.1 to 14.15.0 #37713

[Snyk] Security upgrade onfido-sdk-ui from 13.6.1 to 14.15.0 #37713

DylanDylann commented Mar 5, 2024 •

edited

Loading

melvin-bot bot commented Mar 5, 2024

DylanDylann commented Mar 5, 2024

DylanDylann commented Mar 5, 2024

DylanDylann commented Mar 5, 2024

marcochavezf commented Mar 5, 2024

fedirjh left a comment

fedirjh Mar 5, 2024

DylanDylann Mar 6, 2024

fedirjh Mar 11, 2024

DylanDylann commented Mar 8, 2024

fedirjh commented Mar 8, 2024 •

edited

Loading

fedirjh left a comment

DylanDylann commented Mar 11, 2024

fedirjh commented Mar 11, 2024

marcochavezf left a comment

DylanDylann commented Mar 11, 2024

marcochavezf left a comment

mkhutornyi commented Mar 11, 2024

DylanDylann commented Mar 12, 2024 •

edited

Loading

mkhutornyi commented Mar 12, 2024

DylanDylann commented Mar 12, 2024

VickyStash commented Mar 12, 2024 •

edited

Loading

OSBotify commented Mar 12, 2024

OSBotify commented Mar 13, 2024

VickyStash commented Mar 14, 2024

DylanDylann commented Mar 14, 2024

DylanDylann commented Mar 14, 2024 •

edited

Loading

VickyStash commented Mar 14, 2024

VickyStash commented Mar 14, 2024

[Snyk] Security upgrade onfido-sdk-ui from 13.6.1 to 14.15.0 #37713

[Snyk] Security upgrade onfido-sdk-ui from 13.6.1 to 14.15.0 #37713

Conversation

DylanDylann commented Mar 5, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 5, 2024

DylanDylann commented Mar 5, 2024

DylanDylann commented Mar 5, 2024

DylanDylann commented Mar 5, 2024

marcochavezf commented Mar 5, 2024

fedirjh left a comment

Choose a reason for hiding this comment

fedirjh Mar 5, 2024

Choose a reason for hiding this comment

DylanDylann Mar 6, 2024

Choose a reason for hiding this comment

fedirjh Mar 11, 2024

Choose a reason for hiding this comment

DylanDylann commented Mar 8, 2024

fedirjh commented Mar 8, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

fedirjh left a comment

Choose a reason for hiding this comment

DylanDylann commented Mar 11, 2024

fedirjh commented Mar 11, 2024

marcochavezf left a comment

Choose a reason for hiding this comment

DylanDylann commented Mar 11, 2024

marcochavezf left a comment

Choose a reason for hiding this comment

mkhutornyi commented Mar 11, 2024

DylanDylann commented Mar 12, 2024 • edited Loading

mkhutornyi commented Mar 12, 2024

DylanDylann commented Mar 12, 2024

VickyStash commented Mar 12, 2024 • edited Loading

OSBotify commented Mar 12, 2024

OSBotify commented Mar 13, 2024

VickyStash commented Mar 14, 2024

DylanDylann commented Mar 14, 2024

DylanDylann commented Mar 14, 2024 • edited Loading

VickyStash commented Mar 14, 2024

VickyStash commented Mar 14, 2024

DylanDylann commented Mar 5, 2024 •

edited

Loading

fedirjh commented Mar 8, 2024 •

edited

Loading

DylanDylann commented Mar 12, 2024 •

edited

Loading

VickyStash commented Mar 12, 2024 •

edited

Loading

DylanDylann commented Mar 14, 2024 •

edited

Loading