-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll to bottom of report after create task #37868
Conversation
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-03-11.at.10.11.38.PM.movAndroid: mWeb ChromeScreen.Recording.2024-03-11.at.10.10.37.PM.moviOS: NativeScreen.Recording.2024-03-11.at.10.09.01.PM.moviOS: mWeb SafariScreen.Recording.2024-03-11.at.10.06.06.PM.movMacOS: Chrome / SafariScreen.Recording.2024-03-11.at.9.59.21.PM.movScreen.Recording.2024-03-11.at.10.00.38.PM.movMacOS: DesktopScreen.Recording.2024-03-11.at.10.05.06.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. @gijoe0295 Please note that I'm overlooking iOS screen recording (which is missing in your checklist) only this time since I've covered the iOS tests. In future, please make sure to upload screen recordings for all platforms.
@allroundexperts Sorry for the inconvenience! I've had issues with iOS simulator after upgrading to iOS 17.4 as many contributors already reported on Slack. Will try to resolve and update iOS screenshot ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.51-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.51-3 🚀
|
Details
This PR scrolls to bottom of report after create task.
Fixed Issues
$ #37647
PROPOSAL: #37647 (comment)
Tests
+
>> Assign taskShare somewhere
orAssignee
is the above reportOffline tests
NA
QA Steps
+
>> Assign taskShare somewhere
orAssignee
is the above reportPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-03-07.at.13.56.05-compressed.mov
Android: mWeb Chrome
Screen.Recording.2024-03-07.at.13.57.27-compressed.mov
iOS: Native
iOS: mWeb Safari
Screen.Recording.2024-03-07.at.15.09.49-compressed.mov
MacOS: Chrome / Safari
Screen.Recording.2024-03-07.at.13.45.50-compressed.mov
MacOS: Desktop
Screen.Recording.2024-03-07.at.13.45.50-compressed.mov