Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App download - Tab does not close after tapping "x" on download popup #38241

Closed
2 of 6 tasks
kbecciv opened this issue Mar 13, 2024 · 4 comments
Closed
2 of 6 tasks

App download - Tab does not close after tapping "x" on download popup #38241

kbecciv opened this issue Mar 13, 2024 · 4 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Mar 13, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.51-2
Reproducible in staging?: y
Reproducible in production?: y
Issue found when executing PR: #38032
Issue reported by: Applause - Internal Team

Action Performed:

  1. Access staging.new.expensify.com on Safari (PR asks for Safari) or on MAC Desktop app
  2. Sign into a valid account
  3. Go to Settings >> About >> App download links >> macOS
  4. Close the download prompt

Expected Result:

According to the PR, the new tab should close. The tab closes on mweb and on the iOS app

Actual Result:

The tab does not close after download prompt is closed on mac browser and on mac desktop app

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6412395_1710345051441.Tab_does_not_close_after_tapping_X_on_download_prompt_.mp4

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 13, 2024
Copy link

melvin-bot bot commented Mar 13, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@kbecciv
Copy link
Author

kbecciv commented Mar 13, 2024

@kadiealexander I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@ghost
Copy link

ghost commented Mar 13, 2024

That's not the case i.e. the new tab is closing for me.

Screen.Recording.2024-03-13.at.10.06.15.PM.mov

@kadiealexander
Copy link
Contributor

Yeah I can't repro this either, closing.

2024-03-14_17-32-38.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

2 participants