Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO QA] Update iOS AdHoc profiles to enable cplus device testing #38122

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Julesssss
Copy link
Contributor

@Julesssss Julesssss commented Mar 12, 2024

Details

iOS AdHoc builds are untestable for a member of our C+ team, this change helps with PR testing.

@dukenv0307 builds generated after this gets merged should let you install to your iPhone.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/377924

Tests

MAKE SURE I DIDN'T COMMIT THE UNSIGNED PROFILES (steps)

@Julesssss Julesssss self-assigned this Mar 12, 2024
@Julesssss Julesssss marked this pull request as ready for review March 12, 2024 10:20
@Julesssss Julesssss requested a review from a team as a code owner March 12, 2024 10:20
@melvin-bot melvin-bot bot requested review from situchan and removed request for a team March 12, 2024 10:20
@Expensify Expensify deleted a comment from melvin-bot bot Mar 12, 2024
@Julesssss Julesssss removed the request for review from situchan March 12, 2024 10:20
@Julesssss
Copy link
Contributor Author

We can ignore the checklists

@robertjchen robertjchen merged commit c039ff7 into main Mar 12, 2024
7 of 11 checks passed
@robertjchen robertjchen deleted the jules-updateAdHocProfiles branch March 12, 2024 10:40
@melvin-bot melvin-bot bot added the Emergency label Mar 12, 2024
Copy link

melvin-bot bot commented Mar 12, 2024

@robertjchen looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@robertjchen
Copy link
Contributor

not an emergency since no QA/testing checklist is required here

@Julesssss
Copy link
Contributor Author

builds generated after this gets merged should let you install to your iPhone.

Actually we need this to get deployed to staging and then prod, should just take a couple of days

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/robertjchen in version: 1.4.51-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.51-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants