[Situ is out until May] [HOLD for payment 2024-03-22] [HOLD for payment 2024-03-20] Chat - Emoji is not showing in chat

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.51-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Send an emoji

Expected Result:

The emoji shows up in chat

Actual Result:

The emoji is not showing up in chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6411450_1710272158894.20240313_030929.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@yuwenmemon FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[situchan]

Looks like #37559 caused regression. expensify-common version bump in that PR includes changes from Expensify/expensify-common#649 which should be only merged with #37814.

[yuwenmemon]

Hmmm thanks @situchan... do we know if there's an expensify-common version that will work?

[yuwenmemon]

Looks like that well pre-dates it - so if you're correct I think we should revert Expensify/expensify-common#649 and then update expensify-common in this repo and CP that.

[situchan]

Looks like that well pre-dates it - so if you're correct I think we should revert Expensify/expensify-common#649 and then update expensify-common in this repo and CP that.

Agree

[kbecciv]

@yuwenmemon @luacmartins
Emojis not displayed in task and IOU description also, I believe this might stem from the same underlying issue.
Let me know if we need a separate issue. Thanks

Bug6411481_1710273255531.video_2024-03-12_15-51-20.mp4

[luacmartins]

Agree with the revert of Expensify/expensify-common#649

[luacmartins]

This is fixed in staging

[luacmartins]

Adding bug label to process payment

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert expensify-common #649 from version used on App #38175

If no regressions arise, payment will be issued on 2024-03-20. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@yuwenmemon] The PR that introduced the bug has been identified. Link to the PR:
• [@yuwenmemon] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@yuwenmemon] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@yuwenmemon] Determine if we should create a regression test for this bug.
• [@yuwenmemon] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert expensify-common #649 from version used on App #38175

If no regressions arise, payment will be issued on 2024-03-22. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@yuwenmemon] The PR that introduced the bug has been identified. Link to the PR:
• [@yuwenmemon] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@yuwenmemon] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@yuwenmemon] Determine if we should create a regression test for this bug.
• [@yuwenmemon] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

Can someone confirm who we're paying and for what here? The PR linked here looks like a revert.

[situchan]

Me as reviewed that PR (along with finding the root cause) and was not involved in offending PR.

[trjExpensify]

Ah okay, cool. So payment summary as follows:

• $500 to @situchan for the C+ review

Sent you an offer!

[trjExpensify]

@situchan is out until May. I'm dropping this to weekly.

[situchan]

I am back. Can you please send new offer? Old one was expired.

[trjExpensify]

New offer sent.

[trjExpensify]

Situ paid, closing!