Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong back navigation transition animation in transfer balance page #37998

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Fix wrong back navigation transition animation in transfer balance page #37998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50aaeca
don't use fallback route
bernhardoj Mar 8, 2024
ddd23ba
Merge branch 'main' into fix/37982-transfer-balance-page-navigation
bernhardoj Mar 9, 2024
87f0056
don't use fallback route
bernhardoj Mar 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/actions/PaymentMethods.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ function saveWalletTransferMethodType(filterPaymentMethodType?: FilterMethodPaym

function dismissSuccessfulTransferBalancePage() {
Onyx.merge(ONYXKEYS.WALLET_TRANSFER, {shouldShowSuccess: false});
Navigation.goBack(ROUTES.SETTINGS_WALLET);
Navigation.goBack();
}

/**
Expand Down
2 changes: 0 additions & 2 deletions src/pages/settings/Wallet/TransferBalancePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,12 +156,10 @@ function TransferBalancePage({bankAccountList, fundList, userWallet, walletTrans
titleKey="notFound.pageNotFound"
subtitleKey="transferAmountPage.notHereSubTitle"
linkKey="transferAmountPage.goToWallet"
onLinkPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET)}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To cover the text button of the not found page case. The default props is Navigation.dismissModal

Screen.Recording.2024-03-09.at.01.43.41.mov

>
<HeaderWithBackButton
title={translate('common.transferBalance')}
shouldShowBackButton
onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET)}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default props is Navigation.goBack

/>
<View style={[styles.flexGrow1, styles.flexShrink1, styles.flexBasisAuto, styles.justifyContentCenter]}>
<CurrentWalletBalance balanceStyles={[styles.transferBalanceBalance]} />
Expand Down
Loading