Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] [TS migration] Migrate 'SettingsWallet' page to TypeScript #32003

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 37 comments
Closed

[$250] [TS migration] Migrate 'SettingsWallet' page to TypeScript #32003

melvin-bot bot opened this issue Nov 27, 2023 · 37 comments
Assignees
@Julesssss @kevinksullivan @situchan @tienifr
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023 •
edited by Julesssss
Loading

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/settings/Wallet/walletTransferPropTypes.js 2
src/pages/settings/Wallet/TransferBalancePage.js 29
src/pages/settings/Wallet/ReportVirtualCardFraudPage.js 20
src/pages/settings/Wallet/ReportCardLostPage.js 24
src/pages/settings/Wallet/ExpensifyCardPage.js 31
src/pages/settings/Wallet/DangerCardSection.js 6
src/pages/settings/Wallet/ChooseTransferAccountPage.js 18
src/pages/settings/Wallet/AddDebitCardPage.js 22
src/pages/settings/Wallet/ActivatePhysicalCardPage.js 28
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01af8e7bd679708d6c
  • Upwork Job ID: 1744724751731822592
  • Last Price Increase: 2024-01-09
  • Automatic offers:
    • situchan | Reviewer | 28092440
    • tienifr | Contributor | 28092442
Issue OwnerCurrent Issue Owner: @kevinksullivan
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Dec 21, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Dec 21, 2023
@mountiny mountiny added External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. labels Jan 9, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01af8e7bd679708d6c

@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'SettingsWallet' page to TypeScript [$500] [TS migration] Migrate 'SettingsWallet' page to TypeScript Jan 9, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Triggered auto assignment to @kevinksullivan (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed Monthly KSv2 labels Jan 9, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 9, 2024
@mountiny mountiny changed the title [$500] [TS migration] Migrate 'SettingsWallet' page to TypeScript [$250] [TS migration] Migrate 'SettingsWallet' page to TypeScript Jan 9, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Upwork job price has been updated to $250

@tienifr
Copy link
Contributor

tienifr commented Jan 9, 2024

Would love to work on it

@ishpaul777
Copy link
Contributor

I'd like to work on it.

@rayane-djouah
Copy link
Contributor

I would like to work on this

@yh-0218
Copy link
Contributor

yh-0218 commented Jan 9, 2024

I'd like to work on it.

@vadymbokatov
Copy link
Contributor

Hi I would like to work on this please.

@shahinyan11
Copy link

I would like to work on this

@ghost
Copy link

ghost commented Jan 9, 2024

Dibs

@Tony-MK
Copy link
Contributor

Tony-MK commented Jan 9, 2024

Can I work on this?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 12, 2024
@Julesssss
Copy link
Contributor

Still not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 15, 2024
@tienifr
Copy link
Contributor

tienifr commented Jan 18, 2024

MagicCodeInput is used in ActivatePhyscialCardPage and it has not been migrated to TS yet. Should we:

  1. Remove ActivatePhyscialCardPage from this issue; or
  2. Create another TS migration issue for MagicCodeInput and hold this one for that?

@melvin-bot melvin-bot bot removed the Overdue label Jan 18, 2024
@tienifr tienifr mentioned this issue Jan 18, 2024
Merged
50 tasks
@Julesssss
Copy link
Contributor

Hey @tienifr, here's how we've been handling these cases:

In order to proceed with the migration faster, we are now allowing the use of @ts-expect-error annotation to temporally suppress those errors and help you unblock your issues. The only requirements is that you MUST add the annotation with a comment explaining that it must be removed when the blocking issue is migrated

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 19, 2024
@tienifr
Copy link
Contributor

tienifr commented Jan 19, 2024

PR ready for review #34716.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Feb 12, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Feb 12, 2024

This issue has not been updated in over 15 days. @Julesssss, @kevinksullivan, @situchan, @tienifr eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@kevinksullivan
Copy link
Contributor

PRs still in review

@situchan
Copy link
Contributor

situchan commented Mar 6, 2024

PR was deployed to production on Feb 28

@tienifr
Copy link
Contributor

tienifr commented Mar 6, 2024

@kevinksullivan ^ we're ready for payment.

@tienifr
Copy link
Contributor

tienifr commented Mar 15, 2024

@kevinksullivan ^ quick bump here. We have Monthly label, I'm afraid that Melvin would never notify us so I think I need to inform you directly.

@situchan
Copy link
Contributor

@Julesssss, please remove the Reviewing label and bump to Daily as payment is due

@Julesssss Julesssss added Daily KSv2 and removed Reviewing Has a PR in review labels Mar 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 18, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Mar 18, 2024

@Julesssss, @kevinksullivan, @situchan, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Julesssss Julesssss removed the Monthly KSv2 label Mar 19, 2024
@kevinksullivan
Copy link
Contributor

All set

@melvin-bot melvin-bot bot removed the Overdue label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Julesssss Julesssss

@kevinksullivan kevinksullivan

@situchan situchan

@tienifr tienifr

Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration
Projects
No open projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests