-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Split Bill - Group members disappeared in a split bill when make second split bill in a row #37048
Conversation
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly remove the draft from failureData as mentioned here as well. It should fix other issue as well
@@ -1621,11 +1621,6 @@ function createSplitsAndOnyxData( | |||
key: `${ONYXKEYS.COLLECTION.TRANSACTION}${splitTransaction.transactionID}`, | |||
value: {pendingAction: null}, | |||
}, | |||
{ |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ready @abdulrahuman5196 , optimistic draft was removed from failure and success data, and added instead to optimistic data. |
@adriancova This comment isn't addressed yet. Could you kindly add this? |
Hi @abdulrahuman5196, yes sorry I see now which one you meant. Should be good now, let me know if there'd be anything pending from my side. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-02-24.at.12.11.10.AM.mp4Android: mWeb ChromeScreen.Recording.2024-02-24.at.12.16.32.AM.mp4iOS: NativeScreen.Recording.2024-02-24.at.12.05.10.AM.mp4iOS: mWeb SafariScreen.Recording.2024-02-24.at.12.07.13.AM.mp4MacOS: Chrome / SafariScreen.Recording.2024-02-23.at.11.57.11.PM.mp4MacOS: DesktopScreen.Recording.2024-02-24.at.12.01.57.AM.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @dangrous
🎀 👀 🎀
C+ Reviewed
Kindly run the workflows before approval since it needs a maintainer to run them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, I think this makes sense to me and workflows look good!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/dangrous in version: 1.4.44-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀
|
{ | ||
onyxMethod: Onyx.METHOD.MERGE, | ||
key: `${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${CONST.IOU.OPTIMISTIC_TRANSACTION_ID}`, | ||
value: null, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearing the draft here is executed too early; before the user finishes the split flow (before navigation) which resulted in UI briefly showing stale data
Coming from #52196
Details
Removing transaction draft merge to null on success and failure to prevent ui resetting while user is editing a new draft.
Fixed Issues
$ #33518
PROPOSAL: #33518 (comment)
Tests
Same as QA steps
Offline tests
Same as QA steps.
QA Steps
(Best way to reliably reproduce the issue is to throttle the network requests)
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
mweb.android.mov
iOS: Native
ios.mov
iOS: mWeb Safari
mweb.iphone.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov