Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Category - The first item in the Category list is not highlighted by default #37284

Closed
6 tasks done
kbecciv opened this issue Feb 27, 2024 · 10 comments
Closed
6 tasks done
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Feb 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.44-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com.
  2. Go to workspace chat.
  3. Click + > Request money > Manual.
  4. Proceed to confirmation page.
  5. Click Category.

Expected Result:

The first item in the Category list will be highlighted by default.

Actual Result:

The first item in the Category list is not highlighted by default.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393813_1709030713631.20240227_072704.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fb7332a3e3d77dfe
  • Upwork Job ID: 1762471845828468736
  • Last Price Increase: 2024-02-27
@kbecciv kbecciv added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor labels Feb 27, 2024
@melvin-bot melvin-bot bot changed the title Category - The first item in the Category list is not highlighted by default [$500] Category - The first item in the Category list is not highlighted by default Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01fb7332a3e3d77dfe

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 27, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Feb 27, 2024

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

@Krishna2323
Copy link
Contributor

I think we decided to not focus on any list item until arrow keys are pressed or we have search inputs.

@arosiclair
Copy link
Contributor

I think we decided to not focus on any list item until arrow keys are pressed or we have search inputs.

You have a link to where that was discussed?

@arosiclair
Copy link
Contributor

It seems like we just updated the Category picker to include a search field and now the search field is focused by default:

Prod Staging
Screenshot 2024-02-27 at 10 48 39 AM Screenshot 2024-02-27 at 10 50 00 AM

This seems fine to me

@arosiclair arosiclair removed the DeployBlockerCash This issue or pull request should block deployment label Feb 27, 2024
@arosiclair
Copy link
Contributor

Removed blocker label since this is low impact either way

@arosiclair
Copy link
Contributor

Since the Merchant selector and Chat participants selector also behave the same way, I'll close this as not a bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants