Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Category - Long category name pinned to the left margin and not has indented #37446

Closed
1 of 6 tasks
lanitochka17 opened this issue Feb 28, 2024 · 19 comments
Closed
1 of 6 tasks
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.44-11
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #37389

Action Performed:

Precondition:
The user is an employee of Collect workspace
The Collect workspace has a long category name

  1. Launch App
  2. navigate to Workspace chat
  3. Open the request money page
  4. Tap on "Show more" > Category and scroll to Long Category to check it
  5. Create a manual request and proceed to the confirmation page

Expected Result:

Long category names should be shown for the entire line.
The long one should be indented too after "levels" (in this case)

Actual Result:

Long category names are pinned to the left margin.
The long one doesn't have indented too after "levels" (in this case)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6395937_1709141208347.az_recorder_20240228_102814.mp4
Bug6395937_1709141208327!Screenshot_2024-02-28_at_10 33 10

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01467b731ab89b66e3
  • Upwork Job ID: 1762895812871376896
  • Last Price Increase: 2024-03-20
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor labels Feb 28, 2024
@melvin-bot melvin-bot bot changed the title Category - Long category name pinned to the left margin and not has indented [$500] Category - Long category name pinned to the left margin and not has indented Feb 28, 2024
Copy link

melvin-bot bot commented Feb 28, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01467b731ab89b66e3

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 28, 2024
Copy link

melvin-bot bot commented Feb 28, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 28, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 28, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 28, 2024

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave6
CC @greg-schroeder

@puneetlath
Copy link
Contributor

@neonbhai this is probably also a regression from your PR. I'm going to mark not a blocker, but let's definitely fix.

@puneetlath puneetlath removed the DeployBlockerCash This issue or pull request should block deployment label Feb 28, 2024
@ikevin127
Copy link
Contributor

Can't reproduce.

Screenshot 2024-02-29 at 11 51 34

@puneetlath puneetlath added Daily KSv2 and removed Hourly KSv2 labels Feb 29, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
Copy link

melvin-bot bot commented Mar 4, 2024

@AndrewGable, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

@AndrewGable
Copy link
Contributor

@lanitochka17 - Can you please re-test and see if you can reproduce?

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
Copy link

melvin-bot bot commented Mar 6, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Mar 6, 2024
Copy link

melvin-bot bot commented Mar 7, 2024

@AndrewGable, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

@lanitochka17
Copy link
Author

Issue is not reproducible

0-02-01-fc040062fb92701e3cd5b55d0e6af240cd7825243b759ac3a7cc747c1a50def1_d4b4b379d15addcd.mp4

@melvin-bot melvin-bot bot removed the Overdue label Mar 11, 2024
@kbecciv
Copy link

kbecciv commented Mar 13, 2024

The second part of the issue - The long one doesn't have indented too after "levels", is still reproducible. reopening the issue.

bandicam.2024-03-13.18-59-39-745.mp4

@kbecciv kbecciv reopened this Mar 13, 2024
Copy link

melvin-bot bot commented Mar 13, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Mar 15, 2024
Copy link

melvin-bot bot commented Mar 18, 2024

@AndrewGable, @alitoshmatov Huh... This is 4 days overdue. Who can take care of this?

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Copy link

melvin-bot bot commented Mar 20, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Mar 20, 2024

@AndrewGable, @alitoshmatov 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@AndrewGable
Copy link
Contributor

Can reproduce so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

7 participants