-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD #37199][$500] Remove members out of a workspace are not crossed out in offline mode #37109
Comments
Job added to Upwork: https://www.upwork.com/jobs/~016f83f55225363e92 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat ( |
Triggered auto assignment to @MitchExpensify ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @francoisl ( |
This comment was marked as resolved.
This comment was marked as resolved.
ProposalPlease re-state the problem that we are trying to solve in this issue.Offline removed members are not visible What is the root cause of that problem?App/src/components/SelectionList/BaseListItem.tsx Lines 58 to 66 in 437d75c
In #36403, they changed child of PressableWithFeedback from component ( What changes do you think we should make in order to solve the problem?Change wrapping order like this:
This is exactly the same root cause as #35702 (comment) |
Yeah good catch, tested locally and it works well. Feel free to submit a PR plese @mkhutornyi. |
📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Thanks. Raising PR shortly |
Looks like there's another regression happening on main. Caused by #37000 |
Do you see a way to fix that regression? If you do, that's great and let's fix it too, otherwise we can put a comment in the PR to fix it later. Not a huge deal since that PR is not on staging yet. |
#37000 was kind of huge refactor and I see that it's not straight forward fix. |
Works for me. |
I commented on offending line - https://github.com/Expensify/App/pull/37000/files#r1500067904 |
This is known #37074 (comment) and will be fixed when we update the remove functionality next |
Removing blocker label. I was gonna close the issue, but I see that we already have a PR up to fix it, so I'll let it go through. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
@francoisl based on #37235 (comment), should I continue my PR or will be handled while implementing the remove functionality in Simplified Collect? |
@mkhutornyi I've already addressed this issue in my PR regarding removing members on the members page (as stated in the mentioned comment): #37199 - it's still in draft state but it will be published tomorrow. |
@burczu I checked your PR but solution is same as mine. |
Ideally, can we fix this in |
let's find a universal solution. It is not good to tackle this problem case by case. |
Should we close seeing as this is going to be fixed here #37074 (comment) and we don't have a universal solution identified yet - What do you think @parasharrajat ? |
I think we can. |
Yeah - I'm working on this right now. Thanks for pointing this out. |
@MitchExpensify Could you please put this issue on HOLD for #37199 or close this it? |
done |
@MitchExpensify This issue is resolved. Please close it and its related job on upwork. I am unsure if any payment is pending or if the contributor was already paid.
|
Bump @MitchExpensify |
Thanks @parasharrajat, let's close. I don't think any payment is due as nothing was ever merged but please let me know if anyone disagrees |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.43-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @hoangzinh
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1708519808525439
Action Performed:
Expected Result:
Removed members should be strike out
Actual Result:
Notice that members are disappearing instead of crossed out.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Screen.Recording.2024-02-21.at.19.49.26.mov
Recording.2761.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: