Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Distance - EReceipt thumbnail is not clickable when distance request is edited offline #37344

Closed
6 tasks done
lanitochka17 opened this issue Feb 27, 2024 · 30 comments
Closed
6 tasks done
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.44-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Create a distance request
  4. Go to request details page
  5. Go offline
  6. Click Distance
  7. Add a waypoint and save it
  8. Click on the receipt thumbnail

Expected Result:

User will be able to open EReceipt when distance request is edited offline (production behavior)

Actual Result:

EReceipt thumbnail is not clickable when distance request is edited offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6394556_1709063187268.20240227_204810.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e647aab2a32331ae
  • Upwork Job ID: 1762569075317325824
  • Last Price Increase: 2024-02-27
  • Automatic offers:
    • paultsimura | Reviewer | 0
    • shubham1206agra | Reviewer | 0
    • aimane-chnaif | Contributor | 0
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor labels Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01e647aab2a32331ae

@melvin-bot melvin-bot bot changed the title Distance - EReceipt thumbnail is not clickable when distance request is edited offline [$500] Distance - EReceipt thumbnail is not clickable when distance request is edited offline Feb 27, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 27, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave5
CC @dylanexpensify

@paultsimura
Copy link
Contributor

It's caused by #34133.
@shubham1206agra could you please take a look? We should make the ConfirmedRoute clickable when using it here:

{showMapAsImage ? (
<ConfirmedRoute transaction={transaction} />
) : (

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Feb 27, 2024

This comment was marked as outdated.

1 similar comment
Copy link

melvin-bot bot commented Feb 27, 2024

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@shubham1206agra
Copy link
Contributor

@paultsimura This still comes under the regression period, as it was reported under that period. But if @thienlnam agrees, I would like @paultsimura to be a contributor here instead, as he has enough context about the issue and solution. And either @aimane-chnaif or I can be a C+ here instead.

@paultsimura
Copy link
Contributor

This still comes under the regression period, as it was reported under that period.

That's why I wanted to double-check because this issue's been open for quite a while already.
If it won't be fixed as a regression, I think it would be fair to go through a regular External process allowing Contributors to post proposals as usual.

@thienlnam
Copy link
Contributor

Since this comes directly from a PR and was opened within the time period, let's have that handled as a regression. We wouldn't issue payment for this so please handle it with @aimane-chnaif.

@paultsimura
Copy link
Contributor

Ok, unassigning myself 👍

@paultsimura paultsimura removed their assignment Mar 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 13, 2024
@aimane-chnaif
Copy link
Contributor

Waiting for @shubham1206agra to raise follow-up PR

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 13, 2024
Copy link

melvin-bot bot commented Mar 19, 2024

@thienlnam, @shubham1206agra, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

@thienlnam thienlnam added Weekly KSv2 and removed Daily KSv2 labels Mar 19, 2024
@melvin-bot melvin-bot bot removed the Overdue label Mar 19, 2024
@aimane-chnaif
Copy link
Contributor

Sorry I wanted to review PR but had to unassign as I'll be OOO from tomorrow

@aimane-chnaif aimane-chnaif removed their assignment Mar 20, 2024
@paultsimura
Copy link
Contributor

Can I be assigned back as a C+ here?

@thienlnam
Copy link
Contributor

Going to adjust to a monthly since this is not urgent

@melvin-bot melvin-bot bot removed the Overdue label Apr 16, 2024
@thienlnam thienlnam added Monthly KSv2 Overdue and removed Weekly KSv2 labels Apr 16, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 16, 2024
@melvin-bot melvin-bot bot added the Overdue label May 17, 2024
@thienlnam
Copy link
Contributor

This is an edge case and not a priority - going to just close it

@melvin-bot melvin-bot bot removed the Overdue label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants