Update MentionUserRenderer.js Issue 26016 #33539
Conversation
melvin-bot
bot
requested review from
youssef-lr
and removed request for
a team
|
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
This is new PR for issue #26016. I have filled the PR Author Checklist. |
|
This is still an issue for unknown emails or when typing the mention fully and then pressing space, i.e. not selecting it with tab. Screen.Recording.2023-12-28.at.13.27.01.mov |
|
@youssef-lr I could not reproduce the issue that you mentioned. |
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
Screen.Recording.2024-01-03.at.16.52.24.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2024-01-03.at.16.11.16.mov
iOS: mWeb Safari
Screen.Recording.2024-01-03.at.16.05.21.mov
MacOS: Chrome / Safari
Screen.Recording.2024-01-03.at.15.54.55.mov
MacOS: Desktop
Screen.Recording.2024-01-03.at.16.03.48.mov
|
🎯 @sobitneupane, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #33867. |
|
Kindly review and approve ASAP @youssef-lr @sobitneupane |
|
on it today |
|
Any updates? @sobitneupane @youssef-lr |
|
Sorry couldn't get to this, I'm on it shortly. |
|
Kindly check and review @sobitneupane @youssef-lr |
|
Hello , |
|
@sobitneupane to reproduce do not select the user, press space after typing the email when it contains an uppercase then send the comment Screen.Recording.2024-01-23.at.10.26.41.mov |
|
Or better, to highlight the issue, copy & paste this |
|
@nikhildewoolkar Can you please work on the issue. |
|
@sobitneupane @youssef-lr this reproducible bug isn't related to my problem statement. #26016 |
|
@nikhildewoolkar I don't think it is different from the original issue. We are supposed to handle all the cases related to the issue. If there are any blockers, please let us know. We can work together to solve the issue. |
I have checked all the things which @youssef-lr suggested with tests cases and example to recreate bug provided by @youssef-lr but it is working fine. adding video evidence below. Kindly @sobitneupane @youssef-lr check PR again and let me know. WhatsApp.Video.2024-02-03.at.14.07.15.1.1.mp4 |
|
To my surprise, I also could not reproduce the issue. Screen.Recording.2024-02-08.at.21.18.59.mov |
If its done lets merge this and close this issue @sobitneupane @youssef-lr |
|
This seems to have been fixed in another PR. I can't reproduce on staging. |
|
Check the conflicts in this file, it was fixed by this line |
kindly review pr |
|
@nikhildewoolkar I'm afraid we cannot merge this PR, we can't simply replace |
|
When we select from mentionautocomplete dropdown the it lowercases it. So why is it a problem here? @youssef-lr this is what exactly decided in proposal and we should not be overthinking on this issue which has been dragging from 2 months. so i am eager to take it over to finish line. Thank you 😄 @youssef-lr conflicts has been resolved and review it again. |
|
@sobitneupane @youssef-lr please review. |
|
@nikhildewoolkar I will kindly request your patience. A lot has changed recently. I will update soon |
|
@youssef-lr We still have the issue in staging where we don't show tooltip for mentions with caps. Screen.Recording.2024-02-12.at.19.59.17.movThe issue is because of the wrong accountID returned in We need to pass lowercase letter to get the correct accountID. So, only change required here is to
We are passing |
|
@nikhildewoolkar Can you please merge main. A lot has changed recently. This is what we have in main. Your PR doesn't reflect those changes. |
nikhildewoolkar
force-pushed
the
main
branch
from
6d103a6 to
39ac35a
Compare
|
@sobitneupane fixed the merge conflict |
|
@sobitneupane @nikhildewoolkar indeed it seems like we need the lowercase here to fix the tool tip issue. I think we should update this check here to turn the diff --git a/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.tsx b/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.tsx
index 8908350728..ad9cfb4e63 100644
--- a/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.tsx
+++ b/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.tsx
@@ -43,7 +43,7 @@ function MentionUserRenderer({style, tnode, TDefaultRenderer, currentUserPersona
navigationRoute = ROUTES.PROFILE.getRoute(htmlAttribAccountID);
} else if ('data' in tnode && !isEmptyObject(tnode.data)) {
// We need to remove the LTR unicode and leading @ from data as it is not part of the login
- displayNameOrLogin = tnode.data.replace(CONST.UNICODE.LTR, '').slice(1).toLowerCase();
+ displayNameOrLogin = tnode.data.replace(CONST.UNICODE.LTR, '').slice(1);
accountID = PersonalDetailsUtils.getAccountIDsByLogins([displayNameOrLogin])?.[0];
navigationRoute = ROUTES.DETAILS.getRoute(displayNameOrLogin);
diff --git a/src/libs/PersonalDetailsUtils.ts b/src/libs/PersonalDetailsUtils.ts
index a881dd4112..55aee10e61 100644
--- a/src/libs/PersonalDetailsUtils.ts
+++ b/src/libs/PersonalDetailsUtils.ts
@@ -64,7 +64,7 @@ function getPersonalDetailsByIDs(accountIDs: number[], currentUserAccountID: num
*/
function getAccountIDsByLogins(logins: string[]): number[] {
return logins.reduce<number[]>((foundAccountIDs, login) => {
- const currentDetail = personalDetails.find((detail) => detail?.login === login);
+ const currentDetail = personalDetails.find((detail) => detail?.login === login?.toLowerCase());
if (!currentDetail) {
// generate an account ID because in this case the detail is probably new, so we don't have a real accountID yet
foundAccountIDs.push(UserUtils.generateAccountID(login)); |
|
@youssef-lr Yup. We can do that. @nikhildewoolkar Can you please make the suggested changes. |
|
friendly bump @nikhildewoolkar! |
|
suggested changes done. check and review once. |
|
Thanks! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.44-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀
|
|
This issue has been resolved and still i didn't receive any upwork task link. Kindly share updates on this. |
Details
Fixed Issues
$#26016
Open the app
Open any report
Write '@' to trigger mentions
Select any one mention, make any letter of mention as capital and send
Hover on mention to observe that tooltip doesn't display the right display name and avatar
For same mention as step 4 or select different mention and capitalize all letters and send
Observe that now it is not displayed as mention
$
PROPOSAL:
#26016 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop