fix logic get document from native #35164

dukenv0307 · 2024-01-25T16:51:59Z

Details

Profile photo upload options are missing. Currently I can take a photo or choose one from the gallery

Fixed Issues

$ #32307
PROPOSAL: #32307 (comment)

Tests

Log in
Tap on your profile picture
Tap on your profile picture again
Tap on the "Upload photo" button
Verify that option 'Choose Document' will display
Tap on the 'Choose Document' button
Verify that it only shows images
Select any image
Verify the new image is updated

Verify that no errors appear in the JS console

Offline tests

QA Steps

Log in
Tap on your profile picture
Tap on your profile picture again
Tap on the "Upload photo" button
Verify that option 'Choose Document' will display
Tap on the 'Choose Document' button
Verify that it only shows images
Select any image
Verify the new image is updated

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-01-26T11:10:25Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-01-29T17:25:47Z

src/components/AttachmentPicker/index.native.js

-    copyTo: 'cachesDirectory',
+
+const getDocumentPickerOptions = (type) => {
+    if (type === CONST.ATTACHMENT_PICKER_TYPE.IMAGE) {


@dukenv0307 We only return image if type is IMAGE

@DylanDylann i just updated code, please check again

DylanDylann · 2024-01-29T17:26:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

sa.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-23.at.16.17.42.mov

MacOS: Desktop

desk.mov

DylanDylann · 2024-01-30T07:24:16Z

@dukenv0307 Please ping me after all errors is resolved

dukenv0307 · 2024-01-31T04:55:09Z

@DylanDylann please check again

DylanDylann · 2024-01-31T04:55:40Z

@dukenv0307 Please update more step test to make sure that user only can select image for profile picture

DylanDylann · 2024-01-31T05:10:49Z

@dukenv0307 Because we only allow the user to upload an image, I think we should update the title "Choose document" to "Choose image"

cc @srikarparsi @Expensify/design

shawnborton · 2024-01-31T13:49:53Z

Well in that case, wouldn't we just remove that row completely? Because right above "Choose from gallery" essentially let's them choose an image.

DylanDylann · 2024-01-31T13:57:51Z

@shawnborton It seems It is different

Choose from gallerry: Images from Photos App
Choose document: Images from file system, cloud, ...

dannymcclain · 2024-01-31T14:04:12Z

Would it make sense for the options to instead be:

Take photo
Choose from gallery
Upload photo (or "Upload image")

For some reason it's bothering/confusing me that there's a "choose from gallery" option AND a "choose file/photo/whatever" option. I feel like we can make these more distinct. And for the 3rd option, aren't they essentially choosing an image file to upload?

DylanDylann · 2024-01-31T14:09:05Z

The difference between option 2 and option 3 is that we will get the image
Option 2

Option 3

shawnborton · 2024-01-31T14:11:15Z

I was responding to this comment here:

Because we only allow the user to upload an image

I thought you were saying that we were going to eliminate the ability to use the document finder for the avatar upload flow. Can you clarify what the behavior is here?

DylanDylann · 2024-01-31T14:14:53Z

We will enable the ability to use the document finder for the avatar upload flow. But we will filter images from document finder and only display it

shawnborton · 2024-01-31T14:18:11Z

Then maybe we just do nothing here? That would be my vote.

DylanDylann

The change looks good

srikarparsi · 2024-02-01T23:04:01Z

Hey @dukenv0307 / @DylanDylann could you please upload screenshots of the whole flow on iOS and android whenever you get a chance - including selecting a picture from documents?

DylanDylann · 2024-02-05T15:13:39Z

@dukenv0307 Currently, after clicking choose document and selecting a image, the width and height of this image always be undefined --> upload fail. Please take a look at this bug

DylanDylann · 2024-02-15T03:14:51Z

@dukenv0307 Any update here?

dukenv0307 · 2024-02-16T02:40:31Z

@DylanDylann i'm working on this issue

DylanDylann · 2024-02-20T04:33:42Z

@dukenv0307 How about this problem ?

dukenv0307 · 2024-02-23T02:22:21Z

@DylanDylann I'll update today

dukenv0307 · 2024-02-23T08:10:08Z

add.mov

@DylanDylann i just update the code, please check again.

DylanDylann · 2024-02-23T08:53:33Z

@dukenv0307 For the image from the document, we will add width and height from the path to the image object. It sounds good to me. Please upload all videos again

DylanDylann · 2024-02-23T09:19:08Z

@dukenv0307 Also please add the test step:
8. Select any image
9. Verify the new image is updated

dukenv0307 · 2024-02-23T14:19:20Z

@DylanDylann i just updated all videos screen shot and add more steps
Please check again.

DylanDylann · 2024-02-23T14:51:19Z

@srikarparsi Everything is updated. Please check again, thanks

srikarparsi

lgtm as well

OSBotify · 2024-02-26T21:05:08Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:53:44Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat · 2024-03-06T22:25:41Z

Note: This PR caused a regression #37240

fix logic get document from native

85f2c65

dukenv0307 marked this pull request as ready for review January 26, 2024 11:10

dukenv0307 requested a review from a team as a code owner January 26, 2024 11:10

melvin-bot bot requested review from Santhosh-Sellavel and removed request for a team January 26, 2024 11:10

Santhosh-Sellavel mentioned this pull request Jan 27, 2024

[$500] iOS - Profile - Photo upload options are missing #32307

Closed

6 tasks

This comment was marked as off-topic.

Sign in to view

DylanDylann reviewed Jan 29, 2024

View reviewed changes

fix logic get document picker

e46c3d2

Merge branch 'main' into fix/32307

5c54825

dukenv0307 mentioned this pull request Feb 1, 2024

[HOLD for payment 2024-02-26] [$500] [MEDIUM] [Backwards Compatibility] Expense with category can be created when admin disable the same category #35236

Closed

6 tasks

DylanDylann approved these changes Feb 1, 2024

View reviewed changes

melvin-bot bot requested a review from srikarparsi February 1, 2024 08:10

Merge branch 'main' into fix/32307

62ae576

Merge branch 'main' into fix/32307

b9a957a

dukenv0307 force-pushed the fix/32307 branch from 47e6e2c to b9a957a Compare February 16, 2024 08:28

Merge branch 'main' into fix/32307

20248f1

dukenv0307 added 2 commits February 23, 2024 14:34

Merge branch 'main' into fix/32307

06b8688

fix: add height and width to attachment

f409821

srikarparsi approved these changes Feb 24, 2024

View reviewed changes

srikarparsi merged commit e9fb49d into Expensify:main Feb 24, 2024
17 checks passed

This was referenced Feb 24, 2024

Investigate workflow job failing on main: typecheck / typecheck #37166

Closed

Investigate workflow job failing on main: confirmPassingBuild #37167

Closed

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

bernhardoj mentioned this pull request Feb 27, 2024

[HOLD for payment 2024-03-07] [HOLD for payment 2024-03-06] [$500] Android - Chat - Unable to upload pdf file #37240

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix logic get document from native #35164

fix logic get document from native #35164

dukenv0307 commented Jan 25, 2024 •

edited

Loading

melvin-bot bot commented Jan 26, 2024

This comment was marked as off-topic.

DylanDylann Jan 29, 2024

dukenv0307 Jan 30, 2024

DylanDylann commented Jan 29, 2024 •

edited

Loading

DylanDylann commented Jan 30, 2024

dukenv0307 commented Jan 31, 2024

DylanDylann commented Jan 31, 2024

DylanDylann commented Jan 31, 2024 •

edited

Loading

shawnborton commented Jan 31, 2024

DylanDylann commented Jan 31, 2024

dannymcclain commented Jan 31, 2024

DylanDylann commented Jan 31, 2024 •

edited

Loading

shawnborton commented Jan 31, 2024

DylanDylann commented Jan 31, 2024

shawnborton commented Jan 31, 2024

DylanDylann left a comment

srikarparsi commented Feb 1, 2024

DylanDylann commented Feb 5, 2024 •

edited

Loading

DylanDylann commented Feb 15, 2024

dukenv0307 commented Feb 16, 2024 •

edited

Loading

DylanDylann commented Feb 20, 2024

dukenv0307 commented Feb 23, 2024

dukenv0307 commented Feb 23, 2024

DylanDylann commented Feb 23, 2024 •

edited

Loading

DylanDylann commented Feb 23, 2024

dukenv0307 commented Feb 23, 2024

DylanDylann commented Feb 23, 2024

srikarparsi left a comment

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

parasharrajat commented Mar 6, 2024

fix logic get document from native #35164

fix logic get document from native #35164

Conversation

dukenv0307 commented Jan 25, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 26, 2024

This comment was marked as off-topic.

DylanDylann Jan 29, 2024

Choose a reason for hiding this comment

dukenv0307 Jan 30, 2024

Choose a reason for hiding this comment

DylanDylann commented Jan 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Jan 30, 2024

dukenv0307 commented Jan 31, 2024

DylanDylann commented Jan 31, 2024

DylanDylann commented Jan 31, 2024 • edited Loading

shawnborton commented Jan 31, 2024

DylanDylann commented Jan 31, 2024

dannymcclain commented Jan 31, 2024

DylanDylann commented Jan 31, 2024 • edited Loading

shawnborton commented Jan 31, 2024

DylanDylann commented Jan 31, 2024

shawnborton commented Jan 31, 2024

DylanDylann left a comment

Choose a reason for hiding this comment

srikarparsi commented Feb 1, 2024

DylanDylann commented Feb 5, 2024 • edited Loading

DylanDylann commented Feb 15, 2024

dukenv0307 commented Feb 16, 2024 • edited Loading

DylanDylann commented Feb 20, 2024

dukenv0307 commented Feb 23, 2024

dukenv0307 commented Feb 23, 2024

DylanDylann commented Feb 23, 2024 • edited Loading

DylanDylann commented Feb 23, 2024

dukenv0307 commented Feb 23, 2024

DylanDylann commented Feb 23, 2024

srikarparsi left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

parasharrajat commented Mar 6, 2024

dukenv0307 commented Jan 25, 2024 •

edited

Loading

DylanDylann commented Jan 29, 2024 •

edited

Loading

DylanDylann commented Jan 31, 2024 •

edited

Loading

DylanDylann commented Jan 31, 2024 •

edited

Loading

DylanDylann commented Feb 5, 2024 •

edited

Loading

dukenv0307 commented Feb 16, 2024 •

edited

Loading

DylanDylann commented Feb 23, 2024 •

edited

Loading