Fix(35835) #36300

jeremy-croff · 2024-02-11T01:16:36Z

Details

Fixed Issues

$ #35835
PROPOSAL: #35835 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

Let's delete the last message while offline

in a report
have a list of messages
Edit the last message and wipe it, then confirm
Go through the deletion modal
Ensure the scroll position is at the bottom, even if it failed to delete.

QA Steps

IOS Native tests:

open a report
Send a lot of messages! Get a scrollbar.
Edit the last message. ( make sure you use the phone's keyboard on an emulator ), and clear it.
Confirm the deletion in the modal
Ensure after deletion, the scroll is still at the bottom!

Touch screen tests ( devices with keyboard):

In a report
Edit a message
Confirm existing behavior that the input composer is hidden. Replaced with an edit composer.
Dismiss the edit ( x, or green checkmark to confirm )
Notice no regression and that composer immediately shows. ( existing behavior but implemented in a different way this time )

Other device tests

in a report
edit a message
confirm no strange behavior on the composer
after done editing, confirm focus back on the composer and no strange behavior

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

2024-02-16_21-10-07.mp4

Android: mWeb Chrome

2024-02-15_19-45-09.mp4

iOS: Native

IOS.Native.mp4

iOS: mWeb Safari

IOS.Web.mp4

MacOS: Chrome / Safari

Web.mp4

MacOS: Desktop

Electron.mp4

melvin-bot · 2024-02-14T13:12:09Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jeremy-croff · 2024-02-16T02:03:43Z

Ready for reviewing @allroundexperts 🙏

allroundexperts · 2024-02-17T02:15:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-17.at.7.40.12.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-02-17.at.7.39.17.AM.mov

iOS: Native

Screen.Recording.2024-02-17.at.7.38.33.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-02-17.at.7.37.52.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-17.at.7.35.37.AM.mov

MacOS: Desktop

Screen.Recording.2024-02-17.at.7.36.22.AM.mov

allroundexperts · 2024-02-17T02:44:56Z

@jeremy-croff I think you uploaded an incorrect screen recording for Android. Can you please check?

allroundexperts · 2024-02-17T02:45:45Z

src/libs/setShouldShowComposeInputKeyboardAware/index.ios.ts

-// On iOS, there is a visible delay in displaying input after the keyboard has been closed with the `keyboardDidHide` event
-// Because of that - on iOS we can use `keyboardWillHide` that is not available on android


Why are you removing this comment?

Oh, I see the reason now. NVM my comment.

allroundexperts · 2024-02-17T02:49:23Z

src/pages/home/report/ReportActionItemMessageEdit.tsx

+    // show the composer quickly after done editing for devices that hide the composer during editing.
+    useEffect(() => () => ComposerActions.setShouldShowComposeInput(true), []);
+


Shouldn't this be called for iOS only?

I did consider this as well at first
But In this same file, we call this effect in another flow without having any exclusions for the device. And because it's a keyboard-aware effect, it only impacts Native experiences inherently.

Lastly - I confirmed this change improves Android composer show time as well. The original solution was only solving for IOS.

jeremy-croff · 2024-02-17T03:16:12Z

@jeremy-croff I think you uploaded an incorrect screen recording for Android. Can you please check?

Updated.. thanks for catching it.

jeremy-croff · 2024-02-17T03:17:24Z

Addressed all comments, thanks.

allroundexperts

Looks good!

NikkiWines

one minor comment

src/pages/home/report/ReportActionItemMessageEdit.tsx

jeremy-croff · 2024-02-21T02:50:17Z

one minor comment

Thank you, @NikkiWines, for your revision.

jeremy-croff · 2024-02-21T04:08:45Z

Unfortunately I had to rebase to sign the commits.

I took a screenshot of the changed that were previously approved to confirm nothing changed.

NikkiWines

thanks for updating. tested and works well

OSBotify · 2024-02-26T21:06:41Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:55:17Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jeremy-croff marked this pull request as ready for review February 14, 2024 13:12

jeremy-croff requested a review from a team as a code owner February 14, 2024 13:12

melvin-bot bot requested review from allroundexperts and removed request for a team February 14, 2024 13:12

allroundexperts reviewed Feb 17, 2024

View reviewed changes

allroundexperts approved these changes Feb 20, 2024

View reviewed changes

melvin-bot bot requested a review from NikkiWines February 20, 2024 03:54

NikkiWines requested changes Feb 21, 2024

View reviewed changes

src/pages/home/report/ReportActionItemMessageEdit.tsx Outdated Show resolved Hide resolved

jeremy-croff added 2 commits February 20, 2024 22:02

fix(35835): composer timing render updates

806e07f

fix(35835): rebase with signed commits. Updated comments.

28f9afd

jeremy-croff force-pushed the fix(35835) branch from 6560694 to 28f9afd Compare February 21, 2024 04:06

NikkiWines approved these changes Feb 21, 2024

View reviewed changes

NikkiWines merged commit c1e73ec into Expensify:main Feb 21, 2024
15 checks passed

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix(35835) #36300

Fix(35835) #36300

jeremy-croff commented Feb 11, 2024 •

edited

Loading

melvin-bot bot commented Feb 14, 2024

jeremy-croff commented Feb 16, 2024

allroundexperts commented Feb 17, 2024 •

edited

Loading

allroundexperts commented Feb 17, 2024

allroundexperts Feb 17, 2024

allroundexperts Feb 17, 2024

allroundexperts Feb 17, 2024

jeremy-croff Feb 17, 2024 •

edited

Loading

jeremy-croff commented Feb 17, 2024

jeremy-croff commented Feb 17, 2024

allroundexperts left a comment

NikkiWines left a comment

jeremy-croff commented Feb 21, 2024

jeremy-croff commented Feb 21, 2024

NikkiWines left a comment

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

		// On iOS, there is a visible delay in displaying input after the keyboard has been closed with the `keyboardDidHide` event
		// Because of that - on iOS we can use `keyboardWillHide` that is not available on android

		// show the composer quickly after done editing for devices that hide the composer during editing.
		useEffect(() => () => ComposerActions.setShouldShowComposeInput(true), []);

Fix(35835) #36300

Fix(35835) #36300

Conversation

jeremy-croff commented Feb 11, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 14, 2024

jeremy-croff commented Feb 16, 2024

allroundexperts commented Feb 17, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Feb 17, 2024

allroundexperts Feb 17, 2024

Choose a reason for hiding this comment

allroundexperts Feb 17, 2024

Choose a reason for hiding this comment

allroundexperts Feb 17, 2024

Choose a reason for hiding this comment

jeremy-croff Feb 17, 2024 • edited Loading

Choose a reason for hiding this comment

jeremy-croff commented Feb 17, 2024

jeremy-croff commented Feb 17, 2024

allroundexperts left a comment

Choose a reason for hiding this comment

NikkiWines left a comment

Choose a reason for hiding this comment

jeremy-croff commented Feb 21, 2024

jeremy-croff commented Feb 21, 2024

NikkiWines left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

jeremy-croff commented Feb 11, 2024 •

edited

Loading

allroundexperts commented Feb 17, 2024 •

edited

Loading

jeremy-croff Feb 17, 2024 •

edited

Loading