Fix: disabled tag is not displayed in the list as selected #36994

dukenv0307 · 2024-02-21T05:18:47Z

Details

Fixed Issues

$ #35909
PROPOSAL: #35909 (comment)

Tests

Precondition: Employee made an IOU request with a tag in WS chat. Tag is disabled after that by WS admin in OD.

Employee in ND: click on IOU request to open request details.
Click on the tag field
Verify that: The disabled tag is displayed in the list as selected

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition: Employee made an IOU request with a tag in WS chat. Tag is disabled after that by WS admin in OD.

Employee in ND: click on IOU request to open request details.
Click on the tag field
Verify that: The disabled tag is displayed in the list as selected

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-02-21T06:58:33Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-02-21T08:30:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-21.at.15.21.35-compressed.mov

Android: mWeb Chrome

tag-chro.mp4

iOS: Native

Screen.Recording.2024-02-21.at.15.19.17-compressed.mov

iOS: mWeb Safari

tag-saf.mp4

MacOS: Chrome / Safari

tag-web.mp4

MacOS: Desktop

tag-desk.mp4

DylanDylann

LGTM

cead22 · 2024-02-21T19:11:44Z

I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)

@dukenv0307 @DylanDylann can you link to the issue or slack convo about the console errors? I asked if we have a running list of these here because it seems like we've accumulated some console errors and warnings

cead22 · 2024-02-21T19:57:42Z

src/libs/OptionsListUtils.ts

-        });
+        const selectedTagOptions = selectedOptions.map((option) => ({
+            name: option.name,
+            enabled: true,


Sorry if I'm missing something obvious, but why this change?

This PR will make the selected tag display even if it is disabled. So we also need to allow the user to unselect the tag in this case by passing enabled: true

That makes sense. Please add a comment above this line explaining that

I just added comment, @DylanDylann please check again

DylanDylann · 2024-02-22T07:34:29Z

It seems we also need to confirm whether we want to display selected in the first position. Asking here

DylanDylann · 2024-02-22T07:53:01Z

@cead22

@dukenv0307 @DylanDylann can you link to the issue or slack convo about the console errors? I asked if we have a running list of these here because it seems like we've accumulated some console errors and warnings

Thanks for your remainder. Currently, we get this console error when editing category or tag

This console error happens on EditRequestPage and we have a plan to remove this file #29107. Do we need to create an issue for it anymore?

A similar console error is created here but the GH issue is closed because we can't reproduce it anymore.

DylanDylann · 2024-02-22T13:32:38Z

@dukenv0307 It seems we need to update our PR as expected here. But let's wait design team to make a final decision

cead22 · 2024-02-22T16:42:33Z

This console error happens on EditRequestPage and we have a plan to remove this file #29107. Do we need to create an issue for it anymore?

No, that's fine, thanks for pointing it out, as well as the other issue

cead22 · 2024-02-22T16:45:17Z

@dukenv0307 It seems we need to update our PR as expected here. But let's wait design team to make a final decision

@dukenv0307 what do you mean specifically, moving the selected item to the top if there's more than 9 on the list? Won't that happen as part of that issue you linked? I'll add the design label just in case, since I thought it could be a good idea to make the selected (and disabled) tag, look disabled

DylanDylann · 2024-02-22T17:45:33Z

@cead22

since I thought it could be a good idea to make the selected (and disabled) tag, look disabled

Do you mean that we shouldn't allow the user to unselect the selected tag (and disabled)? (this is the same issue with category)

IMO, I think we still allow the user to unselect the selected tag (and disabled). The only issue that needs confirmation is the position of the selected tag and we are discussing here

If you agree, I think we don't need to add Design Label here

cead22 · 2024-02-22T20:06:35Z

I agree with you, I was only suggesting we make it look disabled, but we allow users to deselect them. I'm happy with the way things look. If design has any suggestions, they can add them here

cead22 · 2024-02-22T20:07:21Z

src/libs/OptionsListUtils.ts

-        });
+        const selectedTagOptions = selectedOptions.map((option) => ({
+            name: option.name,
+            enabled: true,


That makes sense. Please add a comment above this line explaining that

DylanDylann · 2024-02-23T02:44:08Z

Confirmed here. @dukenv0307 Please update our PR as this confirmation

DylanDylann · 2024-02-23T16:43:56Z

There are some new updates here, @dukenv0307 Let's wait until we decide on the final expectation

cead22 · 2024-02-23T16:49:41Z

@DylanDylann I think we tackle that separately and limit the scope of this PR to displaying the selected disabled tag

DylanDylann · 2024-02-23T16:52:51Z

@cead22 If that, this PR is ready to merge. Then if we change the expectation about the position of the selected tag, we will update all in here #36912

OSBotify · 2024-02-23T17:04:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-26T21:10:14Z

🚀 Deployed to staging by https://github.com/cead22 in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:58:50Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 added 2 commits February 21, 2024 11:25

fix: disabled tag is not displayed in the list as selected

1cab9fd

filter enabled tag

cb3206f

dukenv0307 marked this pull request as ready for review February 21, 2024 06:58

dukenv0307 requested a review from a team as a code owner February 21, 2024 06:58

melvin-bot bot removed the request for review from a team February 21, 2024 06:58

melvin-bot bot requested a review from DylanDylann February 21, 2024 06:58

DylanDylann approved these changes Feb 21, 2024

View reviewed changes

melvin-bot bot requested a review from cead22 February 21, 2024 08:36

cead22 reviewed Feb 21, 2024

View reviewed changes

cead22 added the Design label Feb 22, 2024

cead22 requested changes Feb 22, 2024

View reviewed changes

Add comment

325419b

cead22 approved these changes Feb 23, 2024

View reviewed changes

cead22 merged commit acbfffe into Expensify:main Feb 23, 2024
16 checks passed

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

mallenexpensify mentioned this pull request Mar 1, 2024

[Pay 2024-03-06][$500] [CRITICAL] Backwards Compatibility: Disabled tag is not displayed in the list as selected #35909

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: disabled tag is not displayed in the list as selected #36994

Fix: disabled tag is not displayed in the list as selected #36994

dukenv0307 commented Feb 21, 2024

melvin-bot bot commented Feb 21, 2024

DylanDylann commented Feb 21, 2024 •

edited

Loading

DylanDylann left a comment

cead22 commented Feb 21, 2024

cead22 Feb 21, 2024

DylanDylann Feb 22, 2024

cead22 Feb 22, 2024

dukenv0307 Feb 23, 2024

DylanDylann commented Feb 22, 2024

DylanDylann commented Feb 22, 2024 •

edited

Loading

DylanDylann commented Feb 22, 2024 •

edited

Loading

cead22 commented Feb 22, 2024

cead22 commented Feb 22, 2024

DylanDylann commented Feb 22, 2024 •

edited

Loading

cead22 commented Feb 22, 2024

cead22 Feb 22, 2024

DylanDylann commented Feb 23, 2024

DylanDylann commented Feb 23, 2024

cead22 commented Feb 23, 2024

DylanDylann commented Feb 23, 2024

OSBotify commented Feb 23, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

Fix: disabled tag is not displayed in the list as selected #36994

Fix: disabled tag is not displayed in the list as selected #36994

Conversation

dukenv0307 commented Feb 21, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 21, 2024

DylanDylann commented Feb 21, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann left a comment

Choose a reason for hiding this comment

cead22 commented Feb 21, 2024

cead22 Feb 21, 2024

Choose a reason for hiding this comment

DylanDylann Feb 22, 2024

Choose a reason for hiding this comment

cead22 Feb 22, 2024

Choose a reason for hiding this comment

dukenv0307 Feb 23, 2024

Choose a reason for hiding this comment

DylanDylann commented Feb 22, 2024

DylanDylann commented Feb 22, 2024 • edited Loading

DylanDylann commented Feb 22, 2024 • edited Loading

cead22 commented Feb 22, 2024

cead22 commented Feb 22, 2024

DylanDylann commented Feb 22, 2024 • edited Loading

cead22 commented Feb 22, 2024

cead22 Feb 22, 2024

Choose a reason for hiding this comment

DylanDylann commented Feb 23, 2024

DylanDylann commented Feb 23, 2024

cead22 commented Feb 23, 2024

DylanDylann commented Feb 23, 2024

OSBotify commented Feb 23, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

DylanDylann commented Feb 21, 2024 •

edited

Loading

DylanDylann commented Feb 22, 2024 •

edited

Loading

DylanDylann commented Feb 22, 2024 •

edited

Loading

DylanDylann commented Feb 22, 2024 •

edited

Loading