-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] IOU - A disabled category in IOU does not deselect when you click on it #35553
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01faafade61edc83ca |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann ( |
Triggered auto assignment to @laurenreidexpensify ( |
We think that this bug might be related to #wave6 |
ProposalPlease re-state the problem that we are trying to solve in this issue.A disabled category in IOU does not deselect when you click on it What is the root cause of that problem?When the number of categories is small, this block will run, and we'll be getting the category option tree based on the If there're a lot of categories (equal or more than What changes do you think we should make in order to solve the problem?When constructing the
What alternative solutions did you explore? (Optional)If instead we want to keep the ordering of the selected category amongst the categories as currently, we can look for the selected category in the current Another approach is: In here we should apply similar logic as well. Not related to this issue but in this line if both parent and child are categories, like |
Proposal updated to add example code change. |
Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
This caused regression. Restored this bug back. |
Sure. |
@DylanDylann Regression fix PR is ready for review #37127. |
@laurenreidexpensify Please help to move forward with this issue, the PR is deployed to production and there are no regression as confirmed here |
@laurenreidexpensify Please help move forward this issue or add Hold for payment label. |
Payment Summary: Contributor $500 paid in Upwork @tienifr |
@DylanDylann pls add checklist and regression step suggestions thank you |
This comment was marked as off-topic.
This comment was marked as off-topic.
I'm not sure we need this very specific regression test to be honest. If none already exist maybe we could create a generic one to test the list component with a disabled item to cover many cases |
@DylanDylann @Julesssss do you have a suggestion for how that could look? Just tryna visualise what the many cases could be. Thanks! |
I found one here. So no need for any new cases |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.35-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4257599
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Preconditions:
Configure the OldDot administrator account, include a maximum of 7 categories and invite the employee to the policy https://sites.google.com/applausemail.com/applause-expensifyproject/wiki-guides/newdot-categories?authuser=0
Steps:
Expected Result:
When you click on a disabled category, it should deselect itself
Actual Result:
A disabled category in IOU does not deselect when you click on it
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6363552_1706788366027.Recording__1245.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: