Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2024-04-25] [TS migration] Migrate 'Sidebar' page to TypeScript #25220

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 31 comments
Closed

[HOLD for payment 2024-04-25] [TS migration] Migrate 'Sidebar' page to TypeScript #25220

melvin-bot bot opened this issue Aug 17, 2023 · 31 comments
Assignees
@AndrewGable @slafortune @stephanieelliott @Santhosh-Sellavel
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Not a priority Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/safeAreaInsetPropTypes.js 1
src/pages/home/sidebar/SidebarLinksData.js 18
src/pages/home/sidebar/SidebarLinks.js 40
src/pages/home/sidebar/SidebarScreen/sidebarPropTypes.js 2
src/pages/home/sidebar/SidebarScreen/index.native.js 6
src/pages/home/sidebar/SidebarScreen/index.js 10
src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js 29
src/pages/home/sidebar/SidebarScreen/BaseSidebarScreen.js 13
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Sep 11, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@fabioh8010
Copy link
Contributor

Updated List

Files

Path Dependencies
src/pages/safeAreaInsetPropTypes.js 1
src/pages/home/sidebar/SignInOrAvatarWithOptionalStatus.js 9
src/pages/home/sidebar/SignInButton.js 8
src/pages/home/sidebar/SidebarNavigationContext.js 0
src/pages/home/sidebar/SidebarLinksData.js 18
src/pages/home/sidebar/SidebarLinks.js 30
src/pages/home/sidebar/PressableAvatarWithIndicator.js 16
src/pages/home/sidebar/AvatarWithOptionalStatus.js 11
src/pages/home/sidebar/SidebarScreen/sidebarPropTypes.js 1
src/pages/home/sidebar/SidebarScreen/index.native.js 6
src/pages/home/sidebar/SidebarScreen/index.js 6
src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js 27
src/pages/home/sidebar/SidebarScreen/BaseSidebarScreen.js 10

@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@fvlvte
Copy link
Contributor

fvlvte commented Dec 15, 2023

I am Kacper Fałat from Callstack - expert contributor group. I’d like to work on this job!

@kosmydel kosmydel mentioned this issue Jan 8, 2024
Merged
50 tasks
@fabioh8010
Copy link
Contributor

Hey @fvlvte , how is the progress on this one?

@melvin-bot melvin-bot bot added the Overdue label Jan 8, 2024
@fabioh8010
Copy link
Contributor

@fvlvte Can you open the Draft PR today? It's impacting other issues

@fvlvte fvlvte mentioned this issue Jan 30, 2024
Closed
50 tasks
@fvlvte
Copy link
Contributor

fvlvte commented Jan 30, 2024

Sure, draft PR is open @fabioh8010

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
@melvin-bot melvin-bot bot removed the Overdue label Feb 5, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Feb 5, 2024
@kubabutkiewicz
Copy link
Contributor

Hi, I'm Kuba from Callstack - expert contributor group - and I would like to take a look at this issue.
I will take over from Kacper

@kubabutkiewicz kubabutkiewicz mentioned this issue Feb 20, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Monthly KSv2 labels Mar 11, 2024
@stephanieelliott stephanieelliott changed the title [HOLD for payment 2024-03-25] [TS migration] Migrate 'Sidebar' page to TypeScript [TS migration] Migrate 'Sidebar' page to TypeScript Mar 26, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Apr 2, 2024
@stephanieelliott
Copy link
Contributor

PR is being actively reviewed

@stephanieelliott
Copy link
Contributor

Changes have been addressed and PR is approved

@Santhosh-Sellavel
Copy link
Collaborator

@AndrewGable Please assign me issue for tracking payment!

@stephanieelliott
Copy link
Contributor

PR is on staging

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 18, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'Sidebar' page to TypeScript [HOLD for payment 2024-04-25] [TS migration] Migrate 'Sidebar' page to TypeScript Apr 18, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Apr 18, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 18, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Apr 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-25. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Apr 18, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Santhosh-Sellavel] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@stephanieelliott stephanieelliott added NewFeature Something to build that is a new item. and removed NewFeature Something to build that is a new item. labels Apr 23, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Apr 23, 2024

Triggered auto assignment to @slafortune (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@stephanieelliott
Copy link
Contributor

Reapplying the New Feature label to get another BZ member on this while I am OOO til May 2. Thanks @slafortune, nothing to do here but issue payment to C+ on 4/25!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 24, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Apr 25, 2024

Payment Summary

Upwork Job

BugZero Checklist (@slafortune)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@slafortune
Copy link
Contributor

@Santhosh-Sellavel can you please accept the offer here and complete the checklist -

@Santhosh-Sellavel
Copy link
Collaborator

Santhosh-Sellavel commented Apr 27, 2024 •
edited
Loading

No Regression Steps needed here as its a migration

@Santhosh-Sellavel
Copy link
Collaborator

I'll collect this one on upwork, accepted the offer!

@slafortune
Copy link
Contributor

Paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewGable AndrewGable

@slafortune slafortune

@stephanieelliott stephanieelliott

@Santhosh-Sellavel Santhosh-Sellavel

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Not a priority Task Typescript Migration
Projects
No open projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
7 participants
@AndrewGable @slafortune @fabioh8010 @fvlvte @kubabutkiewicz @stephanieelliott @Santhosh-Sellavel