[TS migration] Migrate 'Sidebar' page to TypeScript #35357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,9 +118,9 @@ function FloatingActionButtonAndPopover(props) { | |||
| * Checks if user is anonymous. If true, shows the sign in modal, else, | |||
| * executes the callback. | |||
| * | |||
| * @param {Function} callback | |||
| * @param callback | |||
| ? [ | ||
| { | ||
| displayInDefaultIconColor: true, | ||
| contentFit: 'contain', | ||
| contentFit: 'contain' as ImageContentFit, |
There was a problem hiding this comment.
Suggested change
| contentFit: 'contain' as ImageContentFit, | |
| contentFit: 'contain' as const, |
I think this will work
| <FloatingActionButtonAndPopover | ||
| // eslint-disable-next-line react/jsx-props-no-spreading | ||
| {...props} | ||
| innerRef={ref} |
There was a problem hiding this comment.
remove this props , and use forwardRef "normally" which is move forwardRef where we are exporting component and in component do (props, ref) => ... you can take a look on other components
| {...props} | ||
| innerRef={ref} | ||
| /> | ||
| )); | ||
|
|
||
| FloatingActionButtonAndPopoverWithRef.displayName = 'FloatingActionButtonAndPopoverWithRef'; | ||
|
|
||
| export default compose( |
There was a problem hiding this comment.
remove compose usage
| @@ -257,6 +243,7 @@ export default compose( | |||
| }, | |||
| isLoading: { | |||
| key: ONYXKEYS.IS_LOADING_APP, | |||
| selector: (s) => s, | |||
There was a problem hiding this comment.
this is not needed when you properly type withOnyx
|
What's the latest here? Is this a dupe? #36847 |
|
Same as TagPicker, @kubabutkiewicz took over since Kacper left the project and we decided to continue the work in another PR (it was reverted but Jakub will take care of it once he returns from his vacation). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Migrated 'Sidebar' page to TypeScript.
Fixed Issues
$ #25220
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop