-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-10-13] [$1000] mWeb - LHN - Click and long pressing a user report with lot of messages opens mark as unread popup inside report #25460
Comments
Triggered auto assignment to @bfitzexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
OK, let's get some proposals for this one. |
Job added to Upwork: https://www.upwork.com/jobs/~01404d8d81934e3635 |
Triggered auto assignment to @muttmuure ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
ProposalProblemwhen navigation is in progress if user long press the report mark as unread" popup opens inside report What is the root cause of that problem?The root cause is long press execution is not prevented if the navigation in progess resulting in opening of popover inside report. What changes do you think we should make in order to solve the problem?Outdated
In PR we are introducing a new hook + const {isExecuting, singleExecution} = useSingleExecution();
+ const showPopover = (event) => {
+ if (isExecuting) {
+ return;
+ } <PressableWithSecondaryInteraction
ref={popoverAnchor}
onPress={(e) => {
if (e) {
e.preventDefault();
}
+ singleExecution(() => props.onSelectRow(optionItem, popoverAnchor))();
- props.onSelectRow(optionItem, popoverAnchor);
}} 2 alternative solutions proposed - |
Where should I send initial proposal? |
📣 @anukcr7! 📣
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Prevent long press action to take place if user navigated to another screen. What is the root cause of that problem?The code that shows the pop up is here: App/src/components/LHNOptionsList/OptionRowLHN.js Lines 108 to 125 in 329cac3
There is no What changes do you think we should make in order to solve the problem?
On small screen devices, do not show popover if active route is the report screen . // ...
import {Dimensions} from 'react-native'; // add this - using this instead of withDimensions prevents rerenders of list items when resizing screen
import Navigation from '../../libs/Navigation/Navigation'; // add this
import variables from '../../styles/variables'; // add this
function OptionRowLHN(props) {
const popoverAnchor = useRef(null);
const {translate} = useLocalize();
const showPopover = (event) => {
// add begin
const isSmallScreenWidth = Dimensions.get('window').width <= variables.mobileResponsiveWidthBreakpoint;
const isReportRoute = !!Navigation.getActiveRoute().match(CONST.REPORT_ROUTE_REGEX);
if (isSmallScreenWidth && isReportRoute) {
return;
}
// add end
setIsContextMenuActive(true);
ReportActionContextMenu.showContextMenu(
ContextMenuActions.CONTEXT_MENU_TYPES.REPORT,
// ...
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
I have submitted the proposal on Upwork already |
@anukcr7 and @Anmolverma19 information on how to submit proposals is in this document contributing guidelines. |
Proposal Please re-state the problem that we are trying to solve in this issue. What is the root cause of that problem? What changes do you think we should make in order to solve the problem?
Step 2: Identify the Event Handling Logic
Step 3: Modify or Remove the Event Handling Logic
Step 4: Test Extensively
Step 5: Document Changes
Step 6: Create a Pull Request
What alternative solutions did you explore? (Optional)
Step 2: Apply CSS or Styling Changes
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
This comment was marked as resolved.
This comment was marked as resolved.
Here is how it looks with my proposed solution. pop-up-lhn.mov |
@carlosalmonte04 Only raise a PR once your proposal is selected by C+ reviewer. |
we are implementing |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-13. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment summary: Reporter: @dhanashree-sawant $250 to be paid via Upwork - offer sent |
@bfitzexpensify applied thanks. |
Hi @bfitzexpensify, melvin bot already had sent offer for this job 1 month back and I have also accepted this without cross checking so now I have 2 offers for this job. I have one more job which is ready for payment and I don't have offer in it and it was raised 29 August so would be compensated 250$ for it. Summary would be that @kevinksullivan won't have to send me offer in that job and we can approve both the offers for this job. |
not overdue |
@dhanashree-sawant it's better for our audit trails to link payments to the correct job rather than double-paying against a single job, so we'll keep the usual process in place and have you get paid via #26131. Also a friendly reminder @sobitneupane to complete the BZ checklist when you get a moment - thanks! |
@Gonals, @redpanda-bit, @sobitneupane, @bfitzexpensify Huh... This is 4 days overdue. Who can take care of this? |
Bump on the BZ checklist @sobitneupane - thank you! |
Sorry for the delay. I was OOO. I will try to get to this issue in the weekend. |
I believe it was present from the very beginning with the introduction of the feature.
N/A
It is an edge case and very difficult to catch.
Yes.
|
Regression Test Proposal:
Do we agree 👍 or 👎 |
Requested payment on newDot. |
Cool, I agree with that checklist summary. Opened regression test proposal in https://github.com/Expensify/Expensify/issues/331848. We're all done here - thanks everyone! |
$1,000 payment approved for @sobitneupane based on this comment. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
App should not display mark as unread popup inside report
Actual Result:
On opening user report with lots of messages and quickly long press, mark as unread popup gets opened inside the report
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: v1.3.55-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
mark.as.unread.popup.inside.the.report.mp4
Record_2023-08-18-10-06-56.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691495713340339
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: