[HOLD for payment 2023-09-21] [Performance] Improve translations

[mountiny]

[Performance] Improve translations, coming from here

Problem

Translations uses lodashGet which adds some overhead + translations are being called multiple times (some makes sense because of rerenders)

Proposal

We use lodashGet to get the key, so instead of

### Summary of solution
Will remove the need of using lodashGet and its extra overhead,
We need to make sure all translations uses the HOC: withLocalize or the hook: useLocalize or at least going through: Localize.translate

[mountiny]

Asking in callstack room who will take these on

[BeeMargarida]

Hey, as mentioned in the slack, I'll be taking over this one 👋

[mountiny]

Thanks

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[BeeMargarida]

PR to fix regressions is ready: #27358

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Improve translations - flatten translation objects #25846

If no regressions arise, payment will be issued on 2023-09-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @BeeMargarida does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

@BeeMargarida, @mountiny Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@BeeMargarida, @mountiny 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@BeeMargarida, @mountiny 10 days overdue. I'm getting more depressed than Marvin.

[mountiny]

We can close this now, thanks! The reviewer was from Callstack