Pronouns - pronoun not translated when language changes

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #25846

Action Performed:

Pre-conditions: Pronoun option selected he/Him/His/They/Them/Theirs

1. Go to https://staging.new.expensify.com/
2. Tap profile icon
3. Tap preferences
4. Tap language ---> Spanish
5. Navigate back to Settings
6. Tap Profile
7. Tap pronouns

Expected Result:

The pronoun options shown outside must be shown inside with dropdown below of selected pronouns with a tick mark

Actual Result:

The pronouns are shown outside in selected Spanish language correctly but inside displayed in English and "no results found" message displayed instead of showing dropdown below of selected pronouns with a tick mark

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.69-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6199003_web25846.mp4

Bug6199003_android25846.mp4

Bug6199003_pr25846.mp4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan/ Applause - Internal Team

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694594697108839

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect pronoun search displayed

What is the root cause of that problem?

It is a regression from #25846 where we iterate through the array PRONOUNS_LIST consisting of the keys and found key value we are setting in the serachValue instead of the text.
https://github.com/Expensify/App/pull/25846/files#diff-2becc643119bc669cba2992bd64114fa69691d2a7d3fe265026322b57f4c75fdL29-L32

App/src/pages/settings/Profile/PronounsPage.js

Lines 30 to 34 in 9675a77

	const currentPronounsText = _.chain(CONST.PRONOUNS_LIST)
	.find((_value) => _value === currentPronounsKey)
	.value();
	return currentPronounsText || '';

What changes do you think we should make in order to solve the problem?

Making a proposal as I think we can set the value directly.

We already have the currentPronounsKey which we can use directly instead of finding the key again.

const [searchValue, setSearchValue] = useState(currentPronounsKey ? translate(`pronouns.${currentPronounsKey}`) : '')

App/src/pages/settings/Profile/PronounsPage.js

Line 27 in 9675a77

const currentPronounsKey = currentPronouns.substring(CONST.PRONOUNS.PREFIX.length);

cc: @BeeMargarida

What alternative solutions did you explore? (Optional)

With the current implementation, we can translate the found key for setting the search value.

       const pronounKey = _.chain(CONST.PRONOUNS_LIST)
            .find((_value) => _value === currentPronounsKey);
        
        return pronounKey ? translate(`pronouns.${pronounKey}`) : '';

[Pluto0104]

I can consider this issue as dup of #27326.

[AndrewGable]

This is going to be fixed by #27358

[parasharrajat]

Ready to be closed @Li357

[gadhiyamanan]

this is eligible for reporting bonus because this is the first issue which was reported in slack

[gadhiyamanan]

@Li357 can you assign BZ member for reporting bonus

[melvin-bot]

This issue has not been updated in over 15 days. @Li357 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[gadhiyamanan]

bump @Li357

[gadhiyamanan]

Bump @Li357

[melvin-bot]

@Li357, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[gadhiyamanan]

@Li357 reporting bonus is pending here, can you please reopen the issue ..