[$500] [HOLD for payment 2023-09-21] Web - allStates.Greater London.stateName appears on select United state as Country

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings >Profile > Personal details > Home address
2. Click on Country and select United state
3. Check the state

Expected Result:

should not show allStates.Greater London.stateName

Actual Result:

allStates.Greater London.stateName appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.69.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-13.at.2.58.39.PM.mov

Recording.4430.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694597057219419
Original reporter:
https://expensify.slack.com/archives/C049HHMV9SM/p1694597349412869

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e4437f3cf84845b7
• Upwork Job ID: 1706865721848041472
• Last Price Increase: 2023-09-27

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After a state is selected, and the country is changed to USA, the StatePicker component breaks.

Note: in current main branch in dev, it doesn't just show allStates.Greater London.stateName – it breaks the app.

What is the root cause of that problem?

In AddressPage, the StatePicker component has the defaultValue set to the initially selected state.

Because of it, even though we reset the state on country change in handleAddressChange, the value of StatePicker does not change, since the defaultValue is already persisted the moment the StatePicker is rendered.

App/src/pages/settings/Profile/PersonalDetails/AddressPage.js

Lines 119 to 129 in 544661b

	const handleAddressChange = (value, key) => {
	if (key !== 'country' && key !== 'state') {
	return;
	}
	if (key === 'country') {
	setCurrentCountry(value);
	setState('');
	return;
	}
	setState(value);
	};

What changes do you think we should make in order to solve the problem?

My suggestion is to replace defaultValue with value. This will change the selected value in the StatePicker dynamically.

App/src/pages/settings/Profile/PersonalDetails/AddressPage.js

Lines 187 to 191 in 544661b

	<StatePicker
	inputID="state"
	defaultValue={state}
	onValueChange={handleAddressChange}
	/>

                            <StatePicker
                                inputID="state"
-                               defaultValue={state}
+                               value={state}
                                onValueChange={handleAddressChange}
                            />

Result:

https://www.loom.com/share/17db17156d444b648b6382f0870c3489?sid=dee1c244-dc20-448f-81d8-ec9ca3546e8e

What alternative solutions did you explore? (Optional)

[paultsimura]

@madmax330 since this is a blocker – is it still eligible for proposals? If yes – how often are they reviewed?

[madmax330]

@paultsimura I think someone already has the fix, we're just waiting for them to put up the PR

[paultsimura]

@paultsimura I think someone already has the fix, we're just waiting for them to put up the PR

I see this issue was referenced in a PR, but I doubt that PR fixes this issue - it doesn't look like a regression from the translations flattening.

Anyway, let's wait and see what the result would be.

[madmax330]

@paultsimura if you look at the testing videos in the PR description, it is fixed.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[paultsimura]

@paultsimura if you look at the testing videos in the PR description, it is fixed.

You're right, my apologies.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: regressions of flat translations #27358

If no regressions arise, payment will be issued on 2023-09-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @dhanashree-sawant requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[madmax330]

Ah, sorry

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[madmax330]

@kevinksullivan can you just handle the C+ payment? Then we can close the issue

[greg-schroeder]

I'll take care of this @kevinksullivan

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e4437f3cf84845b7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[greg-schroeder]

Just applying external to create an upwork job

[madmax330]

@greg-schroeder I think @parasharrajat gets paid in newDot, do we still need an upwork job for that?

[greg-schroeder]

@madmax330 are we not paying the issue reporter?

[dhanashree-sawant]

Yes my payment too is left 😅

[madmax330]

are we not paying the issue reporter?

Ah yes, forgot about that, sorry :ohnothing:

[greg-schroeder]

Issue Participants:

Issue reported by: @dhanashree-sawant hanashree-sawant
C+: @parasharrajat

Reporter: $50
C+: $500 (+$250 speed bonus)

offer sent to reporter, Rajat you can make a manual request in newdot

[dhanashree-sawant]

Thanks @greg-schroeder, I have accepted the offer

[parasharrajat]

@greg-schroeder Can you please assign me as well to the issue for tracking purposes?

[parasharrajat]

Payment requested as per #27325 (comment)

[JmillsExpensify]

$750 payment approved for @parasharrajat based on BZ summary.