[HOLD for payment 2023-09-07] [$1000] Web - Money Request - Dev - On money request page distance page user is able drag & drop file

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to the money request page
2. Select Distance tab
3. Drag file to this tab
4. Notice use is able to drag & drop file on distance page and can request money directly

Expected Result:

User should not be able to drag & drop files directly on Distance tab same as manually tab

Actual Result:

Describe what actually happened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.56-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-12.At.1.50.41.Am.1.mp4

Recording.2948.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhairyasenjaliya

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691785104348009

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0106fe9a0ed877de3e
• Upwork Job ID: 1693995295563288576
• Last Price Increase: 2023-08-22
• Automatic offers:
• fedirjh | Reviewer | 26292940
• dhairyasenjaliya | Contributor | 26292941
• dhairyasenjaliya | Reporter | 26292942

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[izarutskaya]

Proposal from @dhairyasenjaliya

Please re-state the problem that we are trying to solve in this issue.

• On money request page distance page user is able drag & drop file

What is the root cause of that problem?

• The root cause is we are using <DragAndDropProvider> component on MoneyRequestSelectorPage which is where all 3 tabs are defined here we have handled disabled drag and drop for the manual tab and not handled for distance tab that makes the user allow drag on that tab

What changes do you think we should make in order to solve the problem?

option - 1

• On the below line we can just add one more condition to check if the selected tab is CONST.TAB.DISTANCE then we should pass true on isDisabled props of DragAndDropProvider

isDisabled={props.selectedTab === CONST.TAB.MANUAL || props.selectedTab === CONST.TAB.DISTANCE} // example

App/src/pages/iou/MoneyRequestSelectorPage.js

Line 83 in a2096c8

<DragAndDropProvider isDisabled={props.selectedTab === CONST.TAB.MANUAL}>

option -2

• On the below line we can add a condition whereby we enable drag & drop only if the tab selected is CONST.TAB.SCAN I believe only this tab needs to enable the drag & drop functionality
  

  App/src/pages/iou/MoneyRequestSelectorPage.js

  Line 83 in a2096c8

  <DragAndDropProvider isDisabled={props.selectedTab === CONST.TAB.MANUAL}>

What alternative solutions did you explore? (Optional)

• N/A
  ———————

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0106fe9a0ed877de3e

[melvin-bot]

Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[garrettmknight]

Confirmed, seems like odd behavior.

[MaciejSWM]

+1 to izarutskaya's proposal option 2. Proposal option 2 is better than option 1 since explicit whitelisting instead of blacklisting will prevent exactly this type of errors in the future. There just might be a typo in proposal option 2 as it should be: <DragAndDropProvider isDisabled={props.selectedTab !== CONST.TAB.SCAN}>

[dhairyasenjaliya]

Yeah I just forget to add ! on option 2 BTW I have added that proposal while bug reporting @MaciejSWM

[napster125]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On money request page, users can drag and drop files directly on the Distance tab.

What is the root cause of that problem?

The root cause of the problem is that we are not handling all cases except for the scan tab in the MoneyRequestSelectorPage.
The code snippet provided only handles the manual tab.

App/src/pages/iou/MoneyRequestSelectorPage.js

Line 83 in a2096c8

<DragAndDropProvider isDisabled={props.selectedTab === CONST.TAB.MANUAL}>

What changes do you think we should make in order to solve the problem?

To solve this problem, we can wrap the ReceiptSelector component with the DragAndDropProvider. This will enable drag and drop functionality specially for the ReceiptSelector component. Additionally, we will need to remove the DragAndDropProvider from the MoneyRequestSelectorPage to avoid redundant drag and drop functionality.

App/src/pages/iou/ReceiptSelector/index.js

Lines 107 to 108 in a2096c8

	return (
	<View style={[styles.uploadReceiptView(isSmallScreenWidth)]}>

return (
  <DragAndDropProvider>
    /* ... */
  </DragAndDropProvider>
)

What alternative solutions did you explore? (Optional)

App/src/pages/iou/MoneyRequestSelectorPage.js

Line 83 in a2096c8

<DragAndDropProvider isDisabled={props.selectedTab === CONST.TAB.MANUAL}>

<DragAndDropProvider isDisabled={props.selectedTab !== CONST.TAB.SCAN}>

However, this option has some drawbacks.
Firstly, if we build the Android or iOS app, drag and drop functionality is unnecessary and redundant, making the DragAndDropProvider unnecessary as well.
Secondly, if there are additional tabs added in the future, we would need to add disable logic.
Lastly, when dragging a file, the right-hand navigation (RHN) is covered by the active color. It might be better to only cover the tab content rather than the entire RHN component.

[melvin-bot]

📣 @napster125! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

[napster125]

Contributor details
Your Expensify account email: napster0125@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01212c68bbcaede4db

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[fedirjh]

@dhairyasenjaliya Proposal (2nd option) looks good to me.

---

@napster125 Your solution will break the expected behavior in this test

Verify the drag and drop functionality works for the whole right hand menu

---

Firstly, if we build the Android or iOS app, drag and drop functionality is unnecessary and redundant, making the DragAndDropProvider unnecessary as well.

Hmmm, this is the code for the native, we just return children

App/src/components/DragAndDrop/Provider/index.native.js

Lines 5 to 7 in 9a0dd42

	function DragAndDropProvider({children}) {
	return children;
	}

Secondly, if there are additional tabs added in the future, we would need to add disable logic.

When we implement new tab that need the drag-and-drop, then we should enable it.

Lastly, when dragging a file, the right-hand navigation (RHN) is covered by the active color.

This is the expected behavior as I already mentioned.

[dhairyasenjaliya]

hm @fedirjh I believe Melvin didn't assign an internal member for review perhaps any issue on above template ?

[fedirjh]

Melvin didn't assign an internal

Yeah missed adding the tag

---

Let's proceed with @dhairyasenjaliya Proposal (2nd option).

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dhairyasenjaliya 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dhairyasenjaliya]

@fedirjh PR ready for review

[kaushiktd]

https://drive.google.com/file/d/1gfn-AYSfXMfu5bQ-J73MoJOqtVDPD79U/view?usp=sharing

Has anything changed lately? When I directly try this URL
https://localhost:8082/request/new/distance

It redirects me to this address
https://localhost:8082/request/new

See the issue image,

There are three tabs present but in my video there is none.

Is this happening with someone else here?

[dhairyasenjaliya]

@kaushiktd This feature is in beta it will not be accessed until the release

[fedirjh]

@kaushiktd You should enable this beta from the permissions.js file.

[melvin-bot]

🎯 ⚡️ Woah @fedirjh / @dhairyasenjaliya, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @dhairyasenjaliya got assigned: 2023-08-23 20:50:30 Z
• when the PR got merged: 2023-08-28 19:13:04 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Added Condition to check drag & drop works only on scan page #25750

If no regressions arise, payment will be issued on 2023-09-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment offer (Reviewer)
• @dhairyasenjaliya requires payment offer (Contributor)
• @dhairyasenjaliya requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[fedirjh]

BugZero Checklist:

• Link to the PR: Add an option for distance requests #23048
• Link to comment: Add an option for distance requests #23048 (comment)
• Link to discussion: I think the regression test should be enough for this case.
• Determine if we should create a regression test for this bug:

---

Regression Test Proposal

1. Open App
2. Navigate to the money request page
3. Select the Distance tab
4. Drag any file to this tab
5. Verify that the user can't drag & drop a file on the distance page

• Do we agree 👍 or 👎

[garrettmknight]

Summary of payments

• urgency bonus: yes
• Reporter: @dhairyasenjaliya $250 paid in Upwork
• Contributor: @dhairyasenjaliya $1500 paid in Upwork
• Contributor+: @fedirjh $1500 paid in Upwork

[garrettmknight]

@dhairyasenjaliya just realized that we didn't generate a contract for reporting. I just sent you another offer and will pay the $250 once you accept.

[dhairyasenjaliya]

done @garrettmknight I think there was previous contract but will cancel that

[garrettmknight]

Paid and canceled the duplicate contract.

[dhairyasenjaliya]

@garrettmknight can you please close the contract as well thanx