[HOLD for payment 2023-09-21] [$500] Request Money/Scan: Validation messages are not translated to Spanish #25865

izarutskaya · 2023-08-24T15:51:58Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Click plus button, choose Request Money.
Click scan tab, drag an invalid file to the scan tab (too big > 25MB or too small < 240KB), a validation modal will show.
Open a new tab, change the current language to Spanish.
Notice that validation messages are not translated to Spanish.

Expected Result:

Validation messages should be translated to Spanish

Actual Result:

Validation messages are not translated to Spanish

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.57-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-13.At.11.24.39.mp4

Recording.1315.mp4

Expensify/Expensify Issue URL:

Issue reported by: @hungvu193

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691900667713019

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fbfb6ee98fe603c3
Upwork Job ID: 1696537225664692224
Last Price Increase: 2023-09-01
Automatic offers:

aimane-chnaif | Reviewer | 26568326
hungvu193 | Contributor | 26568328
hungvu193 | Reporter | 26568330

melvin-bot · 2023-08-24T15:52:03Z

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-08-24T15:52:05Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

izarutskaya · 2023-08-24T15:52:30Z

Proposal from @hungvu193

Please re-state the problem that we are trying to solve in this issue.

Request Money/Scan: Validation messages are not translated to Spanish

What is the root cause of that problem?

We're setting the validation message here, instead of translateKey, because of that when the language is changed, it didn't change to Spanish:

App/src/libs/ReceiptUtils.js

Lines 8 to 26 in a03a21d

    
           const validateReceipt = (file) => { 
        
               const {fileExtension} = FileUtils.splitExtensionFromFileName(lodashGet(file, 'name', '')); 
        
               if (_.contains(CONST.API_ATTACHMENT_VALIDATIONS.UNALLOWED_EXTENSIONS, fileExtension.toLowerCase())) { 
        
                   Receipt.setUploadReceiptError(true, Localize.translateLocal('attachmentPicker.wrongFileType'), Localize.translateLocal('attachmentPicker.notAllowedExtension')); 
        
                   return false; 
        
               } 
        
               if (lodashGet(file, 'size', 0) > CONST.API_ATTACHMENT_VALIDATIONS.MAX_SIZE) { 
        
                   Receipt.setUploadReceiptError(true, Localize.translateLocal('attachmentPicker.attachmentTooLarge'), Localize.translateLocal('attachmentPicker.sizeExceeded')); 
        
                   return false; 
        
               } 
        
               if (lodashGet(file, 'size', 0) < CONST.API_ATTACHMENT_VALIDATIONS.MIN_SIZE) { 
        
                   Receipt.setUploadReceiptError(true, Localize.translateLocal('attachmentPicker.attachmentTooSmall'), Localize.translateLocal('attachmentPicker.sizeNotMet')); 
        
                   return false; 
        
               } 
        
               return true; 
        
           };

What changes do you think we should make in order to solve the problem?

We should use translateKey only, so we need to remove all the Localize.translateLocal from our validateReceipt function. For example:

Receipt.setUploadReceiptError(true,'attachmentPicker.attachmentTooLarge', 'attachmentPicker.sizeExceeded');

After that, we should also update our ConfirmModal here, to make it translate the translateKey:

            <ConfirmModal
                title={attachmentInvalidReasonTitle ? translate(attachmentInvalidReasonTitle) :''}
                onConfirm={Receipt.clearUploadReceiptError}
                onCancel={Receipt.clearUploadReceiptError}
                isVisible={isAttachmentInvalid}
                prompt={attachmentInvalidReason ? translate(attachmentInvalidReason) : ''}
                confirmText={translate('common.close')}
                shouldShowCancelButton={false}
            />

What alternative solutions did you explore? (Optional)

N/A

melvin-bot · 2023-08-28T10:00:35Z

@stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

stephanieelliott · 2023-08-29T14:55:53Z

Similar to #25704 (comment), seeing as this is low-priority and not necessarily an upgrade to the app's functionality, I am reducing the payscale for this issue to the following:

Bug reporting bonus: $250
Contributor fix: $500
C+ proposal/PR review: $500

Just noting this before I add the labels to accept proposals.

melvin-bot · 2023-08-29T14:56:05Z

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

melvin-bot · 2023-08-29T14:56:11Z

Job added to Upwork: https://www.upwork.com/jobs/~01fbfb6ee98fe603c3

melvin-bot · 2023-08-29T14:56:14Z

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-08-29T14:56:20Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

ghost · 2023-08-29T14:56:44Z

Dibs

himanshuragi456 · 2023-08-29T14:56:58Z

I'd like to work

stephanieelliott · 2023-08-29T14:59:56Z

Hey @AnshuAgarwal24 @himanshuragi456 this is not a "dibs" situation, if you would like to work on this issue please post a proposal per CONTRIBUTING.md

stephanieelliott · 2023-09-01T20:11:02Z

Updating price to match #25704 (comment). Moving to Weekly since this is low priority.

melvin-bot · 2023-09-01T20:11:26Z

Upwork job price has been updated to $500

melvin-bot · 2023-09-14T10:19:28Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-09-14T10:19:32Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: Request Money/Scan: Validation messages are not translated to Spanish #27089

If no regressions arise, payment will be issued on 2023-09-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@hungvu193 requires payment offer (Contributor)
@aimane-chnaif requires payment offer (Reviewer)
@hungvu193 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-09-14T10:19:33Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

sakluger · 2023-09-14T17:44:47Z

Hey team, I was assigned Android - IOU - Validation message not shown when file above 25mb for Smart Recipe was selected #27389 which Applause created after testing this issue's linked PR. Basically, we're not showing any validation when scanning a receipt file over 25MB.

According to the PR description, the >25MB validation should have been included in the PR. Can anyone help explain why we still deployed that PR to staging and Prod even after QA found an issue?

aimane-chnaif · 2023-09-14T17:53:24Z

@sakluger there's no file size validation on native (iOS/android). Our PR fixes web based platforms only, never touched native code.

sakluger · 2023-09-18T07:38:25Z

I see, so we never had this validation on mobile, thanks for clarifying. I assume we want to prevent attachments >25mb on all platforms, even if we didn't implement it before.

stephanieelliott · 2023-09-22T00:51:59Z

Hey @aimane-chnaif can you complete the BZ checklist please?

Summarizing payment on this issue:

Issue reporter: @hungvu193 $250, paid via Upwork
Contributor: @hungvu193 $750 ($500 C + $250 bonus), paid via Upwork
Contributor+: @aimane-chnaif $750 ($500 C+ + $250 bonus) will pay via Upwork (held on BZ checkllist)

Upwork job is here, 50% bonus is included on final payout

hungvu193 · 2023-09-22T00:53:58Z

Hey @aimane-chnaif can you complete the BZ checklist please?

Summarizing payment on this issue:

Issue reporter: @hungvu193 $50, paid via Upwork

Contributor: @hungvu193 $750 ($500 C + $250 bonus), paid via Upwork

Contributor+: @aimane-chnaif $750 ($500 C+ + $250 bonus) will pay via Upwork (held on BZ checkllist)

Upwork job is here, 50% bonus is included on final payout

I believe reporting bonus will be 250$ according the above comment #25865 (comment)

aimane-chnaif · 2023-09-22T01:02:02Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR: Add ability to Take/Upload Receipts #23046

[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/23046/files#r1333756665

[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

[@aimane-chnaif] Determine if we should create a regression test for this bug.

[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This is super minor localization issue and kind of "update dynamically" issue which was closed recently as not bug.
No regression test is needed.

melvin-bot · 2023-09-25T10:22:40Z

@hungvu193, @stephanieelliott, @stitesExpensify, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

stitesExpensify · 2023-09-26T02:47:49Z

Are we all done here?

hungvu193 · 2023-09-26T03:08:04Z

Hey @aimane-chnaif can you complete the BZ checklist please?
Summarizing payment on this issue:

Issue reporter: @hungvu193 $50, paid via Upwork

Contributor: @hungvu193 $750 ($500 C + $250 bonus), paid via Upwork

Contributor+: @aimane-chnaif $750 ($500 C+ + $250 bonus) will pay via Upwork (held on BZ checkllist)

Upwork job is here, 50% bonus is included on final payout

I believe reporting bonus will be 250$ according the above comment #25865 (comment)

waiting for @stephanieelliott to adjust the reporting bonus to 250$ and urgency bonus.

stephanieelliott · 2023-09-29T05:22:20Z

OK, issued remaining payments to match the updated the payment summary:

$750 to @aimane-chnaif via Upwork
$200 to @hungvu193 for remaining bounty payment (so $250 paid total)

hungvu193 · 2023-09-29T05:55:51Z

OK, issued remaining payments to match the updated the payment summary:

$750 to @aimane-chnaif via Upwork

$200 to @hungvu193 for remaining bounty payment (so $250 paid total)

@stephanieelliott I think you forgot to add urgency bonus for me. It should be 450$ in total (250$ for urgency bonus and 200$ for the reporting bonus).

hungvu193 · 2023-10-03T02:29:32Z

little bump here @stephanieelliott

stephanieelliott · 2023-10-10T18:35:13Z

Sorry for leaving ya hanging on this, @hungvu193!

OK so let's try this one more time:

Reporting bonus: $250 [already paid]
Contributor: $500 job + $250 bonus - $500 already paid = $250 till owed.

Does this make sense? LMK and I'll issue the remaining payment as a bonus in the existing job.

hungvu193 · 2023-10-10T23:41:48Z

Sorry for leaving ya hanging on this, @hungvu193!

OK so let's try this one more time:

Reporting bonus: $250 [already paid]

Contributor: $500 job + $250 bonus - $500 already paid = $250 till owed.

Does this make sense? LMK and I'll issue the remaining payment as a bonus in the existing job.

Thank you. That makes sense :+1

hungvu193 · 2023-10-19T13:27:20Z

Sorry @stephanieelliott , little bump here

stephanieelliott · 2023-10-25T21:34:46Z

Issued $250 bonus to you @hungvu193! We should be squared up now!

izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 24, 2023

melvin-bot bot assigned stephanieelliott Aug 24, 2023

melvin-bot bot added the Overdue label Aug 28, 2023

melvin-bot bot removed the Overdue label Aug 29, 2023

stephanieelliott changed the title ~~Request Money/Scan: Validation messages are not translated to Spanish~~ [$250] Request Money/Scan: Validation messages are not translated to Spanish Aug 29, 2023

stephanieelliott added the External Added to denote the issue can be worked on by a contributor label Aug 29, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 29, 2023

melvin-bot bot assigned aimane-chnaif Aug 29, 2023

melvin-bot bot added the Overdue label Sep 1, 2023

melvin-bot bot removed the Overdue label Sep 1, 2023

stephanieelliott added Weekly KSv2 and removed Daily KSv2 labels Sep 1, 2023

stephanieelliott changed the title ~~[$250] Request Money/Scan: Validation messages are not translated to Spanish~~ [$500] Request Money/Scan: Validation messages are not translated to Spanish Sep 1, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 5, 2023

melvin-bot bot changed the title ~~[$500] Request Money/Scan: Validation messages are not translated to Spanish~~ [HOLD for payment 2023-09-21] [$500] Request Money/Scan: Validation messages are not translated to Spanish Sep 14, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Sep 14, 2023

sakluger mentioned this issue Sep 14, 2023

[$500] Android - IOU - Validation message not shown when file above 25mb for Smart Recipe was selected #27389

Closed

6 tasks

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 21, 2023

aimane-chnaif mentioned this issue Sep 22, 2023

Add ability to Take/Upload Receipts #23046

Merged

56 tasks

melvin-bot bot added the Overdue label Sep 25, 2023

melvin-bot bot removed the Overdue label Sep 26, 2023

melvin-bot bot added the Overdue label Sep 28, 2023

stephanieelliott closed this as completed Sep 29, 2023

melvin-bot bot removed the Overdue label Sep 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-09-21] [$500] Request Money/Scan: Validation messages are not translated to Spanish #25865

[HOLD for payment 2023-09-21] [$500] Request Money/Scan: Validation messages are not translated to Spanish #25865

izarutskaya commented Aug 24, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Aug 24, 2023

melvin-bot bot commented Aug 24, 2023

izarutskaya commented Aug 24, 2023 •

edited

Loading

melvin-bot bot commented Aug 28, 2023

stephanieelliott commented Aug 29, 2023 •

edited

Loading

melvin-bot bot commented Aug 29, 2023

melvin-bot bot commented Aug 29, 2023

melvin-bot bot commented Aug 29, 2023

melvin-bot bot commented Aug 29, 2023

ghost commented Aug 29, 2023

himanshuragi456 commented Aug 29, 2023

stephanieelliott commented Aug 29, 2023

stephanieelliott commented Sep 1, 2023

melvin-bot bot commented Sep 1, 2023

melvin-bot bot commented Sep 14, 2023

melvin-bot bot commented Sep 14, 2023

melvin-bot bot commented Sep 14, 2023

sakluger commented Sep 14, 2023

aimane-chnaif commented Sep 14, 2023

sakluger commented Sep 18, 2023

stephanieelliott commented Sep 22, 2023 •

edited

Loading

hungvu193 commented Sep 22, 2023 •

edited

Loading

aimane-chnaif commented Sep 22, 2023

melvin-bot bot commented Sep 25, 2023

stitesExpensify commented Sep 26, 2023

hungvu193 commented Sep 26, 2023

stephanieelliott commented Sep 29, 2023

hungvu193 commented Sep 29, 2023

hungvu193 commented Oct 3, 2023

stephanieelliott commented Oct 10, 2023

hungvu193 commented Oct 10, 2023

hungvu193 commented Oct 19, 2023

stephanieelliott commented Oct 25, 2023

[HOLD for payment 2023-09-21] [$500] Request Money/Scan: Validation messages are not translated to Spanish #25865

[HOLD for payment 2023-09-21] [$500] Request Money/Scan: Validation messages are not translated to Spanish #25865

Comments

izarutskaya commented Aug 24, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Aug 24, 2023

melvin-bot bot commented Aug 24, 2023

Bug0 Triage Checklist (Main S/O)

izarutskaya commented Aug 24, 2023 • edited Loading

Proposal from @hungvu193

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Aug 28, 2023

stephanieelliott commented Aug 29, 2023 • edited Loading

melvin-bot bot commented Aug 29, 2023

melvin-bot bot commented Aug 29, 2023

melvin-bot bot commented Aug 29, 2023

melvin-bot bot commented Aug 29, 2023

ghost commented Aug 29, 2023

himanshuragi456 commented Aug 29, 2023

stephanieelliott commented Aug 29, 2023

stephanieelliott commented Sep 1, 2023

melvin-bot bot commented Sep 1, 2023

melvin-bot bot commented Sep 14, 2023

melvin-bot bot commented Sep 14, 2023

melvin-bot bot commented Sep 14, 2023

sakluger commented Sep 14, 2023

aimane-chnaif commented Sep 14, 2023

sakluger commented Sep 18, 2023

stephanieelliott commented Sep 22, 2023 • edited Loading

hungvu193 commented Sep 22, 2023 • edited Loading

aimane-chnaif commented Sep 22, 2023

melvin-bot bot commented Sep 25, 2023

stitesExpensify commented Sep 26, 2023

hungvu193 commented Sep 26, 2023

stephanieelliott commented Sep 29, 2023

hungvu193 commented Sep 29, 2023

hungvu193 commented Oct 3, 2023

stephanieelliott commented Oct 10, 2023

hungvu193 commented Oct 10, 2023

hungvu193 commented Oct 19, 2023

stephanieelliott commented Oct 25, 2023

izarutskaya commented Aug 24, 2023 •

edited by melvin-bot bot

Loading

izarutskaya commented Aug 24, 2023 •

edited

Loading

stephanieelliott commented Aug 29, 2023 •

edited

Loading

stephanieelliott commented Sep 22, 2023 •

edited

Loading

hungvu193 commented Sep 22, 2023 •

edited

Loading