[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] IOU - Deletion Button Remains Visible After Changing Date after Delete the Requested Money

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on the plus sign and select "Request Money"
2. Enter the desired amount and email address for the money request
3. Go to the IOU and edit the Date
4. Click on the three dots and select "Delete"
5. Observe that the deletion button and three dots still exist, and if we delete again, an unexpected error occurs in IOU

Expected Result:

he deletion button and three dots should disappear after deleting the requested money in any case

Actual Result:

The deletion button remains visible after deleting the requested money and changing the date, which causes an unexpected error if we try to delete it again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.57-5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

screen-capture.-.2023-08-18T015705.366.mp4

Recording.2996.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Tewodros-GirmaA

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692348919083289

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019e57dec696456a6d
• Upwork Job ID: 1699228556598366208
• Last Price Increase: 2023-09-20

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The deletion button and three dots should disappear after deleting the requested money in any case.

What is the root cause of that problem?

We have conditions to show MoneyRequestHeader here:

App/src/pages/home/ReportScreen.js

Lines 254 to 256 in c029dc5

	if (isSingleTransactionView && !isDeletedParentAction) {
	headerView = (
	<MoneyRequestHeader

Here we are using isDeletedParentAction to check if the parent of the report has been deleted.

App/src/pages/home/ReportScreen.js

Line 238 in c029dc5

const isDeletedParentAction = ReportActionsUtils.isDeletedParentAction(parentReportAction);

But in this function return true when isDeletedParentAction = true and no child action.

App/src/libs/ReportActionsUtils.js

Lines 67 to 69 in c029dc5

	function isDeletedParentAction(reportAction) {
	return lodashGet(reportAction, ['message', 0, 'isDeletedParentAction'], false) && lodashGet(reportAction, 'childVisibleActionCount', 0) > 0;
	}

Since the message changes the date or change description, the amount we don't count as 1 childVisibleAction, because this function will return false when there is no childVisibleActionCount.

There is also 1 case, when we have a comment in the thread. we delete request money for the first time this function will return true, and then remove the comment this function returns false. Leads to show MoneyRequestHeader.

What changes do you think we should make in order to solve the problem?

Here we should use isDeletedAction instead of isDeletedParentAction.

const isDeletedParentAction = ReportActionsUtils.isDeletedAction(parentReportAction);

What alternative solutions did you explore? (Optional)

Also, I think we should also update the getTransactionReportName function here

 if (ReportActionsUtils.isDeletedAction(reportAction)) {

[melvin-bot]

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[anmurali]

Will reproduce and slap the label on tomorrow

[melvin-bot]

@anmurali Huh... This is 4 days overdue. Who can take care of this?

[anmurali]

Adding an external label

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019e57dec696456a6d

[melvin-bot]

Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[dukenv0307]

Proposal

Bring a proposal from this issue #24413

Please re-state the problem that we are trying to solve in this issue.

Request money - Delete request reopens on deleting message in it and again deleting it triggers red dot error

What is the root cause of that problem?

We have two errors here

1. Inconsistent header when the request money is deleted or not

When the request money is deleted, the header render HeaderView because isDeletedParentAction is true. That makes the avatar can clickable, and after clicking on this the detail page appears

App/src/pages/home/ReportScreen.js

Lines 261 to 263 in dd0d98f

	if (isSingleTransactionView && !isDeletedParentAction) {
	headerView = (
	<MoneyRequestHeader

2. The title of the header is wrong when we delete the message of the request money report

In getTransactionReportName function, we use ReportActionsUtils.isDeletedParentAction function to check whether the report action is deleted or not

App/src/libs/ReportUtils.js

Lines 1258 to 1260 in dd0d98f

	if (ReportActionsUtils.isDeletedParentAction(reportAction)) {
	return Localize.translateLocal('parentReportAction.deletedRequest');
	}

When we delete the only message of the report, because childVisibleActionCount is updated to 0, this function returns false and then the title of the header is wrong

App/src/libs/ReportActionsUtils.js

Line 69 in dd0d98f

return lodashGet(reportAction, ['message', 0, 'isDeletedParentAction'], false) && lodashGet(reportAction, 'childVisibleActionCount', 0) > 0;

What changes do you think we should make in order to solve the problem?

1. We should always display MoneyRequestHeader for transaction view to make the avatar cannot clickable.

if (isSingleTransactionView) {
    headerView = (
        <MoneyRequestHeader
        ....

App/src/pages/home/ReportScreen.js

Lines 261 to 263 in dd0d98f

	if (isSingleTransactionView && !isDeletedParentAction) {
	headerView = (
	<MoneyRequestHeader

And in MoneyRequestHeader we will hide the three-dot if the money request is deleted

shouldShowThreeDotsButton={!isPayer && !isSettled && !ReportActionsUtils.isDeletedAction(parentReportAction)}

App/src/components/MoneyRequestHeader.js

Line 79 in dd0d98f

shouldShowThreeDotsButton={!isPayer && !isSettled}

2. In getTransactionReportName, we should use ReportActionsUtils.isDeletedAction to check whether the action is deleted or not instead of using isDeletedParentAction function

if (ReportActionsUtils.isDeletedAction(reportAction)) {
    return Localize.translateLocal('parentReportAction.deletedRequest');
}

App/src/libs/ReportUtils.js

Lines 1258 to 1260 in dd0d98f

	if (ReportActionsUtils.isDeletedParentAction(reportAction)) {
	return Localize.translateLocal('parentReportAction.deletedRequest');
	}

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.11-08-2023.18.30.35.webm

[melvin-bot]

@anmurali, @allroundexperts Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@anmurali, @allroundexperts Huh... This is 4 days overdue. Who can take care of this?

[tsa321]

Similar to #25997

[dukenv0307]

It think this is not the same.

[melvin-bot]

@joelbettner, @anmurali, @allroundexperts, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@joelbettner, @anmurali, @allroundexperts, @dukenv0307 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[joelbettner]

@anmurali I'll let you field this question: #26019 (comment)

Sorry, @dhanashree-sawant I'm not involved with the payouts, so I don't know.

[dhanashree-sawant]

Sure that's okay, @anmurali can you check it once you are available?

[melvin-bot]

@joelbettner, @anmurali, @allroundexperts, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@joelbettner, @anmurali, @allroundexperts, @dukenv0307 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@joelbettner, @anmurali, @allroundexperts, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

[allroundexperts]

Checklist

1. Fix: Approved requests shouldn't have a delete option #27952
2. https://github.com/Expensify/App/pull/27952/files#r1391750954
3. I don't think that anything in the checklist could have prevented this. This should have been caught in manual testing. As such, Slack discussion is not needed.
4. Regression test would be helpful. The steps given in the OP are clear enough and should be good.

[anmurali]

Payment Summary

• Reporting Bonus of $250 each to @dhanashree-sawant (as she also reported a bug that was fixed in this issue) and @TewodrosGirma)
• Contributor @dukenv0307 $500+$250 (speed bonus)
• Contributor plus @allroundexperts $500+$250 (speed bonus)

[allroundexperts]

@anmurali This one is eligible for the 50% bonus. The PR was created before Oct 24, and was merged in just a single day.

[dhanashree-sawant]

Thanks @anmurali for going through that issue and awarding reporting bonus to me. Actually, this as well as #24413 is reported before 30 August, can you send us 250$ offer for it? (If it is decided to provide 50$ each as we are awarding 2 reporters reporting bonus then that's okay)

[tewodrosGirmaA]

Hello, @anmurali. This matter was reported prior to August 30th. Could you please provide us with a $250 offer

[JmillsExpensify]

$750 payment approved for @allroundexperts based on this comment.

[dukenv0307]

@JmillsExpensify @anmurali Do I need to apply for the job in Upwork? If yes, please send me the Upwork link so I can accept this. Thanks.

[melvin-bot]

@joelbettner, @anmurali, @allroundexperts, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[tewodrosGirmaA]

@anmurali Thank you, I accepted it

[melvin-bot]

@joelbettner, @anmurali, @allroundexperts, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@joelbettner, @anmurali, @allroundexperts, @dukenv0307 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[anmurali]

Paid.